commit | fdb92012fb040f25611df9795b927d68f3b218e5 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@webrtc.org> | Thu Nov 09 19:55:44 2017 +0100 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Nov 13 13:53:38 2017 +0000 |
tree | a372604b3ce74e87392a74e86c1ef6ae934ddc72 | |
parent | 616e3138b8f7dae5a53680ca56e6b22550c7eb60 [diff] |
Avoid use-after-move in PeerConnection::Set[Local/Remote]Description. In Set[Local/Remote]Description we have a raw pointer |desc| whose ownership is passed to a helper function. Before this CL we continue to use |desc| after ownership is passed under the assumption that the object is not deleted. In this CL, we instead rely on [local/remote]_description() after the helper function has been called. In practice, this is a pointer to the same object, but it removes the assumption about |desc| being valid after its ownership is passed. Bug: None Change-Id: I144a190ea00f303f4713b64c45aa3e811c0f4b2e Reviewed-on: https://webrtc-review.googlesource.com/21320 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20654}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.