blob: 1e4bf6200360ec7f61d7e922db9cb7ae6cf9981b [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020015#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070017#include "api/jsep.h"
18#include "api/mediastreaminterface.h"
19#include "api/peerconnectioninterface.h"
Anders Carlsson67537952018-05-03 11:28:29 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Seth Hampson5b4f0752018-04-02 16:31:36 -070022#include "pc/mediasession.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070023#include "pc/mediastream.h"
24#include "pc/mediastreamtrack.h"
25#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080026#include "pc/sdputils.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070027#include "pc/test/fakeaudiocapturemodule.h"
28#include "pc/test/mockpeerconnectionobservers.h"
29#include "rtc_base/checks.h"
30#include "rtc_base/gunit.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070031#include "rtc_base/refcountedobject.h"
32#include "rtc_base/scoped_ref_ptr.h"
33#include "rtc_base/thread.h"
Qingsi Wang7fc821d2018-07-12 12:54:53 -070034#include "system_wrappers/include/metrics_default.h"
Steve Anton9158ef62017-11-27 13:01:52 -080035#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070036
37// This file contains tests for RTP Media API-related behavior of
38// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
39
Steve Anton9158ef62017-11-27 13:01:52 -080040namespace webrtc {
41
42using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
43using ::testing::ElementsAre;
44using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070045using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070046
Henrik Boström31638672017-11-23 17:48:32 +010047const uint32_t kDefaultTimeout = 10000u;
48
49template <typename MethodFunctor>
50class OnSuccessObserver : public rtc::RefCountedObject<
51 webrtc::SetRemoteDescriptionObserverInterface> {
52 public:
53 explicit OnSuccessObserver(MethodFunctor on_success)
54 : on_success_(std::move(on_success)) {}
55
56 // webrtc::SetRemoteDescriptionObserverInterface implementation.
57 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
58 RTC_CHECK(error.ok());
59 on_success_();
60 }
61
62 private:
63 MethodFunctor on_success_;
64};
65
Steve Anton3172c032018-05-03 15:30:18 -070066class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070067 public:
Steve Anton3172c032018-05-03 15:30:18 -070068 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
69 : sdp_semantics_(sdp_semantics),
70 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080071 CreatePeerConnectionFactory(rtc::Thread::Current(),
72 rtc::Thread::Current(),
73 rtc::Thread::Current(),
74 FakeAudioCaptureModule::Create(),
75 CreateBuiltinAudioEncoderFactory(),
76 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +020077 CreateBuiltinVideoEncoderFactory(),
78 CreateBuiltinVideoDecoderFactory(),
79 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -070080 nullptr /* audio_processing */)) {
81 webrtc::metrics::Reset();
82 }
Henrik Boström933d8b02017-10-10 10:05:16 -070083
Steve Anton9158ef62017-11-27 13:01:52 -080084 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
85 return CreatePeerConnection(RTCConfiguration());
86 }
87
Steve Antone831b8c2018-02-01 12:22:16 -080088 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
89 RTCConfiguration config;
90 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -070091 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -080092 }
93
Steve Anton9158ef62017-11-27 13:01:52 -080094 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
95 RTCConfiguration config;
96 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -070097 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -080098 }
99
100 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
101 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700102 RTCConfiguration modified_config = config;
103 modified_config.sdp_semantics = sdp_semantics_;
104 return CreatePeerConnectionInternal(modified_config);
105 }
106
107 protected:
108 const SdpSemantics sdp_semantics_;
109 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
110
111 private:
112 // Private so that tests don't accidentally bypass the SdpSemantics
113 // adjustment.
114 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
115 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200116 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700117 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
118 observer.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200119 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
120 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700121 }
Steve Anton3172c032018-05-03 15:30:18 -0700122};
Henrik Boström933d8b02017-10-10 10:05:16 -0700123
Steve Anton3172c032018-05-03 15:30:18 -0700124class PeerConnectionRtpTest
125 : public PeerConnectionRtpBaseTest,
126 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700127 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700128 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
129};
130
131class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
132 protected:
133 PeerConnectionRtpTestPlanB()
134 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
135};
136
137class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
138 protected:
139 PeerConnectionRtpTestUnifiedPlan()
140 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700141};
142
Henrik Boström31638672017-11-23 17:48:32 +0100143// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
144// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100145
Steve Anton3172c032018-05-03 15:30:18 -0700146TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700147 auto caller = CreatePeerConnection();
148 auto callee = CreatePeerConnection();
149
Steve Anton3172c032018-05-03 15:30:18 -0700150 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700151 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700152
Henrik Boström31638672017-11-23 17:48:32 +0100153 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700154 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100155 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700156
157 if (sdp_semantics_ == SdpSemantics::kPlanB) {
158 // Since we are not supporting the no stream case with Plan B, there should
159 // be a generated stream, even though we didn't set one with AddTrack.
160 ASSERT_EQ(1u, add_track_event.streams.size());
161 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
162 } else {
163 EXPECT_EQ(0u, add_track_event.streams.size());
164 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700165}
166
Steve Anton3172c032018-05-03 15:30:18 -0700167TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700168 auto caller = CreatePeerConnection();
169 auto callee = CreatePeerConnection();
170
Steve Anton3172c032018-05-03 15:30:18 -0700171 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700172 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700173
Henrik Boström31638672017-11-23 17:48:32 +0100174 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100175 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100176 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700177 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100178 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
179 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700180}
181
Steve Anton3172c032018-05-03 15:30:18 -0700182TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700183 auto caller = CreatePeerConnection();
184 auto callee = CreatePeerConnection();
185
Steve Anton3172c032018-05-03 15:30:18 -0700186 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700187 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100188 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700189 ASSERT_TRUE(
190 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
191
Henrik Boström933d8b02017-10-10 10:05:16 -0700192 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700193 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700194
Henrik Boström31638672017-11-23 17:48:32 +0100195 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700196 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
197 callee->observer()->remove_track_events_);
198}
199
Steve Anton3172c032018-05-03 15:30:18 -0700200TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700201 auto caller = CreatePeerConnection();
202 auto callee = CreatePeerConnection();
203
Steve Anton3172c032018-05-03 15:30:18 -0700204 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700205 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100206 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700207 ASSERT_TRUE(
208 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
209
Henrik Boström933d8b02017-10-10 10:05:16 -0700210 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700211 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700212
Henrik Boström31638672017-11-23 17:48:32 +0100213 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700214 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
215 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700216 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700217}
218
Steve Anton3172c032018-05-03 15:30:18 -0700219TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700220 auto caller = CreatePeerConnection();
221 auto callee = CreatePeerConnection();
222
Seth Hampson845e8782018-03-02 11:34:10 -0800223 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700224 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
225 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700226 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100227 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700228 ASSERT_TRUE(
229 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700230
231 // Remove "audio_track1".
232 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700233 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100234 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700235 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800236 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700237 callee->observer()->add_track_events_[0].receiver},
238 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700239 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
240 ASSERT_TRUE(
241 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700242
243 // Remove "audio_track2".
244 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700245 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100246 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700247 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
248 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700249 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700250}
251
Seth Hampson5b4f0752018-04-02 16:31:36 -0700252// Tests the edge case that if a stream ID changes for a given track that both
253// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700254TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700255 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
256 auto caller = CreatePeerConnection();
257 auto callee = CreatePeerConnection();
258
259 const char kStreamId1[] = "stream1";
260 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700261 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700262 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700263 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
264
265 // Change the stream ID of the sender in the session description.
266 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700267 auto* audio_desc =
268 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700269 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
270 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700271 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700272
273 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
274 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
275 kStreamId2);
276 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
277 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
278 kStreamId1);
279}
280
Steve Anton8b815cd2018-02-16 16:14:42 -0800281// Tests that setting a remote description with sending transceivers will fire
282// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700283// with receive only transceivers will not call OnTrack. One transceiver is
284// created without any stream_ids, while the other is created with multiple
285// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700286TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700287 const std::string kStreamId1 = "video_stream1";
288 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700289 auto caller = CreatePeerConnection();
290 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800291
292 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700293 RtpTransceiverInit video_transceiver_init;
294 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
295 auto video_transceiver =
296 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800297
298 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
299
300 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
301 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
302 EXPECT_EQ(audio_transceiver->mid(),
303 callee->pc()->GetTransceivers()[0]->mid());
304 EXPECT_EQ(video_transceiver->mid(),
305 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700306 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
307 callee->pc()->GetTransceivers()[0]->receiver()->streams();
308 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
309 callee->pc()->GetTransceivers()[1]->receiver()->streams();
310 ASSERT_EQ(0u, audio_streams.size());
311 ASSERT_EQ(2u, video_streams.size());
312 EXPECT_EQ(kStreamId1, video_streams[0]->id());
313 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800314}
315
316// Test that doing additional offer/answer exchanges with no changes to tracks
317// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700318TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
319 auto caller = CreatePeerConnection();
320 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800321
322 caller->AddAudioTrack("audio");
323 callee->AddAudioTrack("audio");
324
325 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
326 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
327 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
328
329 // If caller reoffers with no changes expect no additional OnTrack calls.
330 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
331 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
332 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
333
334 // Also if callee reoffers with no changes expect no additional OnTrack calls.
335 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
336 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
337 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
338}
339
340// Test that OnTrack is called when the transceiver direction changes to send
341// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700342TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
343 auto caller = CreatePeerConnection();
344 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800345
346 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
347 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
348 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
349 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
350 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
351
352 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
353 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
354 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
355 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
356
357 // If the direction changes but it is still receiving on the remote side, then
358 // OnTrack should not be fired again.
359 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
360 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
361 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
362 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
363}
364
365// Test that OnTrack is called twice when a sendrecv call is started, the callee
366// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700367TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
368 auto caller = CreatePeerConnection();
369 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800370
371 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
372
373 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
374 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
375 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
376
377 // Put the call on hold by no longer receiving the track.
378 callee->pc()->GetTransceivers()[0]->SetDirection(
379 RtpTransceiverDirection::kInactive);
380
381 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
382 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
383 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
384
385 // Resume the call by changing the direction to recvonly. This should call
386 // OnTrack again on the callee side.
387 callee->pc()->GetTransceivers()[0]->SetDirection(
388 RtpTransceiverDirection::kRecvOnly);
389
390 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
391 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
392 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
393}
394
Steve Anton3172c032018-05-03 15:30:18 -0700395// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700396// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700397TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700398 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100399 auto caller = CreatePeerConnection();
400 auto callee = CreatePeerConnection();
401
Steve Anton3172c032018-05-03 15:30:18 -0700402 caller->AddAudioTrack("audio_track", {});
403
404 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
405 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
406
407 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700408 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700409}
410
411// Test that setting a remote offer twice with no answer in the middle and the
412// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700413// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700414TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700415 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700416 auto caller = CreatePeerConnection();
417 auto callee = CreatePeerConnection();
418
419 auto sender = caller->AddAudioTrack("audio_track", {});
420
421 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
422 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700423 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700424
425 caller->pc()->RemoveTrack(sender);
426
427 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
428 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700429 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
430}
431
432// Test that changing the direction from receiving to not receiving between
433// setting the remote offer and creating / setting the local answer results in
434// a remove track event when SetLocalDescription is called.
435TEST_F(PeerConnectionRtpTestUnifiedPlan,
436 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
437 auto caller = CreatePeerConnection();
438 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
439 auto callee = CreatePeerConnection();
440 callee->AddAudioTrack("audio_track", {});
441
442 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
443 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700444 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700445
446 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
447 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
448
449 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
450 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
451 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700452}
453
454// These tests examine the state of the peer connection as a result of
455// performing SetRemoteDescription().
456
457TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
458 auto caller = CreatePeerConnection();
459 auto callee = CreatePeerConnection();
460
461 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700462 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100463
464 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
465 auto receiver_added = callee->pc()->GetReceivers()[0];
466 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700467
468 if (sdp_semantics_ == SdpSemantics::kPlanB) {
469 // Since we are not supporting the no stream case with Plan B, there should
470 // be a generated stream, even though we didn't set one with AddTrack.
471 ASSERT_EQ(1u, receiver_added->streams().size());
472 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
473 } else {
474 EXPECT_EQ(0u, receiver_added->streams().size());
475 }
Henrik Boström31638672017-11-23 17:48:32 +0100476}
477
Steve Anton3172c032018-05-03 15:30:18 -0700478TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100479 auto caller = CreatePeerConnection();
480 auto callee = CreatePeerConnection();
481
Steve Anton3172c032018-05-03 15:30:18 -0700482 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700483 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100484
485 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
486 auto receiver_added = callee->pc()->GetReceivers()[0];
487 EXPECT_EQ("audio_track", receiver_added->track()->id());
488 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700489 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100490 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
491}
492
Steve Anton3172c032018-05-03 15:30:18 -0700493TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100494 auto caller = CreatePeerConnection();
495 auto callee = CreatePeerConnection();
496
Steve Anton3172c032018-05-03 15:30:18 -0700497 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100498 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700499 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
500
Henrik Boström31638672017-11-23 17:48:32 +0100501 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
502 auto receiver = callee->pc()->GetReceivers()[0];
503 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700504 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100505
Steve Anton3172c032018-05-03 15:30:18 -0700506 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
507 // With Unified Plan the receiver stays but the transceiver transitions to
508 // inactive.
509 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
510 EXPECT_EQ(RtpTransceiverDirection::kInactive,
511 callee->pc()->GetTransceivers()[0]->current_direction());
512 } else {
513 // With Plan B the receiver is removed.
514 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
515 }
Henrik Boström31638672017-11-23 17:48:32 +0100516}
517
Steve Anton3172c032018-05-03 15:30:18 -0700518TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100519 auto caller = CreatePeerConnection();
520 auto callee = CreatePeerConnection();
521
Steve Anton3172c032018-05-03 15:30:18 -0700522 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100523 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700524 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100525 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
526 auto receiver = callee->pc()->GetReceivers()[0];
527 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700528 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100529
Steve Anton3172c032018-05-03 15:30:18 -0700530 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
531 // With Unified Plan the receiver stays but the transceiver transitions to
532 // inactive.
533 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
534 EXPECT_EQ(RtpTransceiverDirection::kInactive,
535 callee->pc()->GetTransceivers()[0]->current_direction());
536 } else {
537 // With Plan B the receiver is removed.
538 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
539 }
Henrik Boström31638672017-11-23 17:48:32 +0100540}
541
Steve Anton3172c032018-05-03 15:30:18 -0700542TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100543 auto caller = CreatePeerConnection();
544 auto callee = CreatePeerConnection();
545
Seth Hampson845e8782018-03-02 11:34:10 -0800546 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700547 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
548 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
549 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
550 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100551
552 // Remove "audio_track1".
553 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700554 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
555
556 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
557 // With Unified Plan the receiver stays but the transceiver transitions to
558 // inactive.
559 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
560 auto transceiver = callee->pc()->GetTransceivers()[0];
561 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
562 EXPECT_EQ(RtpTransceiverDirection::kInactive,
563 transceiver->current_direction());
564 } else {
565 // With Plan B the receiver is removed.
566 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
567 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
568 }
Henrik Boström31638672017-11-23 17:48:32 +0100569
570 // Remove "audio_track2".
571 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700572 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
573
574 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
575 // With Unified Plan the receiver stays but the transceiver transitions to
576 // inactive.
577 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
578 auto transceiver = callee->pc()->GetTransceivers()[1];
579 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
580 EXPECT_EQ(RtpTransceiverDirection::kInactive,
581 transceiver->current_direction());
582 } else {
583 // With Plan B the receiver is removed.
584 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
585 }
Henrik Boström31638672017-11-23 17:48:32 +0100586}
587
Florent Castelliabe301f2018-06-12 18:33:49 +0200588TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
589 auto caller = CreatePeerConnection();
590 auto callee = CreatePeerConnection();
591 auto sender = caller->AddAudioTrack("audio_track");
592 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
593
594 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
595 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
596
597 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
598 auto receiver = callee->pc()->GetReceivers()[0];
599 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
600}
601
602TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
603 auto caller = CreatePeerConnection();
604 auto callee = CreatePeerConnection();
605 auto sender = caller->AddVideoTrack("video_track");
606 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
607
608 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
609 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
610
611 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
612 auto receiver = callee->pc()->GetReceivers()[0];
613 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
614}
615
Henrik Boström31638672017-11-23 17:48:32 +0100616// Invokes SetRemoteDescription() twice in a row without synchronizing the two
617// calls and examine the state of the peer connection inside the callbacks to
618// ensure that the second call does not occur prematurely, contaminating the
619// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700620TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100621 StatesCorrelateWithSetRemoteDescriptionCall) {
622 auto caller = CreatePeerConnection();
623 auto callee = CreatePeerConnection();
624
Henrik Boström31638672017-11-23 17:48:32 +0100625 // Create SDP for adding a track and for removing it. This will be used in the
626 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700627 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100628 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
629 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
630 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
631
632 // In the first SetRemoteDescription() callback, check that we have a
633 // receiver for the track.
634 auto pc = callee->pc();
635 bool srd1_callback_called = false;
636 auto srd1_callback = [&srd1_callback_called, &pc]() {
637 EXPECT_EQ(pc->GetReceivers().size(), 1u);
638 srd1_callback_called = true;
639 };
640
641 // In the second SetRemoteDescription() callback, check that the receiver has
642 // been removed.
643 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
644 // Instead, the transceiver owning the receiver will become inactive.
645 // https://crbug.com/webrtc/7600
646 bool srd2_callback_called = false;
647 auto srd2_callback = [&srd2_callback_called, &pc]() {
648 EXPECT_TRUE(pc->GetReceivers().empty());
649 srd2_callback_called = true;
650 };
651
652 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
653 // calls. The callbacks verify that the two calls are synchronized, as in, the
654 // effects of the second SetRemoteDescription() call must not have happened by
655 // the time the first callback is invoked. If it has then the receiver that is
656 // added as a result of the first SetRemoteDescription() call will already
657 // have been removed as a result of the second SetRemoteDescription() call
658 // when the first callback is invoked.
659 callee->pc()->SetRemoteDescription(
660 std::move(srd1_sdp),
661 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
662 callee->pc()->SetRemoteDescription(
663 std::move(srd2_sdp),
664 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
665 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
666 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
667}
668
Seth Hampson5897a6e2018-04-03 11:16:33 -0700669// Tests that a remote track is created with the signaled MSIDs when they are
670// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
671// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700672TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
673 auto caller = CreatePeerConnection();
674 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700675 const char kStreamId1[] = "stream1";
676 const char kStreamId2[] = "stream2";
677 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
678 {kStreamId1, kStreamId2});
679
680 auto offer = caller->CreateOfferAndSetAsLocal();
681 // Munge the offer to take out everything but the stream_ids.
682 auto contents = offer->description()->contents();
683 ASSERT_TRUE(!contents.empty());
684 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
685 std::vector<std::string> stream_ids =
686 contents[0].media_description()->streams()[0].stream_ids();
687 contents[0].media_description()->mutable_streams().clear();
688 cricket::StreamParams new_stream;
689 new_stream.set_stream_ids(stream_ids);
690 contents[0].media_description()->AddStream(new_stream);
691
692 // Set the remote description and verify that the streams were added to the
693 // receiver correctly.
694 ASSERT_TRUE(
695 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
696 auto receivers = callee->pc()->GetReceivers();
697 ASSERT_EQ(receivers.size(), 1u);
698 ASSERT_EQ(receivers[0]->streams().size(), 2u);
699 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
700 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
701}
702
Seth Hampson5b4f0752018-04-02 16:31:36 -0700703// Tests that with Unified Plan if the the stream id changes for a track when
704// when setting a new remote description, that the media stream is updated
705// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700706// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
707// test.
708TEST_F(PeerConnectionRtpTestUnifiedPlan,
709 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700710 auto caller = CreatePeerConnection();
711 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700712
713 const char kStreamId1[] = "stream1";
714 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700715 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700716 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700717 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
718
719 // Change the stream id of the sender in the session description.
720 auto offer = caller->CreateOfferAndSetAsLocal();
721 auto contents = offer->description()->contents();
722 ASSERT_EQ(contents.size(), 1u);
723 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
724 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
725 {kStreamId2});
726
Steve Anton0f5400a2018-07-17 14:25:36 -0700727 // Set the remote description and verify that the stream was updated
728 // properly.
729 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700730 auto receivers = callee->pc()->GetReceivers();
731 ASSERT_EQ(receivers.size(), 1u);
732 ASSERT_EQ(receivers[0]->streams().size(), 1u);
733 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
734}
735
736// This tests a regression caught by a downstream client, that occured when
737// applying a remote description with a SessionDescription object that
738// contained StreamParams that didn't have ids. Although there were multiple
739// remote audio senders, FindSenderInfo didn't find them as unique, because
740// it looked up by StreamParam.id, which none had. This meant only one
741// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700742TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700743 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
744 auto caller = CreatePeerConnection();
745 auto callee = CreatePeerConnection();
746
747 const char kStreamId1[] = "stream1";
748 const char kStreamId2[] = "stream2";
749 caller->AddAudioTrack("audio_track1", {kStreamId1});
750 caller->AddAudioTrack("audio_track2", {kStreamId2});
751
752 auto offer = caller->CreateOfferAndSetAsLocal();
753 auto mutable_streams =
754 cricket::GetFirstAudioContentDescription(offer->description())
755 ->mutable_streams();
756 ASSERT_EQ(mutable_streams.size(), 2u);
757 // Clear the IDs in the StreamParams.
758 mutable_streams[0].id.clear();
759 mutable_streams[1].id.clear();
760 ASSERT_TRUE(
761 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
762
763 auto receivers = callee->pc()->GetReceivers();
764 ASSERT_EQ(receivers.size(), 2u);
765 ASSERT_EQ(receivers[0]->streams().size(), 1u);
766 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
767 ASSERT_EQ(receivers[1]->streams().size(), 1u);
768 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
769}
770
Henrik Boström31638672017-11-23 17:48:32 +0100771// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100772
773// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700774TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100775 auto caller = CreatePeerConnection();
776 auto callee = CreatePeerConnection();
777
778 std::string error;
779 ASSERT_TRUE(
780 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
781}
782
783// Verifies legacy behavior: The observer is not called if if the peer
784// connection is destroyed because the asynchronous callback is executed in the
785// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700786TEST_P(PeerConnectionRtpTest,
787 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100788 auto caller = CreatePeerConnection();
789 auto callee = CreatePeerConnection();
790
791 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
792 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
793
794 auto offer = caller->CreateOfferAndSetAsLocal();
795 callee->pc()->SetRemoteDescription(observer, offer.release());
796 callee = nullptr;
797 rtc::Thread::Current()->ProcessMessages(0);
798 EXPECT_FALSE(observer->called());
799}
800
Steve Antonf9381f02017-12-14 10:23:57 -0800801// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800802
803// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700804TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
805 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800806 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
807}
808
809// Test that a transceiver created with the audio kind has the correct initial
810// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700811TEST_F(PeerConnectionRtpTestUnifiedPlan,
812 AddTransceiverHasCorrectInitProperties) {
813 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800814
815 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200816 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800817 EXPECT_FALSE(transceiver->stopped());
818 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200819 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800820}
821
822// Test that adding a transceiver with the audio kind creates an audio sender
823// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700824TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800825 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700826 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800827
828 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800829 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800830
831 ASSERT_TRUE(transceiver->sender());
832 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
833
834 ASSERT_TRUE(transceiver->receiver());
835 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
836
837 auto track = transceiver->receiver()->track();
838 ASSERT_TRUE(track);
839 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
840 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
841}
842
843// Test that adding a transceiver with the video kind creates an video sender
844// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700845TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800846 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700847 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800848
849 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800850 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800851
852 ASSERT_TRUE(transceiver->sender());
853 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
854
855 ASSERT_TRUE(transceiver->receiver());
856 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
857
858 auto track = transceiver->receiver()->track();
859 ASSERT_TRUE(track);
860 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
861 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
862}
863
864// Test that after a call to AddTransceiver, the transceiver shows in
865// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
866// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700867TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
868 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800869
870 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
871 EXPECT_EQ(
872 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
873 caller->pc()->GetTransceivers());
874 EXPECT_EQ(
875 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
876 transceiver->sender()},
877 caller->pc()->GetSenders());
878 EXPECT_EQ(
879 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
880 transceiver->receiver()},
881 caller->pc()->GetReceivers());
882}
883
884// Test that the direction passed in through the AddTransceiver init parameter
885// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700886TEST_F(PeerConnectionRtpTestUnifiedPlan,
887 AddTransceiverWithDirectionIsReflected) {
888 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800889
890 RtpTransceiverInit init;
891 init.direction = RtpTransceiverDirection::kSendOnly;
892 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
893 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
894}
895
Steve Anton9158ef62017-11-27 13:01:52 -0800896// Test that calling AddTransceiver with a track creates a transceiver which has
897// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700898TEST_F(PeerConnectionRtpTestUnifiedPlan,
899 AddTransceiverWithTrackCreatesSenderWithTrack) {
900 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800901
902 auto audio_track = caller->CreateAudioTrack("audio track");
903 auto transceiver = caller->AddTransceiver(audio_track);
904
905 auto sender = transceiver->sender();
906 ASSERT_TRUE(sender->track());
907 EXPECT_EQ(audio_track, sender->track());
908
909 auto receiver = transceiver->receiver();
910 ASSERT_TRUE(receiver->track());
911 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
912 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
913 receiver->track()->state());
914}
915
916// Test that calling AddTransceiver twice with the same track creates distinct
917// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700918TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800919 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700920 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800921
922 auto audio_track = caller->CreateAudioTrack("audio track");
923
924 auto transceiver1 = caller->AddTransceiver(audio_track);
925 auto transceiver2 = caller->AddTransceiver(audio_track);
926
927 EXPECT_NE(transceiver1, transceiver2);
928
929 auto sender1 = transceiver1->sender();
930 auto sender2 = transceiver2->sender();
931 EXPECT_NE(sender1, sender2);
932 EXPECT_EQ(audio_track, sender1->track());
933 EXPECT_EQ(audio_track, sender2->track());
934
935 EXPECT_THAT(caller->pc()->GetTransceivers(),
936 UnorderedElementsAre(transceiver1, transceiver2));
937 EXPECT_THAT(caller->pc()->GetSenders(),
938 UnorderedElementsAre(sender1, sender2));
939}
940
Steve Anton3fe1b152017-12-12 10:20:08 -0800941// RtpTransceiver error handling tests.
942
Steve Anton3172c032018-05-03 15:30:18 -0700943TEST_F(PeerConnectionRtpTestUnifiedPlan,
944 AddTransceiverWithInvalidKindReturnsError) {
945 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800946
947 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
948 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
949}
950
Steve Anton3172c032018-05-03 15:30:18 -0700951TEST_F(PeerConnectionRtpTestUnifiedPlan,
952 CanClosePeerConnectionWithoutCrashing) {
953 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800954
955 caller->pc()->Close();
956}
957
Steve Antonf9381f02017-12-14 10:23:57 -0800958// Unified Plan AddTrack tests.
959
Steve Antonf9381f02017-12-14 10:23:57 -0800960// Test that adding an audio track creates a new audio RtpSender with the given
961// track.
Steve Anton3172c032018-05-03 15:30:18 -0700962TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
963 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800964
965 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800966 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800967 ASSERT_TRUE(sender);
968
969 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
970 EXPECT_EQ(audio_track, sender->track());
971}
972
973// Test that adding a video track creates a new video RtpSender with the given
974// track.
Steve Anton3172c032018-05-03 15:30:18 -0700975TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
976 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800977
978 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800979 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800980 ASSERT_TRUE(sender);
981
982 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
983 EXPECT_EQ(video_track, sender->track());
984}
985
986// Test that adding a track to a new PeerConnection creates an RtpTransceiver
987// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -0700988TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
989 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800990
991 auto sender = caller->AddAudioTrack("a");
992 ASSERT_TRUE(sender);
993
994 auto transceivers = caller->pc()->GetTransceivers();
995 ASSERT_EQ(1u, transceivers.size());
996 EXPECT_EQ(sender, transceivers[0]->sender());
997 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
998}
999
1000// Test that if a transceiver of the same type but no track had been added to
1001// the PeerConnection and later a call to AddTrack is made, the resulting sender
1002// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001003TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1004 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001005
1006 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1007 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001008 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001009 ASSERT_TRUE(sender);
1010
1011 auto transceivers = caller->pc()->GetTransceivers();
1012 ASSERT_EQ(1u, transceivers.size());
1013 EXPECT_EQ(transceiver, transceivers[0]);
1014 EXPECT_EQ(sender, transceiver->sender());
1015 EXPECT_EQ(audio_track, sender->track());
1016}
1017
1018// Test that adding two tracks to a new PeerConnection creates two
1019// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001020TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1021 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001022
1023 auto sender1 = caller->AddAudioTrack("a");
1024 auto sender2 = caller->AddVideoTrack("v");
1025 ASSERT_TRUE(sender2);
1026
1027 auto transceivers = caller->pc()->GetTransceivers();
1028 ASSERT_EQ(2u, transceivers.size());
1029 EXPECT_EQ(sender1, transceivers[0]->sender());
1030 EXPECT_EQ(sender2, transceivers[1]->sender());
1031}
1032
1033// Test that if there are multiple transceivers with no sending track then a
1034// later call to AddTrack will use the one of the same type as the newly-added
1035// track.
Steve Anton3172c032018-05-03 15:30:18 -07001036TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1037 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001038
1039 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1040 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1041 auto sender = caller->AddVideoTrack("v");
1042
1043 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1044 EXPECT_NE(sender, audio_transceiver->sender());
1045 EXPECT_EQ(sender, video_transceiver->sender());
1046}
1047
1048// Test that if the only transceivers that do not have a sending track have a
1049// different type from the added track, then AddTrack will create a new
1050// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001051TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001052 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001053 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001054
1055 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1056 auto sender = caller->AddVideoTrack("v");
1057
1058 auto transceivers = caller->pc()->GetTransceivers();
1059 ASSERT_EQ(2u, transceivers.size());
1060 EXPECT_NE(sender, transceivers[0]->sender());
1061 EXPECT_EQ(sender, transceivers[1]->sender());
1062}
1063
1064// Test that the first available transceiver is reused by AddTrack when multiple
1065// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001066TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001067 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001068 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001069
1070 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1071 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1072 auto sender = caller->AddAudioTrack("a");
1073
1074 auto transceivers = caller->pc()->GetTransceivers();
1075 ASSERT_EQ(2u, transceivers.size());
1076 EXPECT_EQ(sender, transceivers[0]->sender());
1077 EXPECT_NE(sender, transceivers[1]->sender());
1078}
1079
1080// Test that a call to AddTrack that reuses a transceiver will change the
1081// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001082TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001083 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001084 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001085
1086 RtpTransceiverInit init;
1087 init.direction = RtpTransceiverDirection::kInactive;
1088 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1089
1090 caller->observer()->clear_negotiation_needed();
1091 ASSERT_TRUE(caller->AddAudioTrack("a"));
1092 EXPECT_TRUE(caller->observer()->negotiation_needed());
1093
1094 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1095}
1096
1097// Test that a call to AddTrack that reuses a transceiver will change the
1098// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001099TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001100 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001101 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001102
1103 RtpTransceiverInit init;
1104 init.direction = RtpTransceiverDirection::kRecvOnly;
1105 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1106
1107 caller->observer()->clear_negotiation_needed();
1108 ASSERT_TRUE(caller->AddAudioTrack("a"));
1109 EXPECT_TRUE(caller->observer()->negotiation_needed());
1110
1111 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1112}
1113
Steve Anton3172c032018-05-03 15:30:18 -07001114TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001115 const std::string kTrackId = "audio_track";
1116
Steve Anton3172c032018-05-03 15:30:18 -07001117 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001118
1119 auto audio_track = caller->CreateAudioTrack(kTrackId);
1120 auto sender = caller->AddTrack(audio_track);
1121
1122 EXPECT_EQ(kTrackId, sender->id());
1123}
1124
Steve Antonf9381f02017-12-14 10:23:57 -08001125// Unified Plan AddTrack error handling.
1126
Steve Anton3172c032018-05-03 15:30:18 -07001127TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1128 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001129
1130 auto audio_track = caller->CreateAudioTrack("a");
1131 caller->pc()->Close();
1132
1133 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001134 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001135 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001136 EXPECT_FALSE(caller->observer()->negotiation_needed());
1137}
1138
Steve Anton3172c032018-05-03 15:30:18 -07001139TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1140 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001141
1142 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001143 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001144
1145 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001146 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001147 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001148 EXPECT_FALSE(caller->observer()->negotiation_needed());
1149}
1150
1151// Unified Plan RemoveTrack tests.
1152
1153// Test that calling RemoveTrack on a sender with a previously-added track
1154// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001155TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1156 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001157
1158 auto sender = caller->AddAudioTrack("a");
1159 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1160
1161 EXPECT_FALSE(sender->track());
1162}
1163
1164// Test that calling RemoveTrack on a sender where the transceiver is configured
1165// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001166TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001167 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001168 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001169
1170 RtpTransceiverInit init;
1171 init.direction = RtpTransceiverDirection::kSendRecv;
1172 auto transceiver =
1173 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1174
1175 caller->observer()->clear_negotiation_needed();
1176 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1177 EXPECT_TRUE(caller->observer()->negotiation_needed());
1178
1179 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1180 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1181}
1182
1183// Test that calling RemoveTrack on a sender where the transceiver is configured
1184// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001185TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001186 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001187 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001188
1189 RtpTransceiverInit init;
1190 init.direction = RtpTransceiverDirection::kSendOnly;
1191 auto transceiver =
1192 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1193
1194 caller->observer()->clear_negotiation_needed();
1195 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1196 EXPECT_TRUE(caller->observer()->negotiation_needed());
1197
1198 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1199}
1200
1201// Test that calling RemoveTrack with a sender that has a null track results in
1202// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001203TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1204 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001205
1206 auto sender = caller->AddAudioTrack("a");
1207 auto transceiver = caller->pc()->GetTransceivers()[0];
1208 ASSERT_TRUE(sender->SetTrack(nullptr));
1209
1210 caller->observer()->clear_negotiation_needed();
1211 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1212 EXPECT_FALSE(caller->observer()->negotiation_needed());
1213
1214 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1215}
1216
1217// Unified Plan RemoveTrack error handling.
1218
Steve Anton3172c032018-05-03 15:30:18 -07001219TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1220 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001221
1222 auto sender = caller->AddAudioTrack("a");
1223 caller->pc()->Close();
1224
1225 caller->observer()->clear_negotiation_needed();
1226 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1227 EXPECT_FALSE(caller->observer()->negotiation_needed());
1228}
1229
Steve Anton3172c032018-05-03 15:30:18 -07001230TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001231 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001232 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001233
1234 auto sender = caller->AddAudioTrack("a");
1235 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1236
1237 caller->observer()->clear_negotiation_needed();
1238 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1239 EXPECT_FALSE(caller->observer()->negotiation_needed());
1240}
1241
Steve Anton60b6c1d2018-06-13 11:32:27 -07001242// Test that setting offers that add/remove/add a track repeatedly without
1243// setting the appropriate answer in between works.
1244// These are regression tests for bugs.webrtc.org/9401
1245TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1246 auto caller = CreatePeerConnection();
1247
1248 auto sender1 = caller->AddAudioTrack("audio1");
1249 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1250
1251 caller->pc()->RemoveTrack(sender1);
1252 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1253
1254 // This will re-use the transceiver created by the first AddTrack.
1255 auto sender2 = caller->AddAudioTrack("audio2");
1256 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1257
1258 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1259 EXPECT_EQ(sender1, sender2);
1260}
1261TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1262 auto caller = CreatePeerConnection();
1263
1264 auto sender1 = caller->AddVideoTrack("video1");
1265 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1266
1267 caller->pc()->RemoveTrack(sender1);
1268 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1269
1270 // This will re-use the transceiver created by the first AddTrack.
1271 auto sender2 = caller->AddVideoTrack("video2");
1272 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1273
1274 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1275 EXPECT_EQ(sender1, sender2);
1276}
1277
Steve Anton07563732018-06-26 11:13:50 -07001278// Test that CreateOffer succeeds if two tracks with the same label are added.
1279TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1280 auto caller = CreatePeerConnection();
1281
1282 auto audio_sender = caller->AddAudioTrack("track", {});
1283 auto video_sender = caller->AddVideoTrack("track", {});
1284
1285 EXPECT_TRUE(caller->CreateOffer());
1286
1287 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1288 EXPECT_NE(audio_sender->id(), video_sender->id());
1289}
1290
1291// Test that CreateAnswer succeeds if two tracks with the same label are added.
1292TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1293 auto caller = CreatePeerConnection();
1294 auto callee = CreatePeerConnection();
1295
1296 RtpTransceiverInit recvonly;
1297 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1298 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1299 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1300
1301 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1302
1303 auto audio_sender = callee->AddAudioTrack("track", {});
1304 auto video_sender = callee->AddVideoTrack("track", {});
1305
1306 EXPECT_TRUE(callee->CreateAnswer());
1307
1308 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1309 EXPECT_NE(audio_sender->id(), video_sender->id());
1310}
1311
1312// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1313// m= section with a random sender id (different from the first, now rejected,
1314// m= section).
1315TEST_F(PeerConnectionRtpTestUnifiedPlan,
1316 AddRemoveAddTrackGeneratesNewSenderId) {
1317 auto caller = CreatePeerConnection();
1318 auto callee = CreatePeerConnection();
1319
1320 auto track = caller->CreateVideoTrack("video");
1321 auto sender1 = caller->AddTrack(track);
1322 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1323
1324 caller->pc()->RemoveTrack(sender1);
1325 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1326
1327 auto sender2 = caller->AddTrack(track);
1328
1329 EXPECT_NE(sender1, sender2);
1330 EXPECT_NE(sender1->id(), sender2->id());
1331 std::string sender2_id = sender2->id();
1332
1333 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1334
1335 // The sender's ID should not change after negotiation.
1336 EXPECT_EQ(sender2_id, sender2->id());
1337}
1338
Steve Anton52d86772018-02-20 15:48:12 -08001339// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1340// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001341TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001342 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001343 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001344
1345 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1346
1347 caller->observer()->clear_negotiation_needed();
1348 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1349 EXPECT_TRUE(caller->observer()->negotiation_needed());
1350}
1351
1352// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1353// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001354TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001355 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001356 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001357
1358 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1359
1360 caller->observer()->clear_negotiation_needed();
1361 transceiver->SetDirection(transceiver->direction());
1362 EXPECT_FALSE(caller->observer()->negotiation_needed());
1363}
1364
1365// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1366// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001367TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001368 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001369 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001370
1371 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1372 transceiver->Stop();
1373
1374 caller->observer()->clear_negotiation_needed();
1375 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1376 EXPECT_FALSE(caller->observer()->negotiation_needed());
1377}
1378
Steve Antone831b8c2018-02-01 12:22:16 -08001379// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1380// options for this kind of signaling: media section based (a=msid) and ssrc
1381// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1382// we want to ensure compatibility with older Plan B endpoints that might expect
1383// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1384// types but answers with the same type as the offer.
1385
Steve Anton3172c032018-05-03 15:30:18 -07001386class PeerConnectionMsidSignalingTest
1387 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001388
1389TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1390 auto caller = CreatePeerConnectionWithUnifiedPlan();
1391 caller->AddAudioTrack("caller_audio");
1392 auto callee = CreatePeerConnectionWithUnifiedPlan();
1393 callee->AddAudioTrack("callee_audio");
1394
1395 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1396
1397 // Offer should have had both a=msid and a=ssrc MSID lines.
1398 auto* offer = callee->pc()->remote_description();
1399 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1400 cricket::kMsidSignalingSsrcAttribute),
1401 offer->description()->msid_signaling());
1402
1403 // Answer should have had only a=msid lines.
1404 auto* answer = caller->pc()->remote_description();
1405 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1406 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001407 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001408 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1409 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1410 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1411 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1412 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001413}
1414
1415TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1416 auto caller = CreatePeerConnectionWithPlanB();
1417 caller->AddAudioTrack("caller_audio");
1418 auto callee = CreatePeerConnectionWithUnifiedPlan();
1419 callee->AddAudioTrack("callee_audio");
1420
1421 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1422
1423 // Offer should have only a=ssrc MSID lines.
1424 auto* offer = callee->pc()->remote_description();
1425 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1426 offer->description()->msid_signaling());
1427
1428 // Answer should have only a=ssrc MSID lines to match the offer.
1429 auto* answer = caller->pc()->remote_description();
1430 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1431 answer->description()->msid_signaling());
1432}
1433
Seth Hampson5b4f0752018-04-02 16:31:36 -07001434// This tests that a Plan B endpoint appropriately sets the remote description
1435// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1436// that signal no stream ids or multiple stream ids we expect that the Plan B
1437// endpoint always has exactly one media stream per track.
1438TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1439 const std::string kStreamId1 = "audio_stream_1";
1440 const std::string kStreamId2 = "audio_stream_2";
1441
1442 auto caller = CreatePeerConnectionWithUnifiedPlan();
1443 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1444 caller->AddVideoTrack("caller_video", {});
1445 auto callee = CreatePeerConnectionWithPlanB();
1446 callee->AddAudioTrack("callee_audio");
1447 caller->AddVideoTrack("callee_video");
1448
1449 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1450
1451 // Offer should have had both a=msid and a=ssrc MSID lines.
1452 auto* offer = callee->pc()->remote_description();
1453 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1454 cricket::kMsidSignalingSsrcAttribute),
1455 offer->description()->msid_signaling());
1456
1457 // Callee should always have 1 stream for all of it's receivers.
1458 const auto& track_events = callee->observer()->add_track_events_;
1459 ASSERT_EQ(2u, track_events.size());
1460 ASSERT_EQ(1u, track_events[0].streams.size());
1461 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1462 ASSERT_EQ(1u, track_events[1].streams.size());
1463 // This autogenerated a stream id for the empty one signalled.
1464 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1465}
1466
Steve Antone831b8c2018-02-01 12:22:16 -08001467TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1468 auto caller = CreatePeerConnectionWithUnifiedPlan();
1469 caller->AddAudioTrack("caller_audio");
1470 auto callee = CreatePeerConnectionWithUnifiedPlan();
1471 callee->AddAudioTrack("callee_audio");
1472
1473 auto offer = caller->CreateOffer();
1474 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1475 // section only.
1476 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1477
1478 ASSERT_TRUE(
1479 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1480 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1481
1482 // Answer should have only a=msid to match the offer.
1483 auto answer = callee->CreateAnswer();
1484 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1485 answer->description()->msid_signaling());
1486}
1487
Steve Anton8e20f172018-03-06 10:55:04 -08001488// Test that the correct UMA metrics are reported for simple/complex SDP.
1489
Steve Anton3172c032018-05-03 15:30:18 -07001490class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001491
1492#ifdef HAVE_SCTP
1493TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1494 auto caller = CreatePeerConnectionWithUnifiedPlan();
1495 caller->CreateDataChannel("dc");
1496 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001497
1498 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001499 // Note that only the callee does ReportSdpFormatReceived.
1500 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1501 "WebRTC.PeerConnection.SdpFormatReceived"));
1502 EXPECT_EQ(
1503 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1504 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001505}
1506#endif // HAVE_SCTP
1507
1508TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1509 auto caller = CreatePeerConnectionWithUnifiedPlan();
1510 caller->AddAudioTrack("audio");
1511 caller->AddVideoTrack("video");
1512 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001513
1514 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001515 // Note that only the callee does ReportSdpFormatReceived.
1516 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1517 "WebRTC.PeerConnection.SdpFormatReceived"));
1518 EXPECT_EQ(
1519 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1520 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001521}
1522
1523TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1524 auto caller = CreatePeerConnectionWithPlanB();
1525 caller->AddVideoTrack("video"); // Video only.
1526 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001527
1528 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1529
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001530 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1531 "WebRTC.PeerConnection.SdpFormatReceived"));
1532 EXPECT_EQ(
1533 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1534 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001535}
1536
1537TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1538 auto caller = CreatePeerConnectionWithUnifiedPlan();
1539 caller->AddAudioTrack("audio1");
1540 caller->AddAudioTrack("audio2");
1541 caller->AddVideoTrack("video");
1542 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001543
1544 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001545 // Note that only the callee does ReportSdpFormatReceived.
1546 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1547 "WebRTC.PeerConnection.SdpFormatReceived"));
1548 EXPECT_EQ(
1549 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1550 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001551}
1552
1553TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1554 auto caller = CreatePeerConnectionWithPlanB();
1555 caller->AddVideoTrack("video1");
1556 caller->AddVideoTrack("video2");
1557 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001558
Steve Antonba42e992018-04-09 14:10:01 -07001559 // This fails since Unified Plan cannot set a session description with
1560 // multiple "Plan B tracks" in the same media section. But we still expect the
1561 // SDP Format to be recorded.
1562 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001563 // Note that only the callee does ReportSdpFormatReceived.
1564 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1565 "WebRTC.PeerConnection.SdpFormatReceived"));
1566 EXPECT_EQ(
1567 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1568 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001569}
1570
Henrik Boström91d039b2018-01-11 17:43:30 +01001571// Sender setups in a call.
1572
Steve Anton3172c032018-05-03 15:30:18 -07001573TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001574 auto caller = CreatePeerConnection();
1575 auto callee = CreatePeerConnection();
1576
1577 auto track = caller->CreateAudioTrack("audio_track");
1578 auto sender1 = caller->AddTrack(track);
1579 ASSERT_TRUE(sender1);
1580 // We need to temporarily reset the track for the subsequent AddTrack() to
1581 // succeed.
1582 EXPECT_TRUE(sender1->SetTrack(nullptr));
1583 auto sender2 = caller->AddTrack(track);
1584 EXPECT_TRUE(sender2);
1585 EXPECT_TRUE(sender1->SetTrack(track));
1586
Steve Anton3172c032018-05-03 15:30:18 -07001587 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1588 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1589 // return true, and doing |callee->SetRemoteDescription()| should work.
1590 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1591 } else {
1592 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1593 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001594}
1595
Steve Anton3172c032018-05-03 15:30:18 -07001596INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1597 PeerConnectionRtpTest,
1598 Values(SdpSemantics::kPlanB,
1599 SdpSemantics::kUnifiedPlan));
1600
Steve Anton9158ef62017-11-27 13:01:52 -08001601} // namespace webrtc