blob: 1e167282713fc01ee82618944ab675942f8a95aa [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg1b0eae32017-10-17 14:48:54 +020014#include "api/audio_codecs/builtin_audio_decoder_factory.h"
15#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include "api/jsep.h"
17#include "api/mediastreaminterface.h"
18#include "api/peerconnectioninterface.h"
19#include "pc/mediastream.h"
20#include "pc/mediastreamtrack.h"
21#include "pc/peerconnectionwrapper.h"
22#include "pc/test/fakeaudiocapturemodule.h"
23#include "pc/test/mockpeerconnectionobservers.h"
24#include "rtc_base/checks.h"
25#include "rtc_base/gunit.h"
26#include "rtc_base/ptr_util.h"
27#include "rtc_base/refcountedobject.h"
28#include "rtc_base/scoped_ref_ptr.h"
29#include "rtc_base/thread.h"
Steve Anton9158ef62017-11-27 13:01:52 -080030#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070031
32// This file contains tests for RTP Media API-related behavior of
33// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
34
Steve Anton9158ef62017-11-27 13:01:52 -080035namespace webrtc {
36
37using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
38using ::testing::ElementsAre;
39using ::testing::UnorderedElementsAre;
Henrik Boström933d8b02017-10-10 10:05:16 -070040
Henrik Boström31638672017-11-23 17:48:32 +010041const uint32_t kDefaultTimeout = 10000u;
42
43template <typename MethodFunctor>
44class OnSuccessObserver : public rtc::RefCountedObject<
45 webrtc::SetRemoteDescriptionObserverInterface> {
46 public:
47 explicit OnSuccessObserver(MethodFunctor on_success)
48 : on_success_(std::move(on_success)) {}
49
50 // webrtc::SetRemoteDescriptionObserverInterface implementation.
51 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
52 RTC_CHECK(error.ok());
53 on_success_();
54 }
55
56 private:
57 MethodFunctor on_success_;
58};
59
Henrik Boström933d8b02017-10-10 10:05:16 -070060class PeerConnectionRtpTest : public testing::Test {
61 public:
62 PeerConnectionRtpTest()
Steve Anton9158ef62017-11-27 13:01:52 -080063 : pc_factory_(
64 CreatePeerConnectionFactory(rtc::Thread::Current(),
65 rtc::Thread::Current(),
66 rtc::Thread::Current(),
67 FakeAudioCaptureModule::Create(),
68 CreateBuiltinAudioEncoderFactory(),
69 CreateBuiltinAudioDecoderFactory(),
70 nullptr,
71 nullptr)) {}
Henrik Boström933d8b02017-10-10 10:05:16 -070072
Steve Anton9158ef62017-11-27 13:01:52 -080073 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
74 return CreatePeerConnection(RTCConfiguration());
75 }
76
77 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
78 RTCConfiguration config;
79 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
80 return CreatePeerConnection(config);
81 }
82
83 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
84 const RTCConfiguration& config) {
85 auto observer = rtc::MakeUnique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -070086 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
87 observer.get());
Steve Anton9158ef62017-11-27 13:01:52 -080088 return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc,
89 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -070090 }
91
92 protected:
Steve Anton9158ef62017-11-27 13:01:52 -080093 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
Henrik Boström933d8b02017-10-10 10:05:16 -070094};
95
Henrik Boström31638672017-11-23 17:48:32 +010096// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
97// setting the remote description.
98class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {};
99
100TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700101 auto caller = CreatePeerConnection();
102 auto callee = CreatePeerConnection();
103
Steve Anton9158ef62017-11-27 13:01:52 -0800104 rtc::scoped_refptr<AudioTrackInterface> audio_track(
Henrik Boström933d8b02017-10-10 10:05:16 -0700105 pc_factory_->CreateAudioTrack("audio_track", nullptr));
106 EXPECT_TRUE(caller->pc()->AddTrack(audio_track.get(), {}));
Henrik Boström31638672017-11-23 17:48:32 +0100107 ASSERT_TRUE(
108 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
109 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700110
Henrik Boström31638672017-11-23 17:48:32 +0100111 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
112 // TODO(hbos): When "no stream" is handled correctly we would expect
Henrik Boström933d8b02017-10-10 10:05:16 -0700113 // |add_track_events_[0].streams| to be empty. https://crbug.com/webrtc/7933
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100114 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100115 ASSERT_EQ(add_track_event.streams.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100116 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
117 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700118}
119
Henrik Boström31638672017-11-23 17:48:32 +0100120TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700121 auto caller = CreatePeerConnection();
122 auto callee = CreatePeerConnection();
123
Steve Anton9158ef62017-11-27 13:01:52 -0800124 rtc::scoped_refptr<AudioTrackInterface> audio_track(
Henrik Boström933d8b02017-10-10 10:05:16 -0700125 pc_factory_->CreateAudioTrack("audio_track", nullptr));
Steve Anton9158ef62017-11-27 13:01:52 -0800126 auto stream = MediaStream::Create("audio_stream");
Henrik Boström933d8b02017-10-10 10:05:16 -0700127 EXPECT_TRUE(caller->pc()->AddTrack(audio_track.get(), {stream.get()}));
Henrik Boström31638672017-11-23 17:48:32 +0100128 ASSERT_TRUE(
129 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
130 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700131
Henrik Boström31638672017-11-23 17:48:32 +0100132 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100133 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100134 ASSERT_EQ(add_track_event.streams.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100135 EXPECT_EQ("audio_stream", add_track_event.streams[0]->label());
136 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
137 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700138}
139
Henrik Boström31638672017-11-23 17:48:32 +0100140TEST_F(PeerConnectionRtpCallbacksTest,
141 RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700142 auto caller = CreatePeerConnection();
143 auto callee = CreatePeerConnection();
144
Steve Anton9158ef62017-11-27 13:01:52 -0800145 rtc::scoped_refptr<AudioTrackInterface> audio_track(
Henrik Boström933d8b02017-10-10 10:05:16 -0700146 pc_factory_->CreateAudioTrack("audio_track", nullptr));
147 auto sender = caller->pc()->AddTrack(audio_track.get(), {});
Henrik Boström31638672017-11-23 17:48:32 +0100148 ASSERT_TRUE(
149 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
150 static_cast<webrtc::RTCError*>(nullptr)));
151 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700152 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boström31638672017-11-23 17:48:32 +0100153 ASSERT_TRUE(
154 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
155 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700156
Henrik Boström31638672017-11-23 17:48:32 +0100157 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700158 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
159 callee->observer()->remove_track_events_);
160}
161
Henrik Boström31638672017-11-23 17:48:32 +0100162TEST_F(PeerConnectionRtpCallbacksTest,
163 RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700164 auto caller = CreatePeerConnection();
165 auto callee = CreatePeerConnection();
166
Steve Anton9158ef62017-11-27 13:01:52 -0800167 rtc::scoped_refptr<AudioTrackInterface> audio_track(
Henrik Boström933d8b02017-10-10 10:05:16 -0700168 pc_factory_->CreateAudioTrack("audio_track", nullptr));
Steve Anton9158ef62017-11-27 13:01:52 -0800169 auto stream = MediaStream::Create("audio_stream");
Henrik Boström933d8b02017-10-10 10:05:16 -0700170 auto sender = caller->pc()->AddTrack(audio_track.get(), {stream.get()});
Henrik Boström31638672017-11-23 17:48:32 +0100171 ASSERT_TRUE(
172 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
173 static_cast<webrtc::RTCError*>(nullptr)));
174 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700175 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boström31638672017-11-23 17:48:32 +0100176 ASSERT_TRUE(
177 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
178 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700179
Henrik Boström31638672017-11-23 17:48:32 +0100180 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700181 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
182 callee->observer()->remove_track_events_);
183}
184
Henrik Boström31638672017-11-23 17:48:32 +0100185TEST_F(PeerConnectionRtpCallbacksTest,
186 RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700187 auto caller = CreatePeerConnection();
188 auto callee = CreatePeerConnection();
189
Steve Anton9158ef62017-11-27 13:01:52 -0800190 rtc::scoped_refptr<AudioTrackInterface> audio_track1(
Henrik Boström933d8b02017-10-10 10:05:16 -0700191 pc_factory_->CreateAudioTrack("audio_track1", nullptr));
Steve Anton9158ef62017-11-27 13:01:52 -0800192 rtc::scoped_refptr<AudioTrackInterface> audio_track2(
Henrik Boström933d8b02017-10-10 10:05:16 -0700193 pc_factory_->CreateAudioTrack("audio_track2", nullptr));
Steve Anton9158ef62017-11-27 13:01:52 -0800194 auto stream = MediaStream::Create("shared_audio_stream");
195 std::vector<MediaStreamInterface*> streams{stream.get()};
Henrik Boström933d8b02017-10-10 10:05:16 -0700196 auto sender1 = caller->pc()->AddTrack(audio_track1.get(), streams);
197 auto sender2 = caller->pc()->AddTrack(audio_track2.get(), streams);
Henrik Boström31638672017-11-23 17:48:32 +0100198 ASSERT_TRUE(
199 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
200 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700201
Henrik Boström31638672017-11-23 17:48:32 +0100202 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700203
204 // Remove "audio_track1".
205 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Henrik Boström31638672017-11-23 17:48:32 +0100206 ASSERT_TRUE(
207 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
208 static_cast<webrtc::RTCError*>(nullptr)));
209 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700210 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800211 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700212 callee->observer()->add_track_events_[0].receiver},
213 callee->observer()->remove_track_events_);
214
215 // Remove "audio_track2".
216 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Henrik Boström31638672017-11-23 17:48:32 +0100217 ASSERT_TRUE(
218 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
219 static_cast<webrtc::RTCError*>(nullptr)));
220 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700221 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
222 callee->observer()->remove_track_events_);
223}
224
Henrik Boström31638672017-11-23 17:48:32 +0100225// These tests examine the state of the peer connection as a result of
226// performing SetRemoteDescription().
227class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {};
228
229TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) {
230 auto caller = CreatePeerConnection();
231 auto callee = CreatePeerConnection();
232
233 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track(
234 pc_factory_->CreateAudioTrack("audio_track", nullptr));
235 EXPECT_TRUE(caller->pc()->AddTrack(audio_track.get(), {}));
236 ASSERT_TRUE(
237 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
238 static_cast<webrtc::RTCError*>(nullptr)));
239
240 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
241 auto receiver_added = callee->pc()->GetReceivers()[0];
242 EXPECT_EQ("audio_track", receiver_added->track()->id());
243 // TODO(hbos): When "no stream" is handled correctly we would expect
244 // |receiver_added->streams()| to be empty. https://crbug.com/webrtc/7933
245 EXPECT_EQ(receiver_added->streams().size(), 1u);
246 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
247}
248
249TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) {
250 auto caller = CreatePeerConnection();
251 auto callee = CreatePeerConnection();
252
253 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track(
254 pc_factory_->CreateAudioTrack("audio_track", nullptr));
255 auto stream = webrtc::MediaStream::Create("audio_stream");
256 EXPECT_TRUE(caller->pc()->AddTrack(audio_track.get(), {stream}));
257 ASSERT_TRUE(
258 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
259 static_cast<webrtc::RTCError*>(nullptr)));
260
261 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
262 auto receiver_added = callee->pc()->GetReceivers()[0];
263 EXPECT_EQ("audio_track", receiver_added->track()->id());
264 EXPECT_EQ(receiver_added->streams().size(), 1u);
265 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->label());
266 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
267}
268
269TEST_F(PeerConnectionRtpObserverTest,
270 RemoveSenderWithoutStreamRemovesReceiver) {
271 auto caller = CreatePeerConnection();
272 auto callee = CreatePeerConnection();
273
274 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track(
275 pc_factory_->CreateAudioTrack("audio_track", nullptr));
276 auto sender = caller->pc()->AddTrack(audio_track.get(), {});
277 ASSERT_TRUE(sender);
278 ASSERT_TRUE(
279 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
280 static_cast<webrtc::RTCError*>(nullptr)));
281 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
282 auto receiver = callee->pc()->GetReceivers()[0];
283 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
284 ASSERT_TRUE(
285 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
286 static_cast<webrtc::RTCError*>(nullptr)));
287
288 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
289 // Instead, the transceiver owning the receiver will become inactive.
290 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
291}
292
293TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) {
294 auto caller = CreatePeerConnection();
295 auto callee = CreatePeerConnection();
296
297 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track(
298 pc_factory_->CreateAudioTrack("audio_track", nullptr));
299 auto stream = webrtc::MediaStream::Create("audio_stream");
300 auto sender = caller->pc()->AddTrack(audio_track.get(), {stream});
301 ASSERT_TRUE(sender);
302 ASSERT_TRUE(
303 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
304 static_cast<webrtc::RTCError*>(nullptr)));
305 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
306 auto receiver = callee->pc()->GetReceivers()[0];
307 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
308 ASSERT_TRUE(
309 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
310 static_cast<webrtc::RTCError*>(nullptr)));
311
312 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
313 // Instead, the transceiver owning the receiver will become inactive.
314 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
315}
316
317TEST_F(PeerConnectionRtpObserverTest,
318 RemoveSenderWithSharedStreamRemovesReceiver) {
319 auto caller = CreatePeerConnection();
320 auto callee = CreatePeerConnection();
321
322 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track1(
323 pc_factory_->CreateAudioTrack("audio_track1", nullptr));
324 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track2(
325 pc_factory_->CreateAudioTrack("audio_track2", nullptr));
326 auto stream = webrtc::MediaStream::Create("shared_audio_stream");
327 std::vector<webrtc::MediaStreamInterface*> streams{stream.get()};
328 auto sender1 = caller->pc()->AddTrack(audio_track1.get(), streams);
329 auto sender2 = caller->pc()->AddTrack(audio_track2.get(), streams);
330 ASSERT_TRUE(
331 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
332 static_cast<webrtc::RTCError*>(nullptr)));
333
334 ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u);
335 rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1;
336 rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2;
337 if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") {
338 receiver1 = callee->pc()->GetReceivers()[0];
339 receiver2 = callee->pc()->GetReceivers()[1];
340 } else {
341 receiver1 = callee->pc()->GetReceivers()[1];
342 receiver2 = callee->pc()->GetReceivers()[0];
343 }
344 EXPECT_EQ("audio_track1", receiver1->track()->id());
345 EXPECT_EQ("audio_track2", receiver2->track()->id());
346
347 // Remove "audio_track1".
348 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
349 ASSERT_TRUE(
350 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
351 static_cast<webrtc::RTCError*>(nullptr)));
352 // Only |receiver2| should remain.
353 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
354 // Instead, the transceiver owning the receiver will become inactive.
355 EXPECT_EQ(
356 std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2},
357 callee->pc()->GetReceivers());
358
359 // Remove "audio_track2".
360 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
361 ASSERT_TRUE(
362 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
363 static_cast<webrtc::RTCError*>(nullptr)));
364 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
365 // Instead, the transceiver owning the receiver will become inactive.
366 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
367}
368
369// Invokes SetRemoteDescription() twice in a row without synchronizing the two
370// calls and examine the state of the peer connection inside the callbacks to
371// ensure that the second call does not occur prematurely, contaminating the
372// state of the peer connection of the first callback.
373TEST_F(PeerConnectionRtpObserverTest,
374 StatesCorrelateWithSetRemoteDescriptionCall) {
375 auto caller = CreatePeerConnection();
376 auto callee = CreatePeerConnection();
377
378 rtc::scoped_refptr<webrtc::AudioTrackInterface> audio_track(
379 pc_factory_->CreateAudioTrack("audio_track", nullptr));
380 // Create SDP for adding a track and for removing it. This will be used in the
381 // first and second SetRemoteDescription() calls.
382 auto sender = caller->pc()->AddTrack(audio_track.get(), {});
383 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
384 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
385 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
386
387 // In the first SetRemoteDescription() callback, check that we have a
388 // receiver for the track.
389 auto pc = callee->pc();
390 bool srd1_callback_called = false;
391 auto srd1_callback = [&srd1_callback_called, &pc]() {
392 EXPECT_EQ(pc->GetReceivers().size(), 1u);
393 srd1_callback_called = true;
394 };
395
396 // In the second SetRemoteDescription() callback, check that the receiver has
397 // been removed.
398 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
399 // Instead, the transceiver owning the receiver will become inactive.
400 // https://crbug.com/webrtc/7600
401 bool srd2_callback_called = false;
402 auto srd2_callback = [&srd2_callback_called, &pc]() {
403 EXPECT_TRUE(pc->GetReceivers().empty());
404 srd2_callback_called = true;
405 };
406
407 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
408 // calls. The callbacks verify that the two calls are synchronized, as in, the
409 // effects of the second SetRemoteDescription() call must not have happened by
410 // the time the first callback is invoked. If it has then the receiver that is
411 // added as a result of the first SetRemoteDescription() call will already
412 // have been removed as a result of the second SetRemoteDescription() call
413 // when the first callback is invoked.
414 callee->pc()->SetRemoteDescription(
415 std::move(srd1_sdp),
416 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
417 callee->pc()->SetRemoteDescription(
418 std::move(srd2_sdp),
419 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
420 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
421 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
422}
423
424// Tests for the legacy SetRemoteDescription() function signature.
425class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {};
426
427// Sanity test making sure the callback is invoked.
428TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) {
429 auto caller = CreatePeerConnection();
430 auto callee = CreatePeerConnection();
431
432 std::string error;
433 ASSERT_TRUE(
434 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
435}
436
437// Verifies legacy behavior: The observer is not called if if the peer
438// connection is destroyed because the asynchronous callback is executed in the
439// peer connection's message handler.
440TEST_F(PeerConnectionRtpLegacyObserverTest,
441 ObserverNotCalledIfPeerConnectionDereferenced) {
442 auto caller = CreatePeerConnection();
443 auto callee = CreatePeerConnection();
444
445 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
446 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
447
448 auto offer = caller->CreateOfferAndSetAsLocal();
449 callee->pc()->SetRemoteDescription(observer, offer.release());
450 callee = nullptr;
451 rtc::Thread::Current()->ProcessMessages(0);
452 EXPECT_FALSE(observer->called());
453}
454
Steve Antonf9381f02017-12-14 10:23:57 -0800455// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800456
457// Test that by default there are no transceivers with Unified Plan.
458TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) {
459 auto caller = CreatePeerConnectionWithUnifiedPlan();
460 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
461}
462
463// Test that a transceiver created with the audio kind has the correct initial
464// properties.
465TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) {
466 auto caller = CreatePeerConnectionWithUnifiedPlan();
467
468 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
469 EXPECT_EQ(rtc::nullopt, transceiver->mid());
470 EXPECT_FALSE(transceiver->stopped());
471 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
472 EXPECT_EQ(rtc::nullopt, transceiver->current_direction());
473}
474
475// Test that adding a transceiver with the audio kind creates an audio sender
476// and audio receiver with the receiver having a live audio track.
477TEST_F(PeerConnectionRtpTest,
478 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
479 auto caller = CreatePeerConnectionWithUnifiedPlan();
480
481 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
482
483 ASSERT_TRUE(transceiver->sender());
484 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
485
486 ASSERT_TRUE(transceiver->receiver());
487 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
488
489 auto track = transceiver->receiver()->track();
490 ASSERT_TRUE(track);
491 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
492 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
493}
494
495// Test that adding a transceiver with the video kind creates an video sender
496// and video receiver with the receiver having a live video track.
497TEST_F(PeerConnectionRtpTest,
498 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
499 auto caller = CreatePeerConnectionWithUnifiedPlan();
500
501 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
502
503 ASSERT_TRUE(transceiver->sender());
504 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
505
506 ASSERT_TRUE(transceiver->receiver());
507 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
508
509 auto track = transceiver->receiver()->track();
510 ASSERT_TRUE(track);
511 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
512 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
513}
514
515// Test that after a call to AddTransceiver, the transceiver shows in
516// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
517// transceiver's receiver shows in GetReceivers().
518TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) {
519 auto caller = CreatePeerConnectionWithUnifiedPlan();
520
521 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
522 EXPECT_EQ(
523 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
524 caller->pc()->GetTransceivers());
525 EXPECT_EQ(
526 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
527 transceiver->sender()},
528 caller->pc()->GetSenders());
529 EXPECT_EQ(
530 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
531 transceiver->receiver()},
532 caller->pc()->GetReceivers());
533}
534
535// Test that the direction passed in through the AddTransceiver init parameter
536// is set in the returned transceiver.
537TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) {
538 auto caller = CreatePeerConnectionWithUnifiedPlan();
539
540 RtpTransceiverInit init;
541 init.direction = RtpTransceiverDirection::kSendOnly;
542 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
543 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
544}
545
Steve Anton9158ef62017-11-27 13:01:52 -0800546// Test that calling AddTransceiver with a track creates a transceiver which has
547// its sender's track set to the passed-in track.
548TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) {
549 auto caller = CreatePeerConnectionWithUnifiedPlan();
550
551 auto audio_track = caller->CreateAudioTrack("audio track");
552 auto transceiver = caller->AddTransceiver(audio_track);
553
554 auto sender = transceiver->sender();
555 ASSERT_TRUE(sender->track());
556 EXPECT_EQ(audio_track, sender->track());
557
558 auto receiver = transceiver->receiver();
559 ASSERT_TRUE(receiver->track());
560 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
561 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
562 receiver->track()->state());
563}
564
565// Test that calling AddTransceiver twice with the same track creates distinct
566// transceivers, senders with the same track.
567TEST_F(PeerConnectionRtpTest,
568 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
569 auto caller = CreatePeerConnectionWithUnifiedPlan();
570
571 auto audio_track = caller->CreateAudioTrack("audio track");
572
573 auto transceiver1 = caller->AddTransceiver(audio_track);
574 auto transceiver2 = caller->AddTransceiver(audio_track);
575
576 EXPECT_NE(transceiver1, transceiver2);
577
578 auto sender1 = transceiver1->sender();
579 auto sender2 = transceiver2->sender();
580 EXPECT_NE(sender1, sender2);
581 EXPECT_EQ(audio_track, sender1->track());
582 EXPECT_EQ(audio_track, sender2->track());
583
584 EXPECT_THAT(caller->pc()->GetTransceivers(),
585 UnorderedElementsAre(transceiver1, transceiver2));
586 EXPECT_THAT(caller->pc()->GetSenders(),
587 UnorderedElementsAre(sender1, sender2));
588}
589
Steve Anton3fe1b152017-12-12 10:20:08 -0800590// RtpTransceiver error handling tests.
591
592TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) {
593 auto caller = CreatePeerConnectionWithUnifiedPlan();
594
595 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
596 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
597}
598
599TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) {
600 auto caller = CreatePeerConnectionWithUnifiedPlan();
601
602 caller->pc()->Close();
603}
604
Steve Antonf9381f02017-12-14 10:23:57 -0800605// Unified Plan AddTrack tests.
606
607class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {};
608
609// Test that adding an audio track creates a new audio RtpSender with the given
610// track.
611TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) {
612 auto caller = CreatePeerConnectionWithUnifiedPlan();
613
614 auto audio_track = caller->CreateAudioTrack("a");
615 auto sender = caller->pc()->AddTrack(audio_track, {});
616 ASSERT_TRUE(sender);
617
618 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
619 EXPECT_EQ(audio_track, sender->track());
620}
621
622// Test that adding a video track creates a new video RtpSender with the given
623// track.
624TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) {
625 auto caller = CreatePeerConnectionWithUnifiedPlan();
626
627 auto video_track = caller->CreateVideoTrack("a");
628 auto sender = caller->pc()->AddTrack(video_track, {});
629 ASSERT_TRUE(sender);
630
631 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
632 EXPECT_EQ(video_track, sender->track());
633}
634
635// Test that adding a track to a new PeerConnection creates an RtpTransceiver
636// with the sender that AddTrack returns and in the sendrecv direction.
637TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) {
638 auto caller = CreatePeerConnectionWithUnifiedPlan();
639
640 auto sender = caller->AddAudioTrack("a");
641 ASSERT_TRUE(sender);
642
643 auto transceivers = caller->pc()->GetTransceivers();
644 ASSERT_EQ(1u, transceivers.size());
645 EXPECT_EQ(sender, transceivers[0]->sender());
646 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
647}
648
649// Test that if a transceiver of the same type but no track had been added to
650// the PeerConnection and later a call to AddTrack is made, the resulting sender
651// is the transceiver's sender and the sender's track is the newly-added track.
652TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) {
653 auto caller = CreatePeerConnectionWithUnifiedPlan();
654
655 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
656 auto audio_track = caller->CreateAudioTrack("a");
657 auto sender = caller->pc()->AddTrack(audio_track, {});
658 ASSERT_TRUE(sender);
659
660 auto transceivers = caller->pc()->GetTransceivers();
661 ASSERT_EQ(1u, transceivers.size());
662 EXPECT_EQ(transceiver, transceivers[0]);
663 EXPECT_EQ(sender, transceiver->sender());
664 EXPECT_EQ(audio_track, sender->track());
665}
666
667// Test that adding two tracks to a new PeerConnection creates two
668// RtpTransceivers in the same order.
669TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) {
670 auto caller = CreatePeerConnectionWithUnifiedPlan();
671
672 auto sender1 = caller->AddAudioTrack("a");
673 auto sender2 = caller->AddVideoTrack("v");
674 ASSERT_TRUE(sender2);
675
676 auto transceivers = caller->pc()->GetTransceivers();
677 ASSERT_EQ(2u, transceivers.size());
678 EXPECT_EQ(sender1, transceivers[0]->sender());
679 EXPECT_EQ(sender2, transceivers[1]->sender());
680}
681
682// Test that if there are multiple transceivers with no sending track then a
683// later call to AddTrack will use the one of the same type as the newly-added
684// track.
685TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) {
686 auto caller = CreatePeerConnectionWithUnifiedPlan();
687
688 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
689 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
690 auto sender = caller->AddVideoTrack("v");
691
692 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
693 EXPECT_NE(sender, audio_transceiver->sender());
694 EXPECT_EQ(sender, video_transceiver->sender());
695}
696
697// Test that if the only transceivers that do not have a sending track have a
698// different type from the added track, then AddTrack will create a new
699// transceiver for the track.
700TEST_F(PeerConnectionRtpUnifiedPlanTest,
701 AddTrackDoesNotReuseTransceiverOfWrongType) {
702 auto caller = CreatePeerConnectionWithUnifiedPlan();
703
704 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
705 auto sender = caller->AddVideoTrack("v");
706
707 auto transceivers = caller->pc()->GetTransceivers();
708 ASSERT_EQ(2u, transceivers.size());
709 EXPECT_NE(sender, transceivers[0]->sender());
710 EXPECT_EQ(sender, transceivers[1]->sender());
711}
712
713// Test that the first available transceiver is reused by AddTrack when multiple
714// are available.
715TEST_F(PeerConnectionRtpUnifiedPlanTest,
716 AddTrackReusesFirstMatchingTransceiver) {
717 auto caller = CreatePeerConnectionWithUnifiedPlan();
718
719 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
720 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
721 auto sender = caller->AddAudioTrack("a");
722
723 auto transceivers = caller->pc()->GetTransceivers();
724 ASSERT_EQ(2u, transceivers.size());
725 EXPECT_EQ(sender, transceivers[0]->sender());
726 EXPECT_NE(sender, transceivers[1]->sender());
727}
728
729// Test that a call to AddTrack that reuses a transceiver will change the
730// direction from inactive to sendonly.
731TEST_F(PeerConnectionRtpUnifiedPlanTest,
732 AddTrackChangesDirectionFromInactiveToSendOnly) {
733 auto caller = CreatePeerConnectionWithUnifiedPlan();
734
735 RtpTransceiverInit init;
736 init.direction = RtpTransceiverDirection::kInactive;
737 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
738
739 caller->observer()->clear_negotiation_needed();
740 ASSERT_TRUE(caller->AddAudioTrack("a"));
741 EXPECT_TRUE(caller->observer()->negotiation_needed());
742
743 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
744}
745
746// Test that a call to AddTrack that reuses a transceiver will change the
747// direction from recvonly to sendrecv.
748TEST_F(PeerConnectionRtpUnifiedPlanTest,
749 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
750 auto caller = CreatePeerConnectionWithUnifiedPlan();
751
752 RtpTransceiverInit init;
753 init.direction = RtpTransceiverDirection::kRecvOnly;
754 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
755
756 caller->observer()->clear_negotiation_needed();
757 ASSERT_TRUE(caller->AddAudioTrack("a"));
758 EXPECT_TRUE(caller->observer()->negotiation_needed());
759
760 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
761}
762
763// Unified Plan AddTrack error handling.
764
765TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) {
766 auto caller = CreatePeerConnectionWithUnifiedPlan();
767
768 auto audio_track = caller->CreateAudioTrack("a");
769 caller->pc()->Close();
770
771 caller->observer()->clear_negotiation_needed();
772 EXPECT_FALSE(caller->pc()->AddTrack(audio_track, {}));
773 EXPECT_FALSE(caller->observer()->negotiation_needed());
774}
775
776TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) {
777 auto caller = CreatePeerConnectionWithUnifiedPlan();
778
779 auto audio_track = caller->CreateAudioTrack("a");
780 ASSERT_TRUE(caller->pc()->AddTrack(audio_track, {}));
781
782 caller->observer()->clear_negotiation_needed();
783 EXPECT_FALSE(caller->pc()->AddTrack(audio_track, {}));
784 EXPECT_FALSE(caller->observer()->negotiation_needed());
785}
786
787// Unified Plan RemoveTrack tests.
788
789// Test that calling RemoveTrack on a sender with a previously-added track
790// clears the sender's track.
791TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) {
792 auto caller = CreatePeerConnectionWithUnifiedPlan();
793
794 auto sender = caller->AddAudioTrack("a");
795 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
796
797 EXPECT_FALSE(sender->track());
798}
799
800// Test that calling RemoveTrack on a sender where the transceiver is configured
801// in the sendrecv direction changes the transceiver's direction to recvonly.
802TEST_F(PeerConnectionRtpUnifiedPlanTest,
803 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
804 auto caller = CreatePeerConnectionWithUnifiedPlan();
805
806 RtpTransceiverInit init;
807 init.direction = RtpTransceiverDirection::kSendRecv;
808 auto transceiver =
809 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
810
811 caller->observer()->clear_negotiation_needed();
812 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
813 EXPECT_TRUE(caller->observer()->negotiation_needed());
814
815 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
816 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
817}
818
819// Test that calling RemoveTrack on a sender where the transceiver is configured
820// in the sendonly direction changes the transceiver's direction to inactive.
821TEST_F(PeerConnectionRtpUnifiedPlanTest,
822 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
823 auto caller = CreatePeerConnectionWithUnifiedPlan();
824
825 RtpTransceiverInit init;
826 init.direction = RtpTransceiverDirection::kSendOnly;
827 auto transceiver =
828 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
829
830 caller->observer()->clear_negotiation_needed();
831 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
832 EXPECT_TRUE(caller->observer()->negotiation_needed());
833
834 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
835}
836
837// Test that calling RemoveTrack with a sender that has a null track results in
838// no change in state.
839TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) {
840 auto caller = CreatePeerConnectionWithUnifiedPlan();
841
842 auto sender = caller->AddAudioTrack("a");
843 auto transceiver = caller->pc()->GetTransceivers()[0];
844 ASSERT_TRUE(sender->SetTrack(nullptr));
845
846 caller->observer()->clear_negotiation_needed();
847 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
848 EXPECT_FALSE(caller->observer()->negotiation_needed());
849
850 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
851}
852
853// Unified Plan RemoveTrack error handling.
854
855TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) {
856 auto caller = CreatePeerConnectionWithUnifiedPlan();
857
858 auto sender = caller->AddAudioTrack("a");
859 caller->pc()->Close();
860
861 caller->observer()->clear_negotiation_needed();
862 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
863 EXPECT_FALSE(caller->observer()->negotiation_needed());
864}
865
866TEST_F(PeerConnectionRtpUnifiedPlanTest,
867 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
868 auto caller = CreatePeerConnectionWithUnifiedPlan();
869
870 auto sender = caller->AddAudioTrack("a");
871 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
872
873 caller->observer()->clear_negotiation_needed();
874 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
875 EXPECT_FALSE(caller->observer()->negotiation_needed());
876}
877
Steve Anton9158ef62017-11-27 13:01:52 -0800878} // namespace webrtc