andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 1 | # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 2 | # |
| 3 | # Use of this source code is governed by a BSD-style license |
| 4 | # that can be found in the LICENSE file in the root of the source |
| 5 | # tree. An additional intellectual property rights grant can be found |
| 6 | # in the file PATENTS. All contributing project authors may |
| 7 | # be found in the AUTHORS file in the root of the source tree. |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 8 | |
kjellander@webrtc.org | aefe61a | 2014-12-08 13:00:30 +0000 | [diff] [blame] | 9 | import os |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 10 | import re |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 11 | import sys |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 12 | |
| 13 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 14 | def _CheckNoIOStreamInHeaders(input_api, output_api): |
| 15 | """Checks to make sure no .h files include <iostream>.""" |
| 16 | files = [] |
| 17 | pattern = input_api.re.compile(r'^#include\s*<iostream>', |
| 18 | input_api.re.MULTILINE) |
| 19 | for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): |
| 20 | if not f.LocalPath().endswith('.h'): |
| 21 | continue |
| 22 | contents = input_api.ReadFile(f) |
| 23 | if pattern.search(contents): |
| 24 | files.append(f) |
| 25 | |
| 26 | if len(files): |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 27 | return [output_api.PresubmitError( |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 28 | 'Do not #include <iostream> in header files, since it inserts static ' + |
| 29 | 'initialization into every file including the header. Instead, ' + |
| 30 | '#include <ostream>. See http://crbug.com/94794', |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 31 | files)] |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 32 | return [] |
| 33 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 34 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 35 | def _CheckNoFRIEND_TEST(input_api, output_api): |
| 36 | """Make sure that gtest's FRIEND_TEST() macro is not used, the |
| 37 | FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be |
| 38 | used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes.""" |
| 39 | problems = [] |
| 40 | |
| 41 | file_filter = lambda f: f.LocalPath().endswith(('.cc', '.h')) |
| 42 | for f in input_api.AffectedFiles(file_filter=file_filter): |
| 43 | for line_num, line in f.ChangedContents(): |
| 44 | if 'FRIEND_TEST(' in line: |
| 45 | problems.append(' %s:%d' % (f.LocalPath(), line_num)) |
| 46 | |
| 47 | if not problems: |
| 48 | return [] |
| 49 | return [output_api.PresubmitPromptWarning('WebRTC\'s code should not use ' |
| 50 | 'gtest\'s FRIEND_TEST() macro. Include testsupport/gtest_prod_util.h and ' |
| 51 | 'use FRIEND_TEST_ALL_PREFIXES() instead.\n' + '\n'.join(problems))] |
| 52 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 53 | |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 54 | def _CheckApprovedFilesLintClean(input_api, output_api, |
| 55 | source_file_filter=None): |
| 56 | """Checks that all new or whitelisted .cc and .h files pass cpplint.py. |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 57 | This check is based on _CheckChangeLintsClean in |
| 58 | depot_tools/presubmit_canned_checks.py but has less filters and only checks |
| 59 | added files.""" |
| 60 | result = [] |
| 61 | |
| 62 | # Initialize cpplint. |
| 63 | import cpplint |
| 64 | # Access to a protected member _XX of a client class |
| 65 | # pylint: disable=W0212 |
| 66 | cpplint._cpplint_state.ResetErrorCounts() |
| 67 | |
| 68 | # Justifications for each filter: |
| 69 | # |
| 70 | # - build/header_guard : WebRTC coding style says they should be prefixed |
| 71 | # with WEBRTC_, which is not possible to configure in |
| 72 | # cpplint.py. |
| 73 | cpplint._SetFilters('-build/header_guard') |
| 74 | |
| 75 | # Use the strictest verbosity level for cpplint.py (level 1) which is the |
| 76 | # default when running cpplint.py from command line. |
| 77 | # To make it possible to work with not-yet-converted code, we're only applying |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 78 | # it to new (or moved/renamed) files and files listed in LINT_FOLDERS. |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 79 | verbosity_level = 1 |
| 80 | files = [] |
| 81 | for f in input_api.AffectedSourceFiles(source_file_filter): |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 82 | # Note that moved/renamed files also count as added. |
| 83 | if f.Action() == 'A': |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 84 | files.append(f.AbsoluteLocalPath()) |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 85 | |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 86 | for file_name in files: |
| 87 | cpplint.ProcessFile(file_name, verbosity_level) |
| 88 | |
| 89 | if cpplint._cpplint_state.error_count > 0: |
| 90 | if input_api.is_committing: |
| 91 | # TODO(kjellander): Change back to PresubmitError below when we're |
| 92 | # confident with the lint settings. |
| 93 | res_type = output_api.PresubmitPromptWarning |
| 94 | else: |
| 95 | res_type = output_api.PresubmitPromptWarning |
| 96 | result = [res_type('Changelist failed cpplint.py check.')] |
| 97 | |
| 98 | return result |
| 99 | |
henrike@webrtc.org | 83fe69d | 2014-09-30 21:54:26 +0000 | [diff] [blame] | 100 | def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api): |
| 101 | pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'") |
| 102 | violating_files = [] |
| 103 | for f in gyp_files: |
henrike@webrtc.org | 36b0c1a | 2014-10-01 14:40:58 +0000 | [diff] [blame] | 104 | gyp_exceptions = ( |
| 105 | 'base_tests.gyp', |
| 106 | 'desktop_capture.gypi', |
| 107 | 'libjingle.gyp', |
henrike@webrtc.org | 28af641 | 2014-11-04 15:11:46 +0000 | [diff] [blame] | 108 | 'libjingle_tests.gyp', |
kjellander@webrtc.org | e723728 | 2015-02-26 11:12:17 +0000 | [diff] [blame] | 109 | 'p2p.gyp', |
henrike@webrtc.org | 36b0c1a | 2014-10-01 14:40:58 +0000 | [diff] [blame] | 110 | 'sound.gyp', |
| 111 | 'webrtc_test_common.gyp', |
| 112 | 'webrtc_tests.gypi', |
| 113 | ) |
| 114 | if f.LocalPath().endswith(gyp_exceptions): |
| 115 | continue |
henrike@webrtc.org | 83fe69d | 2014-09-30 21:54:26 +0000 | [diff] [blame] | 116 | contents = input_api.ReadFile(f) |
| 117 | if pattern.search(contents): |
| 118 | violating_files.append(f) |
| 119 | if violating_files: |
| 120 | return [output_api.PresubmitError( |
| 121 | 'Depending on rtc_base is not allowed. Change your dependency to ' |
| 122 | 'rtc_base_approved and possibly sanitize and move the desired source ' |
| 123 | 'file(s) to rtc_base_approved.\nChanged GYP files:', |
| 124 | items=violating_files)] |
| 125 | return [] |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 126 | |
kjellander@webrtc.org | f68ffca | 2015-01-27 13:13:24 +0000 | [diff] [blame] | 127 | def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api): |
| 128 | # Disallow referencing source files with paths above the GYP file location. |
| 129 | source_pattern = input_api.re.compile(r'sources.*?\[(.*?)\]', |
| 130 | re.MULTILINE | re.DOTALL) |
kjellander@webrtc.org | a33f05e | 2015-01-29 14:29:45 +0000 | [diff] [blame] | 131 | file_pattern = input_api.re.compile(r"'((\.\./.*?)|(<\(webrtc_root\).*?))'") |
kjellander@webrtc.org | f68ffca | 2015-01-27 13:13:24 +0000 | [diff] [blame] | 132 | violating_gyp_files = set() |
| 133 | violating_source_entries = [] |
| 134 | for gyp_file in gyp_files: |
| 135 | contents = input_api.ReadFile(gyp_file) |
| 136 | for source_block_match in source_pattern.finditer(contents): |
kjellander@webrtc.org | c98f6f3 | 2015-03-04 07:08:11 +0000 | [diff] [blame] | 137 | # Find all source list entries starting with ../ in the source block |
| 138 | # (exclude overrides entries). |
kjellander@webrtc.org | f68ffca | 2015-01-27 13:13:24 +0000 | [diff] [blame] | 139 | for file_list_match in file_pattern.finditer(source_block_match.group(0)): |
kjellander@webrtc.org | c98f6f3 | 2015-03-04 07:08:11 +0000 | [diff] [blame] | 140 | source_file = file_list_match.group(0) |
| 141 | if 'overrides/' not in source_file: |
| 142 | violating_source_entries.append(source_file) |
| 143 | violating_gyp_files.add(gyp_file) |
kjellander@webrtc.org | f68ffca | 2015-01-27 13:13:24 +0000 | [diff] [blame] | 144 | if violating_gyp_files: |
| 145 | return [output_api.PresubmitError( |
| 146 | 'Referencing source files above the directory of the GYP file is not ' |
| 147 | 'allowed. Please introduce new GYP targets and/or GYP files in the ' |
| 148 | 'proper location instead.\n' |
| 149 | 'Invalid source entries:\n' |
| 150 | '%s\n' |
| 151 | 'Violating GYP files:' % '\n'.join(violating_source_entries), |
| 152 | items=violating_gyp_files)] |
| 153 | return [] |
| 154 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 155 | def _CheckGypChanges(input_api, output_api): |
| 156 | source_file_filter = lambda x: input_api.FilterSourceFile( |
| 157 | x, white_list=(r'.+\.(gyp|gypi)$',)) |
| 158 | |
| 159 | gyp_files = [] |
| 160 | for f in input_api.AffectedSourceFiles(source_file_filter): |
kjellander@webrtc.org | 3398a4a | 2014-11-24 10:05:37 +0000 | [diff] [blame] | 161 | if f.LocalPath().startswith('webrtc'): |
| 162 | gyp_files.append(f) |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 163 | |
| 164 | result = [] |
| 165 | if gyp_files: |
| 166 | result.append(output_api.PresubmitNotifyResult( |
| 167 | 'As you\'re changing GYP files: please make sure corresponding ' |
| 168 | 'BUILD.gn files are also updated.\nChanged GYP files:', |
| 169 | items=gyp_files)) |
henrike@webrtc.org | 83fe69d | 2014-09-30 21:54:26 +0000 | [diff] [blame] | 170 | result.extend(_CheckNoRtcBaseDeps(input_api, gyp_files, output_api)) |
kjellander@webrtc.org | f68ffca | 2015-01-27 13:13:24 +0000 | [diff] [blame] | 171 | result.extend(_CheckNoSourcesAboveGyp(input_api, gyp_files, output_api)) |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 172 | return result |
| 173 | |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 174 | def _CheckUnwantedDependencies(input_api, output_api): |
| 175 | """Runs checkdeps on #include statements added in this |
| 176 | change. Breaking - rules is an error, breaking ! rules is a |
| 177 | warning. |
| 178 | """ |
| 179 | # Copied from Chromium's src/PRESUBMIT.py. |
| 180 | |
| 181 | # We need to wait until we have an input_api object and use this |
| 182 | # roundabout construct to import checkdeps because this file is |
| 183 | # eval-ed and thus doesn't have __file__. |
| 184 | original_sys_path = sys.path |
| 185 | try: |
kjellander@webrtc.org | aefe61a | 2014-12-08 13:00:30 +0000 | [diff] [blame] | 186 | checkdeps_path = input_api.os_path.join(input_api.PresubmitLocalPath(), |
| 187 | 'buildtools', 'checkdeps') |
| 188 | if not os.path.exists(checkdeps_path): |
| 189 | return [output_api.PresubmitError( |
| 190 | 'Cannot find checkdeps at %s\nHave you run "gclient sync" to ' |
| 191 | 'download Chromium and setup the symlinks?' % checkdeps_path)] |
| 192 | sys.path.append(checkdeps_path) |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 193 | import checkdeps |
| 194 | from cpp_checker import CppChecker |
| 195 | from rules import Rule |
| 196 | finally: |
| 197 | # Restore sys.path to what it was before. |
| 198 | sys.path = original_sys_path |
| 199 | |
| 200 | added_includes = [] |
| 201 | for f in input_api.AffectedFiles(): |
| 202 | if not CppChecker.IsCppFile(f.LocalPath()): |
| 203 | continue |
| 204 | |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 205 | changed_lines = [line for _, line in f.ChangedContents()] |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 206 | added_includes.append([f.LocalPath(), changed_lines]) |
| 207 | |
| 208 | deps_checker = checkdeps.DepsChecker(input_api.PresubmitLocalPath()) |
| 209 | |
| 210 | error_descriptions = [] |
| 211 | warning_descriptions = [] |
| 212 | for path, rule_type, rule_description in deps_checker.CheckAddedCppIncludes( |
| 213 | added_includes): |
| 214 | description_with_path = '%s\n %s' % (path, rule_description) |
| 215 | if rule_type == Rule.DISALLOW: |
| 216 | error_descriptions.append(description_with_path) |
| 217 | else: |
| 218 | warning_descriptions.append(description_with_path) |
| 219 | |
| 220 | results = [] |
| 221 | if error_descriptions: |
| 222 | results.append(output_api.PresubmitError( |
| 223 | 'You added one or more #includes that violate checkdeps rules.', |
| 224 | error_descriptions)) |
| 225 | if warning_descriptions: |
| 226 | results.append(output_api.PresubmitPromptOrNotify( |
| 227 | 'You added one or more #includes of files that are temporarily\n' |
| 228 | 'allowed but being removed. Can you avoid introducing the\n' |
| 229 | '#include? See relevant DEPS file(s) for details and contacts.', |
| 230 | warning_descriptions)) |
| 231 | return results |
| 232 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 233 | |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 234 | def _CommonChecks(input_api, output_api): |
| 235 | """Checks common to both upload and commit.""" |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 236 | results = [] |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 237 | results.extend(input_api.canned_checks.RunPylint(input_api, output_api, |
| 238 | black_list=(r'^.*gviz_api\.py$', |
| 239 | r'^.*gaeunit\.py$', |
fischman@webrtc.org | 33584f9 | 2013-07-25 16:43:30 +0000 | [diff] [blame] | 240 | # Embedded shell-script fakes out pylint. |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 241 | r'^build/.*\.py$', |
| 242 | r'^buildtools/.*\.py$', |
kjellander@webrtc.org | 8925662 | 2014-08-20 12:10:11 +0000 | [diff] [blame] | 243 | r'^chromium/.*\.py$', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 244 | r'^out.*/.*\.py$', |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 245 | r'^testing/.*\.py$', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 246 | r'^third_party/.*\.py$', |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 247 | r'^tools/clang/.*\.py$', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 248 | r'^tools/gn/.*\.py$', |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 249 | r'^tools/gyp/.*\.py$', |
phoglund@webrtc.org | 6d07ad9 | 2013-05-14 09:42:39 +0000 | [diff] [blame] | 250 | r'^tools/protoc_wrapper/.*\.py$', |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 251 | r'^tools/python/.*\.py$', |
| 252 | r'^tools/python_charts/data/.*\.py$', |
kjellander@webrtc.org | 3365422 | 2013-08-22 07:57:00 +0000 | [diff] [blame] | 253 | r'^tools/refactoring/.*\.py$', |
kjellander@webrtc.org | f9bdbe3 | 2013-12-11 13:37:12 +0000 | [diff] [blame] | 254 | r'^tools/swarming_client/.*\.py$', |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 255 | # TODO(phoglund): should arguably be checked. |
| 256 | r'^tools/valgrind-webrtc/.*\.py$', |
| 257 | r'^tools/valgrind/.*\.py$', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 258 | r'^xcodebuild.*/.*\.py$',), |
phoglund@webrtc.org | 5d371393 | 2013-03-07 09:59:43 +0000 | [diff] [blame] | 259 | disabled_warnings=['F0401', # Failed to import x |
| 260 | 'E0611', # No package y in x |
| 261 | 'W0232', # Class has no __init__ method |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 262 | ], |
| 263 | pylintrc='pylintrc')) |
| 264 | # WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since |
| 265 | # we need to have different license checks in talk/ and webrtc/ directories. |
| 266 | # Instead, hand-picked checks are included below. |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 267 | results.extend(input_api.canned_checks.CheckLongLines( |
pbos@webrtc.org | f2e7bc6 | 2013-04-08 15:46:07 +0000 | [diff] [blame] | 268 | input_api, output_api, maxlen=80)) |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 269 | results.extend(input_api.canned_checks.CheckChangeHasNoTabs( |
| 270 | input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 271 | results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( |
| 272 | input_api, output_api)) |
| 273 | results.extend(input_api.canned_checks.CheckChangeTodoHasOwner( |
| 274 | input_api, output_api)) |
mflodman@webrtc.org | 2a45209 | 2012-07-01 05:55:23 +0000 | [diff] [blame] | 275 | results.extend(_CheckApprovedFilesLintClean(input_api, output_api)) |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 276 | results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) |
| 277 | results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 278 | results.extend(_CheckGypChanges(input_api, output_api)) |
kjellander@webrtc.org | 3bd4156 | 2014-09-01 11:06:37 +0000 | [diff] [blame] | 279 | results.extend(_CheckUnwantedDependencies(input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 280 | return results |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 281 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 282 | |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 283 | def CheckChangeOnUpload(input_api, output_api): |
| 284 | results = [] |
| 285 | results.extend(_CommonChecks(input_api, output_api)) |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 286 | results.extend( |
| 287 | input_api.canned_checks.CheckGNFormatted(input_api, output_api)) |
niklase@google.com | da159d6 | 2011-05-30 11:51:34 +0000 | [diff] [blame] | 288 | return results |
| 289 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 290 | |
andrew@webrtc.org | 2442de1 | 2012-01-23 17:45:41 +0000 | [diff] [blame] | 291 | def CheckChangeOnCommit(input_api, output_api): |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 292 | results = [] |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 293 | results.extend(_CommonChecks(input_api, output_api)) |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 294 | results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) |
andrew@webrtc.org | 53df136 | 2012-01-26 21:24:23 +0000 | [diff] [blame] | 295 | results.extend(input_api.canned_checks.CheckChangeWasUploaded( |
| 296 | input_api, output_api)) |
| 297 | results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 298 | input_api, output_api)) |
kjellander@webrtc.org | 51198f1 | 2012-02-21 17:53:46 +0000 | [diff] [blame] | 299 | results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 300 | input_api, output_api)) |
| 301 | results.extend(input_api.canned_checks.CheckChangeHasTestField( |
| 302 | input_api, output_api)) |
kjellander@webrtc.org | 12cb88c | 2014-02-13 11:53:43 +0000 | [diff] [blame] | 303 | results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 304 | input_api, output_api, |
| 305 | json_url='http://webrtc-status.appspot.com/current?format=json')) |
niklase@google.com | 1198db9 | 2011-06-09 07:07:24 +0000 | [diff] [blame] | 306 | return results |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 307 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 308 | |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 309 | def GetDefaultTryConfigs(bots=None): |
| 310 | """Returns a list of ('bot', set(['tests']), optionally filtered by [bots]. |
| 311 | |
| 312 | For WebRTC purposes, we always return an empty list of tests, since we want |
| 313 | to run all tests by default on all our trybots. |
| 314 | """ |
Henrik Kjellander | 57e5fd2 | 2015-05-25 12:55:39 +0200 | [diff] [blame] | 315 | return {'tryserver.webrtc': dict((bot, []) for bot in bots)} |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 316 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 317 | |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 318 | # pylint: disable=W0613 |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 319 | def GetPreferredTryMasters(project, change): |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 320 | files = change.LocalPaths() |
| 321 | |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 322 | android_gn_bots = [ |
| 323 | 'android_gn', |
| 324 | 'android_gn_rel', |
| 325 | ] |
kjellander@webrtc.org | cf2b3ac | 2013-12-20 21:20:42 +0000 | [diff] [blame] | 326 | android_bots = [ |
| 327 | 'android', |
Henrik Kjellander | 36fc1ba | 2015-04-15 15:37:46 +0200 | [diff] [blame] | 328 | 'android_arm64_rel', |
kjellander@webrtc.org | cf2b3ac | 2013-12-20 21:20:42 +0000 | [diff] [blame] | 329 | 'android_rel', |
| 330 | 'android_clang', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 331 | ] + android_gn_bots |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 332 | ios_bots = [ |
| 333 | 'ios', |
kjellander@webrtc.org | d91d359 | 2014-12-08 07:05:38 +0000 | [diff] [blame] | 334 | 'ios_arm64', |
| 335 | 'ios_arm64_rel', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 336 | 'ios_rel', |
Henrik Kjellander | d43ba89 | 2015-04-20 08:58:18 +0200 | [diff] [blame] | 337 | 'ios32_sim', |
| 338 | 'ios64_sim', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 339 | ] |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 340 | linux_gn_bots = [ |
| 341 | 'linux_gn', |
| 342 | 'linux_gn_rel', |
| 343 | ] |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 344 | linux_bots = [ |
| 345 | 'linux', |
| 346 | 'linux_asan', |
kjellander@webrtc.org | 570bc3d | 2014-01-22 19:00:01 +0000 | [diff] [blame] | 347 | 'linux_baremetal', |
kjellander@webrtc.org | 3b839d0 | 2014-10-24 21:41:24 +0000 | [diff] [blame] | 348 | 'linux_msan', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 349 | 'linux_rel', |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 350 | 'linux_tsan2', |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 351 | ] + linux_gn_bots |
kjellander@webrtc.org | 1592df7 | 2015-01-09 15:38:29 +0000 | [diff] [blame] | 352 | mac_gn_bots = [ |
| 353 | 'mac_x64_gn', |
| 354 | 'mac_x64_gn_rel', |
| 355 | ] |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 356 | mac_bots = [ |
| 357 | 'mac', |
| 358 | 'mac_asan', |
kjellander@webrtc.org | 570bc3d | 2014-01-22 19:00:01 +0000 | [diff] [blame] | 359 | 'mac_baremetal', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 360 | 'mac_rel', |
kjellander@webrtc.org | c0fc4dd | 2015-02-17 08:30:29 +0000 | [diff] [blame] | 361 | 'mac_x64', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 362 | 'mac_x64_rel', |
kjellander@webrtc.org | 1592df7 | 2015-01-09 15:38:29 +0000 | [diff] [blame] | 363 | ] + mac_gn_bots |
| 364 | win_gn_bots = [ |
| 365 | 'win_x64_gn', |
| 366 | 'win_x64_gn_rel', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 367 | ] |
| 368 | win_bots = [ |
| 369 | 'win', |
kjellander@webrtc.org | 570bc3d | 2014-01-22 19:00:01 +0000 | [diff] [blame] | 370 | 'win_baremetal', |
kjellander@webrtc.org | a956ec2 | 2014-04-14 08:38:27 +0000 | [diff] [blame] | 371 | 'win_drmemory_light', |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 372 | 'win_rel', |
| 373 | 'win_x64_rel', |
kjellander@webrtc.org | 1592df7 | 2015-01-09 15:38:29 +0000 | [diff] [blame] | 374 | ] + win_gn_bots |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 375 | if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files): |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 376 | return {} |
kjellander@webrtc.org | e415864 | 2014-08-06 09:11:18 +0000 | [diff] [blame] | 377 | if all(re.search(r'[\\/]BUILD.gn$', f) for f in files): |
kjellander@webrtc.org | 1592df7 | 2015-01-09 15:38:29 +0000 | [diff] [blame] | 378 | return GetDefaultTryConfigs(android_gn_bots + linux_gn_bots + mac_gn_bots + |
| 379 | win_gn_bots) |
Henrik Kjellander | e982a70 | 2015-05-25 16:33:54 +0200 | [diff] [blame] | 380 | if all(re.search('[/_]mac[/_.]', f) for f in files): |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 381 | return GetDefaultTryConfigs(mac_bots) |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 382 | if all(re.search('(^|[/_])win[/_.]', f) for f in files): |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 383 | return GetDefaultTryConfigs(win_bots) |
| 384 | if all(re.search('(^|[/_])android[/_.]', f) for f in files): |
| 385 | return GetDefaultTryConfigs(android_bots) |
| 386 | if all(re.search('[/_]ios[/_.]', f) for f in files): |
| 387 | return GetDefaultTryConfigs(ios_bots) |
kjellander@webrtc.org | 8575980 | 2013-10-22 16:47:40 +0000 | [diff] [blame] | 388 | |
kjellander@webrtc.org | c7b8b2f | 2014-04-03 20:19:36 +0000 | [diff] [blame] | 389 | return GetDefaultTryConfigs(android_bots + ios_bots + linux_bots + mac_bots + |
| 390 | win_bots) |