Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <memory> |
| 12 | #include <vector> |
| 13 | |
Karl Wiberg | 1b0eae3 | 2017-10-17 14:48:54 +0200 | [diff] [blame] | 14 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 15 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 16 | #include "api/jsep.h" |
| 17 | #include "api/mediastreaminterface.h" |
| 18 | #include "api/peerconnectioninterface.h" |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 19 | #include "api/umametrics.h" |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 20 | #include "pc/mediasession.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 21 | #include "pc/mediastream.h" |
| 22 | #include "pc/mediastreamtrack.h" |
| 23 | #include "pc/peerconnectionwrapper.h" |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 24 | #include "pc/sdputils.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 25 | #include "pc/test/fakeaudiocapturemodule.h" |
| 26 | #include "pc/test/mockpeerconnectionobservers.h" |
| 27 | #include "rtc_base/checks.h" |
| 28 | #include "rtc_base/gunit.h" |
| 29 | #include "rtc_base/ptr_util.h" |
| 30 | #include "rtc_base/refcountedobject.h" |
| 31 | #include "rtc_base/scoped_ref_ptr.h" |
| 32 | #include "rtc_base/thread.h" |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 33 | #include "test/gmock.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 34 | |
| 35 | // This file contains tests for RTP Media API-related behavior of |
| 36 | // |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
| 37 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 38 | namespace webrtc { |
| 39 | |
| 40 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 41 | using ::testing::ElementsAre; |
| 42 | using ::testing::UnorderedElementsAre; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 43 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 44 | const uint32_t kDefaultTimeout = 10000u; |
| 45 | |
| 46 | template <typename MethodFunctor> |
| 47 | class OnSuccessObserver : public rtc::RefCountedObject< |
| 48 | webrtc::SetRemoteDescriptionObserverInterface> { |
| 49 | public: |
| 50 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 51 | : on_success_(std::move(on_success)) {} |
| 52 | |
| 53 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 54 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 55 | RTC_CHECK(error.ok()); |
| 56 | on_success_(); |
| 57 | } |
| 58 | |
| 59 | private: |
| 60 | MethodFunctor on_success_; |
| 61 | }; |
| 62 | |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 63 | class PeerConnectionRtpTest : public testing::Test { |
| 64 | public: |
| 65 | PeerConnectionRtpTest() |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 66 | : pc_factory_( |
| 67 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 68 | rtc::Thread::Current(), |
| 69 | rtc::Thread::Current(), |
| 70 | FakeAudioCaptureModule::Create(), |
| 71 | CreateBuiltinAudioEncoderFactory(), |
| 72 | CreateBuiltinAudioDecoderFactory(), |
| 73 | nullptr, |
| 74 | nullptr)) {} |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 75 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 76 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 77 | return CreatePeerConnection(RTCConfiguration()); |
| 78 | } |
| 79 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 80 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() { |
| 81 | RTCConfiguration config; |
| 82 | config.sdp_semantics = SdpSemantics::kPlanB; |
| 83 | return CreatePeerConnection(config); |
| 84 | } |
| 85 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 86 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 87 | RTCConfiguration config; |
| 88 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
| 89 | return CreatePeerConnection(config); |
| 90 | } |
| 91 | |
| 92 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 93 | const RTCConfiguration& config) { |
| 94 | auto observer = rtc::MakeUnique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 95 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 96 | observer.get()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 97 | return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc, |
| 98 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 99 | } |
| 100 | |
| 101 | protected: |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 102 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 103 | }; |
| 104 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 105 | // These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon |
| 106 | // setting the remote description. |
| 107 | class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {}; |
| 108 | |
| 109 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 110 | auto caller = CreatePeerConnection(); |
| 111 | auto callee = CreatePeerConnection(); |
| 112 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 113 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"))); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 114 | ASSERT_TRUE( |
| 115 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 116 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 117 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 118 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 119 | // Since we are not supporting the no stream case with Plan B, there should be |
| 120 | // a generated stream, even though we didn't set one with AddTrack. |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 121 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 122 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 123 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 124 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 125 | } |
| 126 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 127 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 128 | auto caller = CreatePeerConnection(); |
| 129 | auto callee = CreatePeerConnection(); |
| 130 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 131 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 132 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 133 | ASSERT_TRUE( |
| 134 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 135 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 136 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 137 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 138 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 139 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 140 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->id()); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 141 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 142 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 143 | } |
| 144 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 145 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 146 | RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 147 | auto caller = CreatePeerConnection(); |
| 148 | auto callee = CreatePeerConnection(); |
| 149 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 150 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 151 | ASSERT_TRUE( |
| 152 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 153 | static_cast<webrtc::RTCError*>(nullptr))); |
| 154 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 155 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 156 | ASSERT_TRUE( |
| 157 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 158 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 159 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 160 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 161 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 162 | callee->observer()->remove_track_events_); |
| 163 | } |
| 164 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 165 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 166 | RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 167 | auto caller = CreatePeerConnection(); |
| 168 | auto callee = CreatePeerConnection(); |
| 169 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 170 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 171 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 172 | ASSERT_TRUE( |
| 173 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 174 | static_cast<webrtc::RTCError*>(nullptr))); |
| 175 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 176 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 177 | ASSERT_TRUE( |
| 178 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 179 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 180 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 181 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 182 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 183 | callee->observer()->remove_track_events_); |
| 184 | } |
| 185 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 186 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 187 | RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 188 | auto caller = CreatePeerConnection(); |
| 189 | auto callee = CreatePeerConnection(); |
| 190 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 191 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 192 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 193 | {kSharedStreamId}); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 194 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 195 | {kSharedStreamId}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 196 | ASSERT_TRUE( |
| 197 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 198 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 199 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 200 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 201 | |
| 202 | // Remove "audio_track1". |
| 203 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 204 | ASSERT_TRUE( |
| 205 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 206 | static_cast<webrtc::RTCError*>(nullptr))); |
| 207 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 208 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 209 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 210 | callee->observer()->add_track_events_[0].receiver}, |
| 211 | callee->observer()->remove_track_events_); |
| 212 | |
| 213 | // Remove "audio_track2". |
| 214 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 215 | ASSERT_TRUE( |
| 216 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 217 | static_cast<webrtc::RTCError*>(nullptr))); |
| 218 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 219 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 220 | callee->observer()->remove_track_events_); |
| 221 | } |
| 222 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 223 | // Tests the edge case that if a stream ID changes for a given track that both |
| 224 | // OnRemoveTrack and OnAddTrack is fired. |
| 225 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 226 | RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) { |
| 227 | auto caller = CreatePeerConnection(); |
| 228 | auto callee = CreatePeerConnection(); |
| 229 | |
| 230 | const char kStreamId1[] = "stream1"; |
| 231 | const char kStreamId2[] = "stream2"; |
| 232 | caller->AddTrack(caller->CreateAudioTrack("audio_track1"), {kStreamId1}); |
| 233 | ASSERT_TRUE( |
| 234 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 235 | static_cast<webrtc::RTCError*>(nullptr))); |
| 236 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 237 | |
| 238 | // Change the stream ID of the sender in the session description. |
| 239 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 240 | auto audio_desc = offer->description()->GetContentDescriptionByName("audio"); |
| 241 | ASSERT_EQ(audio_desc->mutable_streams().size(), 1u); |
| 242 | audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2}); |
| 243 | ASSERT_TRUE( |
| 244 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()), |
| 245 | static_cast<webrtc::RTCError*>(nullptr))); |
| 246 | |
| 247 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
| 248 | EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(), |
| 249 | kStreamId2); |
| 250 | ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u); |
| 251 | EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(), |
| 252 | kStreamId1); |
| 253 | } |
| 254 | |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 255 | // Tests that setting a remote description with sending transceivers will fire |
| 256 | // the OnTrack callback for each transceiver and setting a remote description |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 257 | // with receive only transceivers will not call OnTrack. One transceiver is |
| 258 | // created without any stream_ids, while the other is created with multiple |
| 259 | // stream_ids. |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 260 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanAddTransceiverCallsOnTrack) { |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 261 | const std::string kStreamId1 = "video_stream1"; |
| 262 | const std::string kStreamId2 = "video_stream2"; |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 263 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 264 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 265 | |
| 266 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 267 | RtpTransceiverInit video_transceiver_init; |
| 268 | video_transceiver_init.stream_ids = {kStreamId1, kStreamId2}; |
| 269 | auto video_transceiver = |
| 270 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 271 | |
| 272 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 273 | |
| 274 | ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 275 | ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 276 | EXPECT_EQ(audio_transceiver->mid(), |
| 277 | callee->pc()->GetTransceivers()[0]->mid()); |
| 278 | EXPECT_EQ(video_transceiver->mid(), |
| 279 | callee->pc()->GetTransceivers()[1]->mid()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 280 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams = |
| 281 | callee->pc()->GetTransceivers()[0]->receiver()->streams(); |
| 282 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams = |
| 283 | callee->pc()->GetTransceivers()[1]->receiver()->streams(); |
| 284 | ASSERT_EQ(0u, audio_streams.size()); |
| 285 | ASSERT_EQ(2u, video_streams.size()); |
| 286 | EXPECT_EQ(kStreamId1, video_streams[0]->id()); |
| 287 | EXPECT_EQ(kStreamId2, video_streams[1]->id()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 288 | } |
| 289 | |
| 290 | // Test that doing additional offer/answer exchanges with no changes to tracks |
| 291 | // will cause no additional OnTrack calls after the tracks have been negotiated. |
| 292 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanReofferDoesNotCallOnTrack) { |
| 293 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 294 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 295 | |
| 296 | caller->AddAudioTrack("audio"); |
| 297 | callee->AddAudioTrack("audio"); |
| 298 | |
| 299 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 300 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 301 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 302 | |
| 303 | // If caller reoffers with no changes expect no additional OnTrack calls. |
| 304 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 305 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 306 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 307 | |
| 308 | // Also if callee reoffers with no changes expect no additional OnTrack calls. |
| 309 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 310 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 311 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 312 | } |
| 313 | |
| 314 | // Test that OnTrack is called when the transceiver direction changes to send |
| 315 | // the track. |
| 316 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanSetDirectionCallsOnTrack) { |
| 317 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 318 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 319 | |
| 320 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 321 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 322 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 323 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 324 | EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size()); |
| 325 | |
| 326 | transceiver->SetDirection(RtpTransceiverDirection::kSendOnly); |
| 327 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 328 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 329 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 330 | |
| 331 | // If the direction changes but it is still receiving on the remote side, then |
| 332 | // OnTrack should not be fired again. |
| 333 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 334 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 335 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 336 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 337 | } |
| 338 | |
| 339 | // Test that OnTrack is called twice when a sendrecv call is started, the callee |
| 340 | // changes the direction to inactive, then changes it back to sendrecv. |
| 341 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 342 | UnifiedPlanSetDirectionHoldCallsOnTrackTwice) { |
| 343 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 344 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 345 | |
| 346 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 347 | |
| 348 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 349 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 350 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 351 | |
| 352 | // Put the call on hold by no longer receiving the track. |
| 353 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 354 | RtpTransceiverDirection::kInactive); |
| 355 | |
| 356 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 357 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 358 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 359 | |
| 360 | // Resume the call by changing the direction to recvonly. This should call |
| 361 | // OnTrack again on the callee side. |
| 362 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 363 | RtpTransceiverDirection::kRecvOnly); |
| 364 | |
| 365 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 366 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 367 | EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 368 | } |
| 369 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 370 | // These tests examine the state of the peer connection as a result of |
| 371 | // performing SetRemoteDescription(). |
| 372 | class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {}; |
| 373 | |
| 374 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) { |
| 375 | auto caller = CreatePeerConnection(); |
| 376 | auto callee = CreatePeerConnection(); |
| 377 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 378 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), {})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 379 | ASSERT_TRUE( |
| 380 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 381 | static_cast<webrtc::RTCError*>(nullptr))); |
| 382 | |
| 383 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 384 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 385 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 386 | // Since we are not supporting the no stream case with Plan B, there should be |
| 387 | // a generated stream, even though we didn't set one with AddTrack. |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 388 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 389 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 390 | } |
| 391 | |
| 392 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) { |
| 393 | auto caller = CreatePeerConnection(); |
| 394 | auto callee = CreatePeerConnection(); |
| 395 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 396 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 397 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 398 | ASSERT_TRUE( |
| 399 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 400 | static_cast<webrtc::RTCError*>(nullptr))); |
| 401 | |
| 402 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 403 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 404 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 405 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 406 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 407 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 408 | } |
| 409 | |
| 410 | TEST_F(PeerConnectionRtpObserverTest, |
| 411 | RemoveSenderWithoutStreamRemovesReceiver) { |
| 412 | auto caller = CreatePeerConnection(); |
| 413 | auto callee = CreatePeerConnection(); |
| 414 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 415 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 416 | ASSERT_TRUE(sender); |
| 417 | ASSERT_TRUE( |
| 418 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 419 | static_cast<webrtc::RTCError*>(nullptr))); |
| 420 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 421 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 422 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 423 | ASSERT_TRUE( |
| 424 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 425 | static_cast<webrtc::RTCError*>(nullptr))); |
| 426 | |
| 427 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 428 | // Instead, the transceiver owning the receiver will become inactive. |
| 429 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 430 | } |
| 431 | |
| 432 | TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) { |
| 433 | auto caller = CreatePeerConnection(); |
| 434 | auto callee = CreatePeerConnection(); |
| 435 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 436 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 437 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 438 | ASSERT_TRUE(sender); |
| 439 | ASSERT_TRUE( |
| 440 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 441 | static_cast<webrtc::RTCError*>(nullptr))); |
| 442 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 443 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 444 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 445 | ASSERT_TRUE( |
| 446 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 447 | static_cast<webrtc::RTCError*>(nullptr))); |
| 448 | |
| 449 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 450 | // Instead, the transceiver owning the receiver will become inactive. |
| 451 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 452 | } |
| 453 | |
| 454 | TEST_F(PeerConnectionRtpObserverTest, |
| 455 | RemoveSenderWithSharedStreamRemovesReceiver) { |
| 456 | auto caller = CreatePeerConnection(); |
| 457 | auto callee = CreatePeerConnection(); |
| 458 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 459 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 460 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 461 | {kSharedStreamId}); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 462 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 463 | {kSharedStreamId}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 464 | ASSERT_TRUE( |
| 465 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 466 | static_cast<webrtc::RTCError*>(nullptr))); |
| 467 | |
| 468 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u); |
| 469 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1; |
| 470 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2; |
| 471 | if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") { |
| 472 | receiver1 = callee->pc()->GetReceivers()[0]; |
| 473 | receiver2 = callee->pc()->GetReceivers()[1]; |
| 474 | } else { |
| 475 | receiver1 = callee->pc()->GetReceivers()[1]; |
| 476 | receiver2 = callee->pc()->GetReceivers()[0]; |
| 477 | } |
| 478 | EXPECT_EQ("audio_track1", receiver1->track()->id()); |
| 479 | EXPECT_EQ("audio_track2", receiver2->track()->id()); |
| 480 | |
| 481 | // Remove "audio_track1". |
| 482 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
| 483 | ASSERT_TRUE( |
| 484 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 485 | static_cast<webrtc::RTCError*>(nullptr))); |
| 486 | // Only |receiver2| should remain. |
| 487 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 488 | // Instead, the transceiver owning the receiver will become inactive. |
| 489 | EXPECT_EQ( |
| 490 | std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2}, |
| 491 | callee->pc()->GetReceivers()); |
| 492 | |
| 493 | // Remove "audio_track2". |
| 494 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
| 495 | ASSERT_TRUE( |
| 496 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 497 | static_cast<webrtc::RTCError*>(nullptr))); |
| 498 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 499 | // Instead, the transceiver owning the receiver will become inactive. |
| 500 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 501 | } |
| 502 | |
| 503 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 504 | // calls and examine the state of the peer connection inside the callbacks to |
| 505 | // ensure that the second call does not occur prematurely, contaminating the |
| 506 | // state of the peer connection of the first callback. |
| 507 | TEST_F(PeerConnectionRtpObserverTest, |
| 508 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 509 | auto caller = CreatePeerConnection(); |
| 510 | auto callee = CreatePeerConnection(); |
| 511 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 512 | // Create SDP for adding a track and for removing it. This will be used in the |
| 513 | // first and second SetRemoteDescription() calls. |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 514 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 515 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
| 516 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 517 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 518 | |
| 519 | // In the first SetRemoteDescription() callback, check that we have a |
| 520 | // receiver for the track. |
| 521 | auto pc = callee->pc(); |
| 522 | bool srd1_callback_called = false; |
| 523 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 524 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 525 | srd1_callback_called = true; |
| 526 | }; |
| 527 | |
| 528 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 529 | // been removed. |
| 530 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 531 | // Instead, the transceiver owning the receiver will become inactive. |
| 532 | // https://crbug.com/webrtc/7600 |
| 533 | bool srd2_callback_called = false; |
| 534 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 535 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 536 | srd2_callback_called = true; |
| 537 | }; |
| 538 | |
| 539 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 540 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 541 | // effects of the second SetRemoteDescription() call must not have happened by |
| 542 | // the time the first callback is invoked. If it has then the receiver that is |
| 543 | // added as a result of the first SetRemoteDescription() call will already |
| 544 | // have been removed as a result of the second SetRemoteDescription() call |
| 545 | // when the first callback is invoked. |
| 546 | callee->pc()->SetRemoteDescription( |
| 547 | std::move(srd1_sdp), |
| 548 | new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback)); |
| 549 | callee->pc()->SetRemoteDescription( |
| 550 | std::move(srd2_sdp), |
| 551 | new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback)); |
| 552 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 553 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 554 | } |
| 555 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 556 | // Tests that with Unified Plan if the the stream id changes for a track when |
| 557 | // when setting a new remote description, that the media stream is updated |
| 558 | // appropriately for the receiver. |
| 559 | TEST_F(PeerConnectionRtpObserverTest, RemoteStreamIdChangesUpdatesReceiver) { |
| 560 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 561 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 562 | |
| 563 | const char kStreamId1[] = "stream1"; |
| 564 | const char kStreamId2[] = "stream2"; |
| 565 | caller->AddTrack(caller->CreateAudioTrack("audio_track1"), {kStreamId1}); |
| 566 | ASSERT_TRUE( |
| 567 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 568 | static_cast<webrtc::RTCError*>(nullptr))); |
| 569 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 570 | |
| 571 | // Change the stream id of the sender in the session description. |
| 572 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 573 | auto contents = offer->description()->contents(); |
| 574 | ASSERT_EQ(contents.size(), 1u); |
| 575 | ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u); |
| 576 | contents[0].media_description()->mutable_streams()[0].set_stream_ids( |
| 577 | {kStreamId2}); |
| 578 | |
| 579 | // Set the remote description and verify that the stream was updated properly. |
| 580 | ASSERT_TRUE( |
| 581 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()), |
| 582 | static_cast<webrtc::RTCError*>(nullptr))); |
| 583 | auto receivers = callee->pc()->GetReceivers(); |
| 584 | ASSERT_EQ(receivers.size(), 1u); |
| 585 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 586 | EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2); |
| 587 | } |
| 588 | |
| 589 | // This tests a regression caught by a downstream client, that occured when |
| 590 | // applying a remote description with a SessionDescription object that |
| 591 | // contained StreamParams that didn't have ids. Although there were multiple |
| 592 | // remote audio senders, FindSenderInfo didn't find them as unique, because |
| 593 | // it looked up by StreamParam.id, which none had. This meant only one |
| 594 | // AudioRtpReceiver was created, as opposed to one for each remote sender. |
| 595 | TEST_F(PeerConnectionRtpObserverTest, |
| 596 | MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) { |
| 597 | auto caller = CreatePeerConnection(); |
| 598 | auto callee = CreatePeerConnection(); |
| 599 | |
| 600 | const char kStreamId1[] = "stream1"; |
| 601 | const char kStreamId2[] = "stream2"; |
| 602 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
| 603 | caller->AddAudioTrack("audio_track2", {kStreamId2}); |
| 604 | |
| 605 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 606 | auto mutable_streams = |
| 607 | cricket::GetFirstAudioContentDescription(offer->description()) |
| 608 | ->mutable_streams(); |
| 609 | ASSERT_EQ(mutable_streams.size(), 2u); |
| 610 | // Clear the IDs in the StreamParams. |
| 611 | mutable_streams[0].id.clear(); |
| 612 | mutable_streams[1].id.clear(); |
| 613 | ASSERT_TRUE( |
| 614 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
| 615 | |
| 616 | auto receivers = callee->pc()->GetReceivers(); |
| 617 | ASSERT_EQ(receivers.size(), 2u); |
| 618 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 619 | EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id()); |
| 620 | ASSERT_EQ(receivers[1]->streams().size(), 1u); |
| 621 | EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id()); |
| 622 | } |
| 623 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 624 | // Tests for the legacy SetRemoteDescription() function signature. |
| 625 | class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {}; |
| 626 | |
| 627 | // Sanity test making sure the callback is invoked. |
| 628 | TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) { |
| 629 | auto caller = CreatePeerConnection(); |
| 630 | auto callee = CreatePeerConnection(); |
| 631 | |
| 632 | std::string error; |
| 633 | ASSERT_TRUE( |
| 634 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 635 | } |
| 636 | |
| 637 | // Verifies legacy behavior: The observer is not called if if the peer |
| 638 | // connection is destroyed because the asynchronous callback is executed in the |
| 639 | // peer connection's message handler. |
| 640 | TEST_F(PeerConnectionRtpLegacyObserverTest, |
| 641 | ObserverNotCalledIfPeerConnectionDereferenced) { |
| 642 | auto caller = CreatePeerConnection(); |
| 643 | auto callee = CreatePeerConnection(); |
| 644 | |
| 645 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
| 646 | new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>(); |
| 647 | |
| 648 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 649 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 650 | callee = nullptr; |
| 651 | rtc::Thread::Current()->ProcessMessages(0); |
| 652 | EXPECT_FALSE(observer->called()); |
| 653 | } |
| 654 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 655 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 656 | |
| 657 | // Test that by default there are no transceivers with Unified Plan. |
| 658 | TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) { |
| 659 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 660 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 661 | } |
| 662 | |
| 663 | // Test that a transceiver created with the audio kind has the correct initial |
| 664 | // properties. |
| 665 | TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) { |
| 666 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 667 | |
| 668 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 669 | EXPECT_EQ(rtc::nullopt, transceiver->mid()); |
| 670 | EXPECT_FALSE(transceiver->stopped()); |
| 671 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 672 | EXPECT_EQ(rtc::nullopt, transceiver->current_direction()); |
| 673 | } |
| 674 | |
| 675 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 676 | // and audio receiver with the receiver having a live audio track. |
| 677 | TEST_F(PeerConnectionRtpTest, |
| 678 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
| 679 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 680 | |
| 681 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 682 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 683 | |
| 684 | ASSERT_TRUE(transceiver->sender()); |
| 685 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 686 | |
| 687 | ASSERT_TRUE(transceiver->receiver()); |
| 688 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 689 | |
| 690 | auto track = transceiver->receiver()->track(); |
| 691 | ASSERT_TRUE(track); |
| 692 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 693 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 694 | } |
| 695 | |
| 696 | // Test that adding a transceiver with the video kind creates an video sender |
| 697 | // and video receiver with the receiver having a live video track. |
| 698 | TEST_F(PeerConnectionRtpTest, |
| 699 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
| 700 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 701 | |
| 702 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 703 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 704 | |
| 705 | ASSERT_TRUE(transceiver->sender()); |
| 706 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 707 | |
| 708 | ASSERT_TRUE(transceiver->receiver()); |
| 709 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 710 | |
| 711 | auto track = transceiver->receiver()->track(); |
| 712 | ASSERT_TRUE(track); |
| 713 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 714 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 715 | } |
| 716 | |
| 717 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 718 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 719 | // transceiver's receiver shows in GetReceivers(). |
| 720 | TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) { |
| 721 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 722 | |
| 723 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 724 | EXPECT_EQ( |
| 725 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 726 | caller->pc()->GetTransceivers()); |
| 727 | EXPECT_EQ( |
| 728 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 729 | transceiver->sender()}, |
| 730 | caller->pc()->GetSenders()); |
| 731 | EXPECT_EQ( |
| 732 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 733 | transceiver->receiver()}, |
| 734 | caller->pc()->GetReceivers()); |
| 735 | } |
| 736 | |
| 737 | // Test that the direction passed in through the AddTransceiver init parameter |
| 738 | // is set in the returned transceiver. |
| 739 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) { |
| 740 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 741 | |
| 742 | RtpTransceiverInit init; |
| 743 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 744 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 745 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 746 | } |
| 747 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 748 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 749 | // its sender's track set to the passed-in track. |
| 750 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 751 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 752 | |
| 753 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 754 | auto transceiver = caller->AddTransceiver(audio_track); |
| 755 | |
| 756 | auto sender = transceiver->sender(); |
| 757 | ASSERT_TRUE(sender->track()); |
| 758 | EXPECT_EQ(audio_track, sender->track()); |
| 759 | |
| 760 | auto receiver = transceiver->receiver(); |
| 761 | ASSERT_TRUE(receiver->track()); |
| 762 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 763 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 764 | receiver->track()->state()); |
| 765 | } |
| 766 | |
| 767 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 768 | // transceivers, senders with the same track. |
| 769 | TEST_F(PeerConnectionRtpTest, |
| 770 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
| 771 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 772 | |
| 773 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 774 | |
| 775 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 776 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 777 | |
| 778 | EXPECT_NE(transceiver1, transceiver2); |
| 779 | |
| 780 | auto sender1 = transceiver1->sender(); |
| 781 | auto sender2 = transceiver2->sender(); |
| 782 | EXPECT_NE(sender1, sender2); |
| 783 | EXPECT_EQ(audio_track, sender1->track()); |
| 784 | EXPECT_EQ(audio_track, sender2->track()); |
| 785 | |
| 786 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 787 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 788 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 789 | UnorderedElementsAre(sender1, sender2)); |
| 790 | } |
| 791 | |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 792 | // RtpTransceiver error handling tests. |
| 793 | |
| 794 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) { |
| 795 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 796 | |
| 797 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 798 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 799 | } |
| 800 | |
| 801 | TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) { |
| 802 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 803 | |
| 804 | caller->pc()->Close(); |
| 805 | } |
| 806 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 807 | // Unified Plan AddTrack tests. |
| 808 | |
| 809 | class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {}; |
| 810 | |
| 811 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 812 | // track. |
| 813 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) { |
| 814 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 815 | |
| 816 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 817 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 818 | ASSERT_TRUE(sender); |
| 819 | |
| 820 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 821 | EXPECT_EQ(audio_track, sender->track()); |
| 822 | } |
| 823 | |
| 824 | // Test that adding a video track creates a new video RtpSender with the given |
| 825 | // track. |
| 826 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) { |
| 827 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 828 | |
| 829 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 830 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 831 | ASSERT_TRUE(sender); |
| 832 | |
| 833 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 834 | EXPECT_EQ(video_track, sender->track()); |
| 835 | } |
| 836 | |
| 837 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 838 | // with the sender that AddTrack returns and in the sendrecv direction. |
| 839 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) { |
| 840 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 841 | |
| 842 | auto sender = caller->AddAudioTrack("a"); |
| 843 | ASSERT_TRUE(sender); |
| 844 | |
| 845 | auto transceivers = caller->pc()->GetTransceivers(); |
| 846 | ASSERT_EQ(1u, transceivers.size()); |
| 847 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 848 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 849 | } |
| 850 | |
| 851 | // Test that if a transceiver of the same type but no track had been added to |
| 852 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 853 | // is the transceiver's sender and the sender's track is the newly-added track. |
| 854 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) { |
| 855 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 856 | |
| 857 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 858 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 859 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 860 | ASSERT_TRUE(sender); |
| 861 | |
| 862 | auto transceivers = caller->pc()->GetTransceivers(); |
| 863 | ASSERT_EQ(1u, transceivers.size()); |
| 864 | EXPECT_EQ(transceiver, transceivers[0]); |
| 865 | EXPECT_EQ(sender, transceiver->sender()); |
| 866 | EXPECT_EQ(audio_track, sender->track()); |
| 867 | } |
| 868 | |
| 869 | // Test that adding two tracks to a new PeerConnection creates two |
| 870 | // RtpTransceivers in the same order. |
| 871 | TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) { |
| 872 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 873 | |
| 874 | auto sender1 = caller->AddAudioTrack("a"); |
| 875 | auto sender2 = caller->AddVideoTrack("v"); |
| 876 | ASSERT_TRUE(sender2); |
| 877 | |
| 878 | auto transceivers = caller->pc()->GetTransceivers(); |
| 879 | ASSERT_EQ(2u, transceivers.size()); |
| 880 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 881 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 882 | } |
| 883 | |
| 884 | // Test that if there are multiple transceivers with no sending track then a |
| 885 | // later call to AddTrack will use the one of the same type as the newly-added |
| 886 | // track. |
| 887 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) { |
| 888 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 889 | |
| 890 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 891 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 892 | auto sender = caller->AddVideoTrack("v"); |
| 893 | |
| 894 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 895 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 896 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 897 | } |
| 898 | |
| 899 | // Test that if the only transceivers that do not have a sending track have a |
| 900 | // different type from the added track, then AddTrack will create a new |
| 901 | // transceiver for the track. |
| 902 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 903 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
| 904 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 905 | |
| 906 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 907 | auto sender = caller->AddVideoTrack("v"); |
| 908 | |
| 909 | auto transceivers = caller->pc()->GetTransceivers(); |
| 910 | ASSERT_EQ(2u, transceivers.size()); |
| 911 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 912 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 913 | } |
| 914 | |
| 915 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 916 | // are available. |
| 917 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 918 | AddTrackReusesFirstMatchingTransceiver) { |
| 919 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 920 | |
| 921 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 922 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 923 | auto sender = caller->AddAudioTrack("a"); |
| 924 | |
| 925 | auto transceivers = caller->pc()->GetTransceivers(); |
| 926 | ASSERT_EQ(2u, transceivers.size()); |
| 927 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 928 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 929 | } |
| 930 | |
| 931 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 932 | // direction from inactive to sendonly. |
| 933 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 934 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
| 935 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 936 | |
| 937 | RtpTransceiverInit init; |
| 938 | init.direction = RtpTransceiverDirection::kInactive; |
| 939 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 940 | |
| 941 | caller->observer()->clear_negotiation_needed(); |
| 942 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 943 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 944 | |
| 945 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 946 | } |
| 947 | |
| 948 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 949 | // direction from recvonly to sendrecv. |
| 950 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 951 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
| 952 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 953 | |
| 954 | RtpTransceiverInit init; |
| 955 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 956 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 957 | |
| 958 | caller->observer()->clear_negotiation_needed(); |
| 959 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 960 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 961 | |
| 962 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 963 | } |
| 964 | |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 965 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackCreatesSenderWithTrackId) { |
| 966 | const std::string kTrackId = "audio_track"; |
| 967 | |
| 968 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 969 | |
| 970 | auto audio_track = caller->CreateAudioTrack(kTrackId); |
| 971 | auto sender = caller->AddTrack(audio_track); |
| 972 | |
| 973 | EXPECT_EQ(kTrackId, sender->id()); |
| 974 | } |
| 975 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 976 | // Unified Plan AddTrack error handling. |
| 977 | |
| 978 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) { |
| 979 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 980 | |
| 981 | auto audio_track = caller->CreateAudioTrack("a"); |
| 982 | caller->pc()->Close(); |
| 983 | |
| 984 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 985 | auto result = caller->pc() |
| 986 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 987 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 988 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 989 | } |
| 990 | |
| 991 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) { |
| 992 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 993 | |
| 994 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 995 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 996 | |
| 997 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 998 | auto result = caller->pc() |
| 999 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 1000 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1001 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1002 | } |
| 1003 | |
| 1004 | // Unified Plan RemoveTrack tests. |
| 1005 | |
| 1006 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 1007 | // clears the sender's track. |
| 1008 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) { |
| 1009 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1010 | |
| 1011 | auto sender = caller->AddAudioTrack("a"); |
| 1012 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1013 | |
| 1014 | EXPECT_FALSE(sender->track()); |
| 1015 | } |
| 1016 | |
| 1017 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1018 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
| 1019 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1020 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
| 1021 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1022 | |
| 1023 | RtpTransceiverInit init; |
| 1024 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 1025 | auto transceiver = |
| 1026 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 1027 | |
| 1028 | caller->observer()->clear_negotiation_needed(); |
| 1029 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 1030 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1031 | |
| 1032 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
| 1033 | EXPECT_TRUE(caller->observer()->renegotiation_needed_); |
| 1034 | } |
| 1035 | |
| 1036 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1037 | // in the sendonly direction changes the transceiver's direction to inactive. |
| 1038 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1039 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
| 1040 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1041 | |
| 1042 | RtpTransceiverInit init; |
| 1043 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 1044 | auto transceiver = |
| 1045 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 1046 | |
| 1047 | caller->observer()->clear_negotiation_needed(); |
| 1048 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 1049 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1050 | |
| 1051 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 1052 | } |
| 1053 | |
| 1054 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 1055 | // no change in state. |
| 1056 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 1057 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1058 | |
| 1059 | auto sender = caller->AddAudioTrack("a"); |
| 1060 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 1061 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 1062 | |
| 1063 | caller->observer()->clear_negotiation_needed(); |
| 1064 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1065 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1066 | |
| 1067 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 1068 | } |
| 1069 | |
| 1070 | // Unified Plan RemoveTrack error handling. |
| 1071 | |
| 1072 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) { |
| 1073 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1074 | |
| 1075 | auto sender = caller->AddAudioTrack("a"); |
| 1076 | caller->pc()->Close(); |
| 1077 | |
| 1078 | caller->observer()->clear_negotiation_needed(); |
| 1079 | EXPECT_FALSE(caller->pc()->RemoveTrack(sender)); |
| 1080 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1081 | } |
| 1082 | |
| 1083 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1084 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
| 1085 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1086 | |
| 1087 | auto sender = caller->AddAudioTrack("a"); |
| 1088 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1089 | |
| 1090 | caller->observer()->clear_negotiation_needed(); |
| 1091 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 1092 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1093 | } |
| 1094 | |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1095 | // Test that OnRenegotiationNeeded is fired if SetDirection is called on an |
| 1096 | // active RtpTransceiver with a new direction. |
| 1097 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1098 | RenegotiationNeededAfterTransceiverSetDirection) { |
| 1099 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1100 | |
| 1101 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1102 | |
| 1103 | caller->observer()->clear_negotiation_needed(); |
| 1104 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 1105 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 1106 | } |
| 1107 | |
| 1108 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on an |
| 1109 | // active RtpTransceiver with current direction. |
| 1110 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1111 | NoRenegotiationNeededAfterTransceiverSetSameDirection) { |
| 1112 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1113 | |
| 1114 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1115 | |
| 1116 | caller->observer()->clear_negotiation_needed(); |
| 1117 | transceiver->SetDirection(transceiver->direction()); |
| 1118 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1119 | } |
| 1120 | |
| 1121 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on a |
| 1122 | // stopped RtpTransceiver. |
| 1123 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1124 | NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) { |
| 1125 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1126 | |
| 1127 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1128 | transceiver->Stop(); |
| 1129 | |
| 1130 | caller->observer()->clear_negotiation_needed(); |
| 1131 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 1132 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1133 | } |
| 1134 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1135 | // Test MSID signaling between Unified Plan and Plan B endpoints. There are two |
| 1136 | // options for this kind of signaling: media section based (a=msid) and ssrc |
| 1137 | // based (a=ssrc MSID). While JSEP only specifies media section MSID signaling, |
| 1138 | // we want to ensure compatibility with older Plan B endpoints that might expect |
| 1139 | // ssrc based MSID signaling. Thus we test here that Unified Plan offers both |
| 1140 | // types but answers with the same type as the offer. |
| 1141 | |
| 1142 | class PeerConnectionMsidSignalingTest : public PeerConnectionRtpTest {}; |
| 1143 | |
| 1144 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) { |
| 1145 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1146 | caller->AddAudioTrack("caller_audio"); |
| 1147 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1148 | callee->AddAudioTrack("callee_audio"); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1149 | auto caller_observer = caller->RegisterFakeMetricsObserver(); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1150 | |
| 1151 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1152 | |
| 1153 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1154 | auto* offer = callee->pc()->remote_description(); |
| 1155 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1156 | cricket::kMsidSignalingSsrcAttribute), |
| 1157 | offer->description()->msid_signaling()); |
| 1158 | |
| 1159 | // Answer should have had only a=msid lines. |
| 1160 | auto* answer = caller->pc()->remote_description(); |
| 1161 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1162 | answer->description()->msid_signaling()); |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 1163 | // Check that this is counted correctly |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1164 | EXPECT_TRUE(caller_observer->ExpectOnlySingleEnumCount( |
| 1165 | kEnumCounterSdpSemanticNegotiated, kSdpSemanticNegotiatedUnifiedPlan)); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1166 | } |
| 1167 | |
| 1168 | TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) { |
| 1169 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1170 | caller->AddAudioTrack("caller_audio"); |
| 1171 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1172 | callee->AddAudioTrack("callee_audio"); |
| 1173 | |
| 1174 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1175 | |
| 1176 | // Offer should have only a=ssrc MSID lines. |
| 1177 | auto* offer = callee->pc()->remote_description(); |
| 1178 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1179 | offer->description()->msid_signaling()); |
| 1180 | |
| 1181 | // Answer should have only a=ssrc MSID lines to match the offer. |
| 1182 | auto* answer = caller->pc()->remote_description(); |
| 1183 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1184 | answer->description()->msid_signaling()); |
| 1185 | } |
| 1186 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 1187 | // This tests that a Plan B endpoint appropriately sets the remote description |
| 1188 | // from a Unified Plan offer. When the Unified Plan offer contains a=msid lines |
| 1189 | // that signal no stream ids or multiple stream ids we expect that the Plan B |
| 1190 | // endpoint always has exactly one media stream per track. |
| 1191 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) { |
| 1192 | const std::string kStreamId1 = "audio_stream_1"; |
| 1193 | const std::string kStreamId2 = "audio_stream_2"; |
| 1194 | |
| 1195 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1196 | caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2}); |
| 1197 | caller->AddVideoTrack("caller_video", {}); |
| 1198 | auto callee = CreatePeerConnectionWithPlanB(); |
| 1199 | callee->AddAudioTrack("callee_audio"); |
| 1200 | caller->AddVideoTrack("callee_video"); |
| 1201 | |
| 1202 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1203 | |
| 1204 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1205 | auto* offer = callee->pc()->remote_description(); |
| 1206 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1207 | cricket::kMsidSignalingSsrcAttribute), |
| 1208 | offer->description()->msid_signaling()); |
| 1209 | |
| 1210 | // Callee should always have 1 stream for all of it's receivers. |
| 1211 | const auto& track_events = callee->observer()->add_track_events_; |
| 1212 | ASSERT_EQ(2u, track_events.size()); |
| 1213 | ASSERT_EQ(1u, track_events[0].streams.size()); |
| 1214 | EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id()); |
| 1215 | ASSERT_EQ(1u, track_events[1].streams.size()); |
| 1216 | // This autogenerated a stream id for the empty one signalled. |
| 1217 | EXPECT_FALSE(track_events[1].streams[0]->id().empty()); |
| 1218 | } |
| 1219 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1220 | TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) { |
| 1221 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1222 | caller->AddAudioTrack("caller_audio"); |
| 1223 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1224 | callee->AddAudioTrack("callee_audio"); |
| 1225 | |
| 1226 | auto offer = caller->CreateOffer(); |
| 1227 | // Simulate a pure Unified Plan offerer by setting the MSID signaling to media |
| 1228 | // section only. |
| 1229 | offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection); |
| 1230 | |
| 1231 | ASSERT_TRUE( |
| 1232 | caller->SetLocalDescription(CloneSessionDescription(offer.get()))); |
| 1233 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
| 1234 | |
| 1235 | // Answer should have only a=msid to match the offer. |
| 1236 | auto answer = callee->CreateAnswer(); |
| 1237 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1238 | answer->description()->msid_signaling()); |
| 1239 | } |
| 1240 | |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1241 | // Test that the correct UMA metrics are reported for simple/complex SDP. |
| 1242 | |
| 1243 | class SdpFormatReceivedTest : public PeerConnectionRtpTest {}; |
| 1244 | |
| 1245 | #ifdef HAVE_SCTP |
| 1246 | TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) { |
| 1247 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1248 | caller->CreateDataChannel("dc"); |
| 1249 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1250 | auto callee_metrics = callee->RegisterFakeMetricsObserver(); |
| 1251 | |
| 1252 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1253 | |
| 1254 | EXPECT_TRUE(callee_metrics->ExpectOnlySingleEnumCount( |
| 1255 | kEnumCounterSdpFormatReceived, kSdpFormatReceivedNoTracks)); |
| 1256 | } |
| 1257 | #endif // HAVE_SCTP |
| 1258 | |
| 1259 | TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) { |
| 1260 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1261 | caller->AddAudioTrack("audio"); |
| 1262 | caller->AddVideoTrack("video"); |
| 1263 | auto callee = CreatePeerConnectionWithPlanB(); |
| 1264 | auto callee_metrics = callee->RegisterFakeMetricsObserver(); |
| 1265 | |
| 1266 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1267 | |
| 1268 | EXPECT_TRUE(callee_metrics->ExpectOnlySingleEnumCount( |
| 1269 | kEnumCounterSdpFormatReceived, kSdpFormatReceivedSimple)); |
| 1270 | } |
| 1271 | |
| 1272 | TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) { |
| 1273 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1274 | caller->AddVideoTrack("video"); // Video only. |
| 1275 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1276 | auto callee_metrics = callee->RegisterFakeMetricsObserver(); |
| 1277 | |
| 1278 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1279 | |
| 1280 | EXPECT_TRUE(callee_metrics->ExpectOnlySingleEnumCount( |
| 1281 | kEnumCounterSdpFormatReceived, kSdpFormatReceivedSimple)); |
| 1282 | } |
| 1283 | |
| 1284 | TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) { |
| 1285 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1286 | caller->AddAudioTrack("audio1"); |
| 1287 | caller->AddAudioTrack("audio2"); |
| 1288 | caller->AddVideoTrack("video"); |
| 1289 | auto callee = CreatePeerConnectionWithPlanB(); |
| 1290 | auto callee_metrics = callee->RegisterFakeMetricsObserver(); |
| 1291 | |
| 1292 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1293 | |
| 1294 | EXPECT_TRUE(callee_metrics->ExpectOnlySingleEnumCount( |
| 1295 | kEnumCounterSdpFormatReceived, kSdpFormatReceivedComplexUnifiedPlan)); |
| 1296 | } |
| 1297 | |
| 1298 | TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) { |
| 1299 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1300 | caller->AddVideoTrack("video1"); |
| 1301 | caller->AddVideoTrack("video2"); |
| 1302 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1303 | auto callee_metrics = callee->RegisterFakeMetricsObserver(); |
| 1304 | |
| 1305 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1306 | |
| 1307 | EXPECT_TRUE(callee_metrics->ExpectOnlySingleEnumCount( |
| 1308 | kEnumCounterSdpFormatReceived, kSdpFormatReceivedComplexPlanB)); |
| 1309 | } |
| 1310 | |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1311 | // Sender setups in a call. |
| 1312 | |
| 1313 | class PeerConnectionSenderTest : public PeerConnectionRtpTest {}; |
| 1314 | |
| 1315 | TEST_F(PeerConnectionSenderTest, CreateTwoSendersWithSameTrack) { |
| 1316 | auto caller = CreatePeerConnection(); |
| 1317 | auto callee = CreatePeerConnection(); |
| 1318 | |
| 1319 | auto track = caller->CreateAudioTrack("audio_track"); |
| 1320 | auto sender1 = caller->AddTrack(track); |
| 1321 | ASSERT_TRUE(sender1); |
| 1322 | // We need to temporarily reset the track for the subsequent AddTrack() to |
| 1323 | // succeed. |
| 1324 | EXPECT_TRUE(sender1->SetTrack(nullptr)); |
| 1325 | auto sender2 = caller->AddTrack(track); |
| 1326 | EXPECT_TRUE(sender2); |
| 1327 | EXPECT_TRUE(sender1->SetTrack(track)); |
| 1328 | |
| 1329 | // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should |
| 1330 | // return true, and doing |callee->SetRemoteDescription()| should work. |
| 1331 | EXPECT_FALSE(caller->CreateOfferAndSetAsLocal()); |
| 1332 | } |
| 1333 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1334 | } // namespace webrtc |