Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <memory> |
| 12 | #include <vector> |
| 13 | |
Karl Wiberg | 1b0eae3 | 2017-10-17 14:48:54 +0200 | [diff] [blame] | 14 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 15 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 16 | #include "api/fakemetricsobserver.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 17 | #include "api/jsep.h" |
| 18 | #include "api/mediastreaminterface.h" |
| 19 | #include "api/peerconnectioninterface.h" |
| 20 | #include "pc/mediastream.h" |
| 21 | #include "pc/mediastreamtrack.h" |
| 22 | #include "pc/peerconnectionwrapper.h" |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 23 | #include "pc/sdputils.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 24 | #include "pc/test/fakeaudiocapturemodule.h" |
| 25 | #include "pc/test/mockpeerconnectionobservers.h" |
| 26 | #include "rtc_base/checks.h" |
| 27 | #include "rtc_base/gunit.h" |
| 28 | #include "rtc_base/ptr_util.h" |
| 29 | #include "rtc_base/refcountedobject.h" |
| 30 | #include "rtc_base/scoped_ref_ptr.h" |
| 31 | #include "rtc_base/thread.h" |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 32 | #include "test/gmock.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 33 | |
| 34 | // This file contains tests for RTP Media API-related behavior of |
| 35 | // |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
| 36 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 37 | namespace webrtc { |
| 38 | |
| 39 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 40 | using ::testing::ElementsAre; |
| 41 | using ::testing::UnorderedElementsAre; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 42 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 43 | const uint32_t kDefaultTimeout = 10000u; |
| 44 | |
| 45 | template <typename MethodFunctor> |
| 46 | class OnSuccessObserver : public rtc::RefCountedObject< |
| 47 | webrtc::SetRemoteDescriptionObserverInterface> { |
| 48 | public: |
| 49 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 50 | : on_success_(std::move(on_success)) {} |
| 51 | |
| 52 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 53 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 54 | RTC_CHECK(error.ok()); |
| 55 | on_success_(); |
| 56 | } |
| 57 | |
| 58 | private: |
| 59 | MethodFunctor on_success_; |
| 60 | }; |
| 61 | |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 62 | class PeerConnectionRtpTest : public testing::Test { |
| 63 | public: |
| 64 | PeerConnectionRtpTest() |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 65 | : pc_factory_( |
| 66 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 67 | rtc::Thread::Current(), |
| 68 | rtc::Thread::Current(), |
| 69 | FakeAudioCaptureModule::Create(), |
| 70 | CreateBuiltinAudioEncoderFactory(), |
| 71 | CreateBuiltinAudioDecoderFactory(), |
| 72 | nullptr, |
| 73 | nullptr)) {} |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 74 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 75 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 76 | return CreatePeerConnection(RTCConfiguration()); |
| 77 | } |
| 78 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 79 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() { |
| 80 | RTCConfiguration config; |
| 81 | config.sdp_semantics = SdpSemantics::kPlanB; |
| 82 | return CreatePeerConnection(config); |
| 83 | } |
| 84 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 85 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 86 | RTCConfiguration config; |
| 87 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
| 88 | return CreatePeerConnection(config); |
| 89 | } |
| 90 | |
| 91 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 92 | const RTCConfiguration& config) { |
| 93 | auto observer = rtc::MakeUnique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 94 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 95 | observer.get()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 96 | return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc, |
| 97 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 98 | } |
| 99 | |
| 100 | protected: |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 101 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 102 | }; |
| 103 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 104 | // These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon |
| 105 | // setting the remote description. |
| 106 | class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {}; |
| 107 | |
| 108 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 109 | auto caller = CreatePeerConnection(); |
| 110 | auto callee = CreatePeerConnection(); |
| 111 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 112 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"))); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 113 | ASSERT_TRUE( |
| 114 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 115 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 116 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 117 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 118 | // TODO(hbos): When "no stream" is handled correctly we would expect |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 119 | // |add_track_events_[0].streams| to be empty. https://crbug.com/webrtc/7933 |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 120 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 121 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 122 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 123 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 124 | } |
| 125 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 126 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 127 | auto caller = CreatePeerConnection(); |
| 128 | auto callee = CreatePeerConnection(); |
| 129 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 130 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 131 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 132 | ASSERT_TRUE( |
| 133 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 134 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 135 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 136 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 137 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 138 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 139 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->label()); |
| 140 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 141 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 142 | } |
| 143 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 144 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 145 | RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 146 | auto caller = CreatePeerConnection(); |
| 147 | auto callee = CreatePeerConnection(); |
| 148 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 149 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 150 | ASSERT_TRUE( |
| 151 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 152 | static_cast<webrtc::RTCError*>(nullptr))); |
| 153 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 154 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 155 | ASSERT_TRUE( |
| 156 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 157 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 158 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 159 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 160 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 161 | callee->observer()->remove_track_events_); |
| 162 | } |
| 163 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 164 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 165 | RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 166 | auto caller = CreatePeerConnection(); |
| 167 | auto callee = CreatePeerConnection(); |
| 168 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 169 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 170 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 171 | ASSERT_TRUE( |
| 172 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 173 | static_cast<webrtc::RTCError*>(nullptr))); |
| 174 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 175 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 176 | ASSERT_TRUE( |
| 177 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 178 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 179 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 180 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 181 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 182 | callee->observer()->remove_track_events_); |
| 183 | } |
| 184 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 185 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 186 | RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 187 | auto caller = CreatePeerConnection(); |
| 188 | auto callee = CreatePeerConnection(); |
| 189 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 190 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 191 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 192 | {kSharedStreamId}); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 193 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 194 | {kSharedStreamId}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 195 | ASSERT_TRUE( |
| 196 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 197 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 198 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 199 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 200 | |
| 201 | // Remove "audio_track1". |
| 202 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 203 | ASSERT_TRUE( |
| 204 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 205 | static_cast<webrtc::RTCError*>(nullptr))); |
| 206 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 207 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 208 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 209 | callee->observer()->add_track_events_[0].receiver}, |
| 210 | callee->observer()->remove_track_events_); |
| 211 | |
| 212 | // Remove "audio_track2". |
| 213 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 214 | ASSERT_TRUE( |
| 215 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 216 | static_cast<webrtc::RTCError*>(nullptr))); |
| 217 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 218 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 219 | callee->observer()->remove_track_events_); |
| 220 | } |
| 221 | |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 222 | // Tests that setting a remote description with sending transceivers will fire |
| 223 | // the OnTrack callback for each transceiver and setting a remote description |
| 224 | // with receive only transceivers will not call OnTrack. |
| 225 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanAddTransceiverCallsOnTrack) { |
| 226 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 227 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 228 | |
| 229 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 230 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 231 | |
| 232 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 233 | |
| 234 | ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 235 | ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 236 | EXPECT_EQ(audio_transceiver->mid(), |
| 237 | callee->pc()->GetTransceivers()[0]->mid()); |
| 238 | EXPECT_EQ(video_transceiver->mid(), |
| 239 | callee->pc()->GetTransceivers()[1]->mid()); |
| 240 | } |
| 241 | |
| 242 | // Test that doing additional offer/answer exchanges with no changes to tracks |
| 243 | // will cause no additional OnTrack calls after the tracks have been negotiated. |
| 244 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanReofferDoesNotCallOnTrack) { |
| 245 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 246 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 247 | |
| 248 | caller->AddAudioTrack("audio"); |
| 249 | callee->AddAudioTrack("audio"); |
| 250 | |
| 251 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 252 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 253 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 254 | |
| 255 | // If caller reoffers with no changes expect no additional OnTrack calls. |
| 256 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 257 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 258 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 259 | |
| 260 | // Also if callee reoffers with no changes expect no additional OnTrack calls. |
| 261 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 262 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 263 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 264 | } |
| 265 | |
| 266 | // Test that OnTrack is called when the transceiver direction changes to send |
| 267 | // the track. |
| 268 | TEST_F(PeerConnectionRtpCallbacksTest, UnifiedPlanSetDirectionCallsOnTrack) { |
| 269 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 270 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 271 | |
| 272 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 273 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 274 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 275 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 276 | EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size()); |
| 277 | |
| 278 | transceiver->SetDirection(RtpTransceiverDirection::kSendOnly); |
| 279 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 280 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 281 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 282 | |
| 283 | // If the direction changes but it is still receiving on the remote side, then |
| 284 | // OnTrack should not be fired again. |
| 285 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 286 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 287 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 288 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 289 | } |
| 290 | |
| 291 | // Test that OnTrack is called twice when a sendrecv call is started, the callee |
| 292 | // changes the direction to inactive, then changes it back to sendrecv. |
| 293 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 294 | UnifiedPlanSetDirectionHoldCallsOnTrackTwice) { |
| 295 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 296 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 297 | |
| 298 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 299 | |
| 300 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 301 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 302 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 303 | |
| 304 | // Put the call on hold by no longer receiving the track. |
| 305 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 306 | RtpTransceiverDirection::kInactive); |
| 307 | |
| 308 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 309 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 310 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 311 | |
| 312 | // Resume the call by changing the direction to recvonly. This should call |
| 313 | // OnTrack again on the callee side. |
| 314 | callee->pc()->GetTransceivers()[0]->SetDirection( |
| 315 | RtpTransceiverDirection::kRecvOnly); |
| 316 | |
| 317 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 318 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 319 | EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 320 | } |
| 321 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 322 | // These tests examine the state of the peer connection as a result of |
| 323 | // performing SetRemoteDescription(). |
| 324 | class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {}; |
| 325 | |
| 326 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) { |
| 327 | auto caller = CreatePeerConnection(); |
| 328 | auto callee = CreatePeerConnection(); |
| 329 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 330 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), {})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 331 | ASSERT_TRUE( |
| 332 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 333 | static_cast<webrtc::RTCError*>(nullptr))); |
| 334 | |
| 335 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 336 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 337 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 338 | // TODO(hbos): When "no stream" is handled correctly we would expect |
| 339 | // |receiver_added->streams()| to be empty. https://crbug.com/webrtc/7933 |
| 340 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 341 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 342 | } |
| 343 | |
| 344 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) { |
| 345 | auto caller = CreatePeerConnection(); |
| 346 | auto callee = CreatePeerConnection(); |
| 347 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 348 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 349 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 350 | ASSERT_TRUE( |
| 351 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 352 | static_cast<webrtc::RTCError*>(nullptr))); |
| 353 | |
| 354 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 355 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 356 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 357 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 358 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->label()); |
| 359 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 360 | } |
| 361 | |
| 362 | TEST_F(PeerConnectionRtpObserverTest, |
| 363 | RemoveSenderWithoutStreamRemovesReceiver) { |
| 364 | auto caller = CreatePeerConnection(); |
| 365 | auto callee = CreatePeerConnection(); |
| 366 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 367 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 368 | ASSERT_TRUE(sender); |
| 369 | ASSERT_TRUE( |
| 370 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 371 | static_cast<webrtc::RTCError*>(nullptr))); |
| 372 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 373 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 374 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 375 | ASSERT_TRUE( |
| 376 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 377 | static_cast<webrtc::RTCError*>(nullptr))); |
| 378 | |
| 379 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 380 | // Instead, the transceiver owning the receiver will become inactive. |
| 381 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 382 | } |
| 383 | |
| 384 | TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) { |
| 385 | auto caller = CreatePeerConnection(); |
| 386 | auto callee = CreatePeerConnection(); |
| 387 | |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 388 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 389 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 390 | ASSERT_TRUE(sender); |
| 391 | ASSERT_TRUE( |
| 392 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 393 | static_cast<webrtc::RTCError*>(nullptr))); |
| 394 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 395 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 396 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 397 | ASSERT_TRUE( |
| 398 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 399 | static_cast<webrtc::RTCError*>(nullptr))); |
| 400 | |
| 401 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 402 | // Instead, the transceiver owning the receiver will become inactive. |
| 403 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 404 | } |
| 405 | |
| 406 | TEST_F(PeerConnectionRtpObserverTest, |
| 407 | RemoveSenderWithSharedStreamRemovesReceiver) { |
| 408 | auto caller = CreatePeerConnection(); |
| 409 | auto callee = CreatePeerConnection(); |
| 410 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 411 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 412 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 413 | {kSharedStreamId}); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 414 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame^] | 415 | {kSharedStreamId}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 416 | ASSERT_TRUE( |
| 417 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 418 | static_cast<webrtc::RTCError*>(nullptr))); |
| 419 | |
| 420 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u); |
| 421 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1; |
| 422 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2; |
| 423 | if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") { |
| 424 | receiver1 = callee->pc()->GetReceivers()[0]; |
| 425 | receiver2 = callee->pc()->GetReceivers()[1]; |
| 426 | } else { |
| 427 | receiver1 = callee->pc()->GetReceivers()[1]; |
| 428 | receiver2 = callee->pc()->GetReceivers()[0]; |
| 429 | } |
| 430 | EXPECT_EQ("audio_track1", receiver1->track()->id()); |
| 431 | EXPECT_EQ("audio_track2", receiver2->track()->id()); |
| 432 | |
| 433 | // Remove "audio_track1". |
| 434 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
| 435 | ASSERT_TRUE( |
| 436 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 437 | static_cast<webrtc::RTCError*>(nullptr))); |
| 438 | // Only |receiver2| should remain. |
| 439 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 440 | // Instead, the transceiver owning the receiver will become inactive. |
| 441 | EXPECT_EQ( |
| 442 | std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2}, |
| 443 | callee->pc()->GetReceivers()); |
| 444 | |
| 445 | // Remove "audio_track2". |
| 446 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
| 447 | ASSERT_TRUE( |
| 448 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 449 | static_cast<webrtc::RTCError*>(nullptr))); |
| 450 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 451 | // Instead, the transceiver owning the receiver will become inactive. |
| 452 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 453 | } |
| 454 | |
| 455 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 456 | // calls and examine the state of the peer connection inside the callbacks to |
| 457 | // ensure that the second call does not occur prematurely, contaminating the |
| 458 | // state of the peer connection of the first callback. |
| 459 | TEST_F(PeerConnectionRtpObserverTest, |
| 460 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 461 | auto caller = CreatePeerConnection(); |
| 462 | auto callee = CreatePeerConnection(); |
| 463 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 464 | // Create SDP for adding a track and for removing it. This will be used in the |
| 465 | // first and second SetRemoteDescription() calls. |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 466 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 467 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
| 468 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 469 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 470 | |
| 471 | // In the first SetRemoteDescription() callback, check that we have a |
| 472 | // receiver for the track. |
| 473 | auto pc = callee->pc(); |
| 474 | bool srd1_callback_called = false; |
| 475 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 476 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 477 | srd1_callback_called = true; |
| 478 | }; |
| 479 | |
| 480 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 481 | // been removed. |
| 482 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 483 | // Instead, the transceiver owning the receiver will become inactive. |
| 484 | // https://crbug.com/webrtc/7600 |
| 485 | bool srd2_callback_called = false; |
| 486 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 487 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 488 | srd2_callback_called = true; |
| 489 | }; |
| 490 | |
| 491 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 492 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 493 | // effects of the second SetRemoteDescription() call must not have happened by |
| 494 | // the time the first callback is invoked. If it has then the receiver that is |
| 495 | // added as a result of the first SetRemoteDescription() call will already |
| 496 | // have been removed as a result of the second SetRemoteDescription() call |
| 497 | // when the first callback is invoked. |
| 498 | callee->pc()->SetRemoteDescription( |
| 499 | std::move(srd1_sdp), |
| 500 | new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback)); |
| 501 | callee->pc()->SetRemoteDescription( |
| 502 | std::move(srd2_sdp), |
| 503 | new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback)); |
| 504 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 505 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 506 | } |
| 507 | |
| 508 | // Tests for the legacy SetRemoteDescription() function signature. |
| 509 | class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {}; |
| 510 | |
| 511 | // Sanity test making sure the callback is invoked. |
| 512 | TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) { |
| 513 | auto caller = CreatePeerConnection(); |
| 514 | auto callee = CreatePeerConnection(); |
| 515 | |
| 516 | std::string error; |
| 517 | ASSERT_TRUE( |
| 518 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 519 | } |
| 520 | |
| 521 | // Verifies legacy behavior: The observer is not called if if the peer |
| 522 | // connection is destroyed because the asynchronous callback is executed in the |
| 523 | // peer connection's message handler. |
| 524 | TEST_F(PeerConnectionRtpLegacyObserverTest, |
| 525 | ObserverNotCalledIfPeerConnectionDereferenced) { |
| 526 | auto caller = CreatePeerConnection(); |
| 527 | auto callee = CreatePeerConnection(); |
| 528 | |
| 529 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
| 530 | new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>(); |
| 531 | |
| 532 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 533 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 534 | callee = nullptr; |
| 535 | rtc::Thread::Current()->ProcessMessages(0); |
| 536 | EXPECT_FALSE(observer->called()); |
| 537 | } |
| 538 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 539 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 540 | |
| 541 | // Test that by default there are no transceivers with Unified Plan. |
| 542 | TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) { |
| 543 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 544 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 545 | } |
| 546 | |
| 547 | // Test that a transceiver created with the audio kind has the correct initial |
| 548 | // properties. |
| 549 | TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) { |
| 550 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 551 | |
| 552 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 553 | EXPECT_EQ(rtc::nullopt, transceiver->mid()); |
| 554 | EXPECT_FALSE(transceiver->stopped()); |
| 555 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 556 | EXPECT_EQ(rtc::nullopt, transceiver->current_direction()); |
| 557 | } |
| 558 | |
| 559 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 560 | // and audio receiver with the receiver having a live audio track. |
| 561 | TEST_F(PeerConnectionRtpTest, |
| 562 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
| 563 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 564 | |
| 565 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 566 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 567 | |
| 568 | ASSERT_TRUE(transceiver->sender()); |
| 569 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 570 | |
| 571 | ASSERT_TRUE(transceiver->receiver()); |
| 572 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 573 | |
| 574 | auto track = transceiver->receiver()->track(); |
| 575 | ASSERT_TRUE(track); |
| 576 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 577 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 578 | } |
| 579 | |
| 580 | // Test that adding a transceiver with the video kind creates an video sender |
| 581 | // and video receiver with the receiver having a live video track. |
| 582 | TEST_F(PeerConnectionRtpTest, |
| 583 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
| 584 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 585 | |
| 586 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 587 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 588 | |
| 589 | ASSERT_TRUE(transceiver->sender()); |
| 590 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 591 | |
| 592 | ASSERT_TRUE(transceiver->receiver()); |
| 593 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 594 | |
| 595 | auto track = transceiver->receiver()->track(); |
| 596 | ASSERT_TRUE(track); |
| 597 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 598 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 599 | } |
| 600 | |
| 601 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 602 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 603 | // transceiver's receiver shows in GetReceivers(). |
| 604 | TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) { |
| 605 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 606 | |
| 607 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 608 | EXPECT_EQ( |
| 609 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 610 | caller->pc()->GetTransceivers()); |
| 611 | EXPECT_EQ( |
| 612 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 613 | transceiver->sender()}, |
| 614 | caller->pc()->GetSenders()); |
| 615 | EXPECT_EQ( |
| 616 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 617 | transceiver->receiver()}, |
| 618 | caller->pc()->GetReceivers()); |
| 619 | } |
| 620 | |
| 621 | // Test that the direction passed in through the AddTransceiver init parameter |
| 622 | // is set in the returned transceiver. |
| 623 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) { |
| 624 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 625 | |
| 626 | RtpTransceiverInit init; |
| 627 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 628 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 629 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 630 | } |
| 631 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 632 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 633 | // its sender's track set to the passed-in track. |
| 634 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 635 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 636 | |
| 637 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 638 | auto transceiver = caller->AddTransceiver(audio_track); |
| 639 | |
| 640 | auto sender = transceiver->sender(); |
| 641 | ASSERT_TRUE(sender->track()); |
| 642 | EXPECT_EQ(audio_track, sender->track()); |
| 643 | |
| 644 | auto receiver = transceiver->receiver(); |
| 645 | ASSERT_TRUE(receiver->track()); |
| 646 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 647 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 648 | receiver->track()->state()); |
| 649 | } |
| 650 | |
| 651 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 652 | // transceivers, senders with the same track. |
| 653 | TEST_F(PeerConnectionRtpTest, |
| 654 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
| 655 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 656 | |
| 657 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 658 | |
| 659 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 660 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 661 | |
| 662 | EXPECT_NE(transceiver1, transceiver2); |
| 663 | |
| 664 | auto sender1 = transceiver1->sender(); |
| 665 | auto sender2 = transceiver2->sender(); |
| 666 | EXPECT_NE(sender1, sender2); |
| 667 | EXPECT_EQ(audio_track, sender1->track()); |
| 668 | EXPECT_EQ(audio_track, sender2->track()); |
| 669 | |
| 670 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 671 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 672 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 673 | UnorderedElementsAre(sender1, sender2)); |
| 674 | } |
| 675 | |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 676 | // RtpTransceiver error handling tests. |
| 677 | |
| 678 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) { |
| 679 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 680 | |
| 681 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 682 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 683 | } |
| 684 | |
| 685 | TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) { |
| 686 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 687 | |
| 688 | caller->pc()->Close(); |
| 689 | } |
| 690 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 691 | // Unified Plan AddTrack tests. |
| 692 | |
| 693 | class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {}; |
| 694 | |
| 695 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 696 | // track. |
| 697 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) { |
| 698 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 699 | |
| 700 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 701 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 702 | ASSERT_TRUE(sender); |
| 703 | |
| 704 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 705 | EXPECT_EQ(audio_track, sender->track()); |
| 706 | } |
| 707 | |
| 708 | // Test that adding a video track creates a new video RtpSender with the given |
| 709 | // track. |
| 710 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) { |
| 711 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 712 | |
| 713 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 714 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 715 | ASSERT_TRUE(sender); |
| 716 | |
| 717 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 718 | EXPECT_EQ(video_track, sender->track()); |
| 719 | } |
| 720 | |
| 721 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 722 | // with the sender that AddTrack returns and in the sendrecv direction. |
| 723 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) { |
| 724 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 725 | |
| 726 | auto sender = caller->AddAudioTrack("a"); |
| 727 | ASSERT_TRUE(sender); |
| 728 | |
| 729 | auto transceivers = caller->pc()->GetTransceivers(); |
| 730 | ASSERT_EQ(1u, transceivers.size()); |
| 731 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 732 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 733 | } |
| 734 | |
| 735 | // Test that if a transceiver of the same type but no track had been added to |
| 736 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 737 | // is the transceiver's sender and the sender's track is the newly-added track. |
| 738 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) { |
| 739 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 740 | |
| 741 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 742 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 743 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 744 | ASSERT_TRUE(sender); |
| 745 | |
| 746 | auto transceivers = caller->pc()->GetTransceivers(); |
| 747 | ASSERT_EQ(1u, transceivers.size()); |
| 748 | EXPECT_EQ(transceiver, transceivers[0]); |
| 749 | EXPECT_EQ(sender, transceiver->sender()); |
| 750 | EXPECT_EQ(audio_track, sender->track()); |
| 751 | } |
| 752 | |
| 753 | // Test that adding two tracks to a new PeerConnection creates two |
| 754 | // RtpTransceivers in the same order. |
| 755 | TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) { |
| 756 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 757 | |
| 758 | auto sender1 = caller->AddAudioTrack("a"); |
| 759 | auto sender2 = caller->AddVideoTrack("v"); |
| 760 | ASSERT_TRUE(sender2); |
| 761 | |
| 762 | auto transceivers = caller->pc()->GetTransceivers(); |
| 763 | ASSERT_EQ(2u, transceivers.size()); |
| 764 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 765 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 766 | } |
| 767 | |
| 768 | // Test that if there are multiple transceivers with no sending track then a |
| 769 | // later call to AddTrack will use the one of the same type as the newly-added |
| 770 | // track. |
| 771 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) { |
| 772 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 773 | |
| 774 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 775 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 776 | auto sender = caller->AddVideoTrack("v"); |
| 777 | |
| 778 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 779 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 780 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 781 | } |
| 782 | |
| 783 | // Test that if the only transceivers that do not have a sending track have a |
| 784 | // different type from the added track, then AddTrack will create a new |
| 785 | // transceiver for the track. |
| 786 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 787 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
| 788 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 789 | |
| 790 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 791 | auto sender = caller->AddVideoTrack("v"); |
| 792 | |
| 793 | auto transceivers = caller->pc()->GetTransceivers(); |
| 794 | ASSERT_EQ(2u, transceivers.size()); |
| 795 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 796 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 797 | } |
| 798 | |
| 799 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 800 | // are available. |
| 801 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 802 | AddTrackReusesFirstMatchingTransceiver) { |
| 803 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 804 | |
| 805 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 806 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 807 | auto sender = caller->AddAudioTrack("a"); |
| 808 | |
| 809 | auto transceivers = caller->pc()->GetTransceivers(); |
| 810 | ASSERT_EQ(2u, transceivers.size()); |
| 811 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 812 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 813 | } |
| 814 | |
| 815 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 816 | // direction from inactive to sendonly. |
| 817 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 818 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
| 819 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 820 | |
| 821 | RtpTransceiverInit init; |
| 822 | init.direction = RtpTransceiverDirection::kInactive; |
| 823 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 824 | |
| 825 | caller->observer()->clear_negotiation_needed(); |
| 826 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 827 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 828 | |
| 829 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 830 | } |
| 831 | |
| 832 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 833 | // direction from recvonly to sendrecv. |
| 834 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 835 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
| 836 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 837 | |
| 838 | RtpTransceiverInit init; |
| 839 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 840 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 841 | |
| 842 | caller->observer()->clear_negotiation_needed(); |
| 843 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 844 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 845 | |
| 846 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 847 | } |
| 848 | |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 849 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackCreatesSenderWithTrackId) { |
| 850 | const std::string kTrackId = "audio_track"; |
| 851 | |
| 852 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 853 | |
| 854 | auto audio_track = caller->CreateAudioTrack(kTrackId); |
| 855 | auto sender = caller->AddTrack(audio_track); |
| 856 | |
| 857 | EXPECT_EQ(kTrackId, sender->id()); |
| 858 | } |
| 859 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 860 | // Unified Plan AddTrack error handling. |
| 861 | |
| 862 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) { |
| 863 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 864 | |
| 865 | auto audio_track = caller->CreateAudioTrack("a"); |
| 866 | caller->pc()->Close(); |
| 867 | |
| 868 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 869 | auto result = caller->pc() |
| 870 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 871 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 872 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 873 | } |
| 874 | |
| 875 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) { |
| 876 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 877 | |
| 878 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 879 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 880 | |
| 881 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 882 | auto result = caller->pc() |
| 883 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 884 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 885 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 886 | } |
| 887 | |
| 888 | // Unified Plan RemoveTrack tests. |
| 889 | |
| 890 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 891 | // clears the sender's track. |
| 892 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) { |
| 893 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 894 | |
| 895 | auto sender = caller->AddAudioTrack("a"); |
| 896 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 897 | |
| 898 | EXPECT_FALSE(sender->track()); |
| 899 | } |
| 900 | |
| 901 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 902 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
| 903 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 904 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
| 905 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 906 | |
| 907 | RtpTransceiverInit init; |
| 908 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 909 | auto transceiver = |
| 910 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 911 | |
| 912 | caller->observer()->clear_negotiation_needed(); |
| 913 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 914 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 915 | |
| 916 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
| 917 | EXPECT_TRUE(caller->observer()->renegotiation_needed_); |
| 918 | } |
| 919 | |
| 920 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 921 | // in the sendonly direction changes the transceiver's direction to inactive. |
| 922 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 923 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
| 924 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 925 | |
| 926 | RtpTransceiverInit init; |
| 927 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 928 | auto transceiver = |
| 929 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 930 | |
| 931 | caller->observer()->clear_negotiation_needed(); |
| 932 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 933 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 934 | |
| 935 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 936 | } |
| 937 | |
| 938 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 939 | // no change in state. |
| 940 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 941 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 942 | |
| 943 | auto sender = caller->AddAudioTrack("a"); |
| 944 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 945 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 946 | |
| 947 | caller->observer()->clear_negotiation_needed(); |
| 948 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 949 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 950 | |
| 951 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 952 | } |
| 953 | |
| 954 | // Unified Plan RemoveTrack error handling. |
| 955 | |
| 956 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) { |
| 957 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 958 | |
| 959 | auto sender = caller->AddAudioTrack("a"); |
| 960 | caller->pc()->Close(); |
| 961 | |
| 962 | caller->observer()->clear_negotiation_needed(); |
| 963 | EXPECT_FALSE(caller->pc()->RemoveTrack(sender)); |
| 964 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 965 | } |
| 966 | |
| 967 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 968 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
| 969 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 970 | |
| 971 | auto sender = caller->AddAudioTrack("a"); |
| 972 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 973 | |
| 974 | caller->observer()->clear_negotiation_needed(); |
| 975 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 976 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 977 | } |
| 978 | |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 979 | // Test that OnRenegotiationNeeded is fired if SetDirection is called on an |
| 980 | // active RtpTransceiver with a new direction. |
| 981 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 982 | RenegotiationNeededAfterTransceiverSetDirection) { |
| 983 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 984 | |
| 985 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 986 | |
| 987 | caller->observer()->clear_negotiation_needed(); |
| 988 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 989 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 990 | } |
| 991 | |
| 992 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on an |
| 993 | // active RtpTransceiver with current direction. |
| 994 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 995 | NoRenegotiationNeededAfterTransceiverSetSameDirection) { |
| 996 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 997 | |
| 998 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 999 | |
| 1000 | caller->observer()->clear_negotiation_needed(); |
| 1001 | transceiver->SetDirection(transceiver->direction()); |
| 1002 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1003 | } |
| 1004 | |
| 1005 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on a |
| 1006 | // stopped RtpTransceiver. |
| 1007 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 1008 | NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) { |
| 1009 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1010 | |
| 1011 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1012 | transceiver->Stop(); |
| 1013 | |
| 1014 | caller->observer()->clear_negotiation_needed(); |
| 1015 | transceiver->SetDirection(RtpTransceiverDirection::kInactive); |
| 1016 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 1017 | } |
| 1018 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1019 | // Test MSID signaling between Unified Plan and Plan B endpoints. There are two |
| 1020 | // options for this kind of signaling: media section based (a=msid) and ssrc |
| 1021 | // based (a=ssrc MSID). While JSEP only specifies media section MSID signaling, |
| 1022 | // we want to ensure compatibility with older Plan B endpoints that might expect |
| 1023 | // ssrc based MSID signaling. Thus we test here that Unified Plan offers both |
| 1024 | // types but answers with the same type as the offer. |
| 1025 | |
| 1026 | class PeerConnectionMsidSignalingTest : public PeerConnectionRtpTest {}; |
| 1027 | |
| 1028 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) { |
| 1029 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1030 | caller->AddAudioTrack("caller_audio"); |
| 1031 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1032 | callee->AddAudioTrack("callee_audio"); |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 1033 | auto caller_observer = |
| 1034 | new rtc::RefCountedObject<webrtc::FakeMetricsObserver>(); |
| 1035 | caller->pc()->RegisterUMAObserver(caller_observer); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1036 | |
| 1037 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1038 | |
| 1039 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1040 | auto* offer = callee->pc()->remote_description(); |
| 1041 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1042 | cricket::kMsidSignalingSsrcAttribute), |
| 1043 | offer->description()->msid_signaling()); |
| 1044 | |
| 1045 | // Answer should have had only a=msid lines. |
| 1046 | auto* answer = caller->pc()->remote_description(); |
| 1047 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1048 | answer->description()->msid_signaling()); |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 1049 | // Check that this is counted correctly |
| 1050 | EXPECT_EQ(1, caller_observer->GetEnumCounter( |
| 1051 | webrtc::kEnumCounterSdpSemanticNegotiated, |
| 1052 | webrtc::kSdpSemanticNegotiatedUnifiedPlan)); |
| 1053 | EXPECT_EQ(0, caller_observer->GetEnumCounter( |
| 1054 | webrtc::kEnumCounterSdpSemanticNegotiated, |
| 1055 | webrtc::kSdpSemanticNegotiatedNone)); |
| 1056 | EXPECT_EQ(0, caller_observer->GetEnumCounter( |
| 1057 | webrtc::kEnumCounterSdpSemanticNegotiated, |
| 1058 | webrtc::kSdpSemanticNegotiatedPlanB)); |
| 1059 | EXPECT_EQ(0, caller_observer->GetEnumCounter( |
| 1060 | webrtc::kEnumCounterSdpSemanticNegotiated, |
| 1061 | webrtc::kSdpSemanticNegotiatedMixed)); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1062 | } |
| 1063 | |
| 1064 | TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) { |
| 1065 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1066 | caller->AddAudioTrack("caller_audio"); |
| 1067 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1068 | callee->AddAudioTrack("callee_audio"); |
| 1069 | |
| 1070 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1071 | |
| 1072 | // Offer should have only a=ssrc MSID lines. |
| 1073 | auto* offer = callee->pc()->remote_description(); |
| 1074 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1075 | offer->description()->msid_signaling()); |
| 1076 | |
| 1077 | // Answer should have only a=ssrc MSID lines to match the offer. |
| 1078 | auto* answer = caller->pc()->remote_description(); |
| 1079 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1080 | answer->description()->msid_signaling()); |
| 1081 | } |
| 1082 | |
| 1083 | TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) { |
| 1084 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1085 | caller->AddAudioTrack("caller_audio"); |
| 1086 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1087 | callee->AddAudioTrack("callee_audio"); |
| 1088 | |
| 1089 | auto offer = caller->CreateOffer(); |
| 1090 | // Simulate a pure Unified Plan offerer by setting the MSID signaling to media |
| 1091 | // section only. |
| 1092 | offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection); |
| 1093 | |
| 1094 | ASSERT_TRUE( |
| 1095 | caller->SetLocalDescription(CloneSessionDescription(offer.get()))); |
| 1096 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
| 1097 | |
| 1098 | // Answer should have only a=msid to match the offer. |
| 1099 | auto answer = callee->CreateAnswer(); |
| 1100 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1101 | answer->description()->msid_signaling()); |
| 1102 | } |
| 1103 | |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1104 | // Sender setups in a call. |
| 1105 | |
| 1106 | class PeerConnectionSenderTest : public PeerConnectionRtpTest {}; |
| 1107 | |
| 1108 | TEST_F(PeerConnectionSenderTest, CreateTwoSendersWithSameTrack) { |
| 1109 | auto caller = CreatePeerConnection(); |
| 1110 | auto callee = CreatePeerConnection(); |
| 1111 | |
| 1112 | auto track = caller->CreateAudioTrack("audio_track"); |
| 1113 | auto sender1 = caller->AddTrack(track); |
| 1114 | ASSERT_TRUE(sender1); |
| 1115 | // We need to temporarily reset the track for the subsequent AddTrack() to |
| 1116 | // succeed. |
| 1117 | EXPECT_TRUE(sender1->SetTrack(nullptr)); |
| 1118 | auto sender2 = caller->AddTrack(track); |
| 1119 | EXPECT_TRUE(sender2); |
| 1120 | EXPECT_TRUE(sender1->SetTrack(track)); |
| 1121 | |
| 1122 | // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should |
| 1123 | // return true, and doing |callee->SetRemoteDescription()| should work. |
| 1124 | EXPECT_FALSE(caller->CreateOfferAndSetAsLocal()); |
| 1125 | } |
| 1126 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1127 | } // namespace webrtc |