Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 1 | ==== |
| 2 | YAPF |
| 3 | ==== |
| 4 | |
Bill Wendling | 19c44d0 | 2015-04-07 23:48:05 -0700 | [diff] [blame] | 5 | .. image:: https://badge.fury.io/py/yapf.svg |
Ronald Eddy Jr | 808d7d2 | 2017-12-25 22:38:41 -0800 | [diff] [blame] | 6 | :target: https://badge.fury.io/py/yapf |
Bill Wendling | 19c44d0 | 2015-04-07 23:48:05 -0700 | [diff] [blame] | 7 | :alt: PyPI version |
| 8 | |
Bill Wendling | fb8ab38 | 2015-03-18 20:24:14 -0700 | [diff] [blame] | 9 | .. image:: https://travis-ci.org/google/yapf.svg?branch=master |
| 10 | :target: https://travis-ci.org/google/yapf |
| 11 | :alt: Build status |
| 12 | |
Bill Wendling | 14ac881 | 2015-04-05 02:47:32 -0700 | [diff] [blame] | 13 | .. image:: https://coveralls.io/repos/google/yapf/badge.svg?branch=master |
| 14 | :target: https://coveralls.io/r/google/yapf?branch=master |
| 15 | :alt: Coverage status |
| 16 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 17 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 18 | Introduction |
| 19 | ============ |
| 20 | |
Bill Wendling | 5632e67 | 2015-03-29 17:06:07 -0700 | [diff] [blame] | 21 | Most of the current formatters for Python --- e.g., autopep8, and pep8ify --- |
| 22 | are made to remove lint errors from code. This has some obvious limitations. |
| 23 | For instance, code that conforms to the PEP 8 guidelines may not be |
| 24 | reformatted. But it doesn't mean that the code looks good. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 25 | |
| 26 | YAPF takes a different approach. It's based off of 'clang-format', developed by |
| 27 | Daniel Jasper. In essence, the algorithm takes the code and reformats it to the |
| 28 | best formatting that conforms to the style guide, even if the original code |
Peter Bengtsson | 1c60ad7 | 2015-03-24 20:05:39 -0700 | [diff] [blame] | 29 | didn't violate the style guide. The idea is also similar to the 'gofmt' tool for |
Eli Bendersky | 07072f8 | 2015-03-23 06:41:14 -0700 | [diff] [blame] | 30 | the Go programming language: end all holy wars about formatting - if the whole |
Samuel Dion-Girardeau | 5ae6349 | 2016-09-08 21:01:20 -0400 | [diff] [blame] | 31 | codebase of a project is simply piped through YAPF whenever modifications are |
Eli Bendersky | 07072f8 | 2015-03-23 06:41:14 -0700 | [diff] [blame] | 32 | made, the style remains consistent throughout the project and there's no point |
| 33 | arguing about style in every code review. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 34 | |
| 35 | The ultimate goal is that the code YAPF produces is as good as the code that a |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 36 | programmer would write if they were following the style guide. It takes away |
| 37 | some of the drudgery of maintaining your code. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 38 | |
José Padilla | 45aea8e | 2018-01-16 12:26:33 -0500 | [diff] [blame] | 39 | Try out YAPF with this `online demo <https://yapf.now.sh>`_. |
José Padilla | 2774c1b | 2017-12-19 16:59:52 -0500 | [diff] [blame] | 40 | |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 41 | .. footer:: |
Bill Wendling | 52e0411 | 2015-03-18 20:42:26 -0700 | [diff] [blame] | 42 | |
| 43 | YAPF is not an official Google product (experimental or otherwise), it is |
| 44 | just code that happens to be owned by Google. |
| 45 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 46 | .. contents:: |
| 47 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 48 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 49 | Installation |
| 50 | ============ |
| 51 | |
Bill Wendling | 6e8ca7b | 2015-10-25 01:16:43 -0700 | [diff] [blame] | 52 | To install YAPF from PyPI: |
| 53 | |
Bill Wendling | 4f96aab | 2016-07-16 15:52:51 -0700 | [diff] [blame] | 54 | .. code-block:: |
Eli Bendersky | 8a36536 | 2015-03-25 18:42:22 -0700 | [diff] [blame] | 55 | |
Eli Bendersky | e0e83c1 | 2015-04-06 20:23:30 -0700 | [diff] [blame] | 56 | $ pip install yapf |
| 57 | |
Diogo de Campos | 2f246c0 | 2016-10-06 14:04:38 +0200 | [diff] [blame] | 58 | (optional) If you are using Python 2.7 and want to enable multiprocessing: |
| 59 | |
| 60 | .. code-block:: |
| 61 | |
| 62 | $ pip install futures |
| 63 | |
Eli Bendersky | e0e83c1 | 2015-04-06 20:23:30 -0700 | [diff] [blame] | 64 | YAPF is still considered in "alpha" stage, and the released version may change |
| 65 | often; therefore, the best way to keep up-to-date with the latest development |
| 66 | is to clone this repository. |
| 67 | |
| 68 | Note that if you intend to use YAPF as a command-line tool rather than as a |
| 69 | library, installation is not necessary. YAPF supports being run as a directory |
| 70 | by the Python interpreter. If you cloned/unzipped YAPF into ``DIR``, it's |
Bill Wendling | 6e8ca7b | 2015-10-25 01:16:43 -0700 | [diff] [blame] | 71 | possible to run: |
| 72 | |
Bill Wendling | 4f96aab | 2016-07-16 15:52:51 -0700 | [diff] [blame] | 73 | .. code-block:: |
Eli Bendersky | 07072f8 | 2015-03-23 06:41:14 -0700 | [diff] [blame] | 74 | |
Eli Bendersky | b3678b3 | 2015-03-25 14:16:11 -0700 | [diff] [blame] | 75 | $ PYTHONPATH=DIR python DIR/yapf [options] ... |
Eli Bendersky | 07072f8 | 2015-03-23 06:41:14 -0700 | [diff] [blame] | 76 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 77 | |
Eli Bendersky | 5eb8823 | 2015-03-27 06:27:11 -0700 | [diff] [blame] | 78 | Python versions |
| 79 | =============== |
| 80 | |
Bill Wendling | fe6460f | 2018-01-26 15:08:07 -0800 | [diff] [blame] | 81 | YAPF supports Python 2.7 and 3.6.4+. (Note that some Python 3 features may fail |
| 82 | to parse with Python versions before 3.6.4.) |
Eli Bendersky | 5eb8823 | 2015-03-27 06:27:11 -0700 | [diff] [blame] | 83 | |
| 84 | YAPF requires the code it formats to be valid Python for the version YAPF itself |
| 85 | runs under. Therefore, if you format Python 3 code with YAPF, run YAPF itself |
| 86 | under Python 3 (and similarly for Python 2). |
| 87 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 88 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 89 | Usage |
| 90 | ===== |
| 91 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 92 | Options:: |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 93 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 94 | usage: yapf [-h] [-v] [-d | -i] [-r | -l START-END] [-e PATTERN] |
Diogo de Campos | 2f246c0 | 2016-10-06 14:04:38 +0200 | [diff] [blame] | 95 | [--style STYLE] [--style-help] [--no-local-style] [-p] |
Bill Wendling | 7bfc0a9 | 2017-10-16 03:22:19 -0700 | [diff] [blame] | 96 | [-vv] |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 97 | [files [files ...]] |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 98 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 99 | Formatter for Python code. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 100 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 101 | positional arguments: |
| 102 | files |
| 103 | |
| 104 | optional arguments: |
| 105 | -h, --help show this help message and exit |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 106 | -v, --version show version number and exit |
| 107 | -d, --diff print the diff for the fixed source |
| 108 | -i, --in-place make changes to files in place |
| 109 | -r, --recursive run recursively over directories |
| 110 | -l START-END, --lines START-END |
| 111 | range of lines to reformat, one-based |
| 112 | -e PATTERN, --exclude PATTERN |
| 113 | patterns for files to exclude from formatting |
Eli Bendersky | 83d2bd0 | 2015-03-23 06:33:48 -0700 | [diff] [blame] | 114 | --style STYLE specify formatting style: either a style name (for |
| 115 | example "pep8" or "google"), or the name of a file |
Sam Clegg | 5170c3a | 2015-04-16 12:18:58 -0700 | [diff] [blame] | 116 | with style settings. The default is pep8 unless a |
Peter Ludemann | 827260c | 2017-12-20 19:54:27 -0800 | [diff] [blame] | 117 | .style.yapf or setup.cfg file located in the same |
| 118 | directory as the source or one of its parent |
| 119 | directories (for stdin, the current directory is |
| 120 | used). |
Bill Wendling | 7bfc0a9 | 2017-10-16 03:22:19 -0700 | [diff] [blame] | 121 | --style-help show style settings and exit; this output can be saved |
| 122 | to .style.yapf to make your settings permanent |
| 123 | --no-local-style don't search for local style definition |
Diogo de Campos | 2f246c0 | 2016-10-06 14:04:38 +0200 | [diff] [blame] | 124 | -p, --parallel Run yapf in parallel when formatting multiple files. |
| 125 | Requires concurrent.futures in Python 2.X |
Bill Wendling | 7bfc0a9 | 2017-10-16 03:22:19 -0700 | [diff] [blame] | 126 | -vv, --verbose Print out file names while processing |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 127 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 128 | |
Eli Bendersky | 83d2bd0 | 2015-03-23 06:33:48 -0700 | [diff] [blame] | 129 | Formatting style |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 130 | ================ |
Eli Bendersky | 83d2bd0 | 2015-03-23 06:33:48 -0700 | [diff] [blame] | 131 | |
| 132 | The formatting style used by YAPF is configurable and there are many "knobs" |
| 133 | that can be used to tune how YAPF does formatting. See the ``style.py`` module |
| 134 | for the full list. |
| 135 | |
Bill Wendling | c016779 | 2015-04-02 01:58:39 -0700 | [diff] [blame] | 136 | To control the style, run YAPF with the ``--style`` argument. It accepts one of |
| 137 | the predefined styles (e.g., ``pep8`` or ``google``), a path to a configuration |
| 138 | file that specifies the desired style, or a dictionary of key/value pairs. |
| 139 | |
| 140 | The config file is a simple listing of (case-insensitive) ``key = value`` pairs |
Bill Wendling | 6e8ca7b | 2015-10-25 01:16:43 -0700 | [diff] [blame] | 141 | with a ``[style]`` heading. For example: |
| 142 | |
Bill Wendling | 4f96aab | 2016-07-16 15:52:51 -0700 | [diff] [blame] | 143 | .. code-block:: |
Eli Bendersky | 83d2bd0 | 2015-03-23 06:33:48 -0700 | [diff] [blame] | 144 | |
| 145 | [style] |
| 146 | based_on_style = pep8 |
| 147 | spaces_before_comment = 4 |
| 148 | split_before_logical_operator = true |
| 149 | |
| 150 | The ``based_on_style`` setting determines which of the predefined styles this |
| 151 | custom style is based on (think of it like subclassing). |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 152 | |
Bill Wendling | c016779 | 2015-04-02 01:58:39 -0700 | [diff] [blame] | 153 | It's also possible to do the same on the command line with a dictionary. For |
Bill Wendling | 6e8ca7b | 2015-10-25 01:16:43 -0700 | [diff] [blame] | 154 | example: |
| 155 | |
Bill Wendling | 4f96aab | 2016-07-16 15:52:51 -0700 | [diff] [blame] | 156 | .. code-block:: |
Bill Wendling | c016779 | 2015-04-02 01:58:39 -0700 | [diff] [blame] | 157 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 158 | --style='{based_on_style: chromium, indent_width: 4}' |
Bill Wendling | c016779 | 2015-04-02 01:58:39 -0700 | [diff] [blame] | 159 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 160 | This will take the ``chromium`` base style and modify it to have four space |
Bill Wendling | c016779 | 2015-04-02 01:58:39 -0700 | [diff] [blame] | 161 | indentations. |
| 162 | |
Bill Wendling | 169790e | 2015-10-25 03:13:13 -0700 | [diff] [blame] | 163 | YAPF will search for the formatting style in the following manner: |
| 164 | |
| 165 | 1. Specified on the command line |
Joshua Moravec | d8d15af | 2015-11-05 13:16:46 -0600 | [diff] [blame] | 166 | 2. In the `[style]` section of a `.style.yapf` file in either the current |
Bill Wendling | 169790e | 2015-10-25 03:13:13 -0700 | [diff] [blame] | 167 | directory or one of its parent directories. |
Bill Wendling | 821a36f | 2016-07-13 23:02:16 -0700 | [diff] [blame] | 168 | 3. In the `[yapf]` section of a `setup.cfg` file in either the current |
Bill Wendling | 169790e | 2015-10-25 03:13:13 -0700 | [diff] [blame] | 169 | directory or one of its parent directories. |
| 170 | 4. In the `~/.config/yapf/style` file in your home directory. |
| 171 | |
| 172 | If none of those files are found, the default style is used (PEP8). |
| 173 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 174 | |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 175 | Example |
| 176 | ======= |
| 177 | |
Sam Clegg | 4357fa3 | 2015-04-08 12:21:46 -0700 | [diff] [blame] | 178 | An example of the type of formatting that YAPF can do, it will take this ugly |
| 179 | code: |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 180 | |
| 181 | .. code-block:: python |
| 182 | |
| 183 | x = { 'a':37,'b':42, |
| 184 | |
| 185 | 'c':927} |
| 186 | |
| 187 | y = 'hello ''world' |
| 188 | z = 'hello '+'world' |
| 189 | a = 'hello {}'.format('world') |
| 190 | class foo ( object ): |
| 191 | def f (self ): |
| 192 | return 37*-+2 |
| 193 | def g(self, x,y=42): |
| 194 | return y |
| 195 | def f ( a ) : |
| 196 | return 37+-+a[42-x : y**3] |
| 197 | |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 198 | and reformat it into: |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 199 | |
| 200 | .. code-block:: python |
| 201 | |
| 202 | x = {'a': 37, 'b': 42, 'c': 927} |
| 203 | |
| 204 | y = 'hello ' 'world' |
| 205 | z = 'hello ' + 'world' |
| 206 | a = 'hello {}'.format('world') |
| 207 | |
| 208 | |
| 209 | class foo(object): |
Bill Wendling | 5632e67 | 2015-03-29 17:06:07 -0700 | [diff] [blame] | 210 | def f(self): |
| 211 | return 37 * -+2 |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 212 | |
Bill Wendling | 5632e67 | 2015-03-29 17:06:07 -0700 | [diff] [blame] | 213 | def g(self, x, y=42): |
| 214 | return y |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 215 | |
| 216 | |
| 217 | def f(a): |
Bill Wendling | 8d8f512 | 2015-10-16 11:46:23 -0700 | [diff] [blame] | 218 | return 37 + -+a[42 - x:y**3] |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 219 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 220 | |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 221 | Example as a module |
| 222 | =================== |
| 223 | |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 224 | The two main APIs for calling yapf are ``FormatCode`` and ``FormatFile``, these |
| 225 | share several arguments which are described below: |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 226 | |
| 227 | .. code-block:: python |
| 228 | |
srinivasanramaraju | cfa7ead | 2017-02-14 00:06:58 -0800 | [diff] [blame] | 229 | >>> from yapf.yapflib.yapf_api import FormatCode # reformat a string of code |
Łukasz Langa | 9408987 | 2015-09-22 16:02:26 -0700 | [diff] [blame] | 230 | |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 231 | >>> FormatCode("f ( a = 1, b = 2 )") |
| 232 | 'f(a=1, b=2)\n' |
| 233 | |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 234 | A ``style_config`` argument: Either a style name or a path to a file that contains |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 235 | formatting style settings. If None is specified, use the default style |
| 236 | as set in ``style.DEFAULT_STYLE_FACTORY``. |
| 237 | |
| 238 | .. code-block:: python |
| 239 | |
| 240 | >>> FormatCode("def g():\n return True", style_config='pep8') |
| 241 | 'def g():\n return True\n' |
| 242 | |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 243 | A ``lines`` argument: A list of tuples of lines (ints), [start, end], |
| 244 | that we want to format. The lines are 1-based indexed. It can be used by |
| 245 | third-party code (e.g., IDEs) when reformatting a snippet of code rather |
| 246 | than a whole file. |
| 247 | |
| 248 | .. code-block:: python |
| 249 | |
| 250 | >>> FormatCode("def g( ):\n a=1\n b = 2\n return a==b", lines=[(1, 1), (2, 3)]) |
| 251 | 'def g():\n a = 1\n b = 2\n return a==b\n' |
| 252 | |
| 253 | A ``print_diff`` (bool): Instead of returning the reformatted source, return a |
| 254 | diff that turns the formatted source into reformatter source. |
| 255 | |
| 256 | .. code-block:: python |
| 257 | |
| 258 | >>> print(FormatCode("a==b", filename="foo.py", print_diff=True)) |
Bill Wendling | b8645ea | 2015-06-30 22:27:56 -0700 | [diff] [blame] | 259 | --- foo.py (original) |
| 260 | +++ foo.py (reformatted) |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 261 | @@ -1 +1 @@ |
| 262 | -a==b |
| 263 | +a == b |
| 264 | |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 265 | Note: the ``filename`` argument for ``FormatCode`` is what is inserted into |
| 266 | the diff, the default is ``<unknown>``. |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 267 | |
| 268 | ``FormatFile`` returns reformatted code from the passed file along with its encoding: |
| 269 | |
| 270 | .. code-block:: python |
| 271 | |
srinivasanramaraju | cfa7ead | 2017-02-14 00:06:58 -0800 | [diff] [blame] | 272 | >>> from yapf.yapflib.yapf_api import FormatFile # reformat a file |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 273 | |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 274 | >>> print(open("foo.py").read()) # contents of file |
| 275 | a==b |
| 276 | |
| 277 | >>> FormatFile("foo.py") |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 278 | ('a == b\n', 'utf-8') |
| 279 | |
Bill Wendling | cfbb124 | 2015-09-20 12:08:18 -0700 | [diff] [blame] | 280 | The ``in-place`` argument saves the reformatted code back to the file: |
Andy Hayden | 4af7168 | 2015-06-17 15:42:43 -0700 | [diff] [blame] | 281 | |
| 282 | .. code-block:: python |
| 283 | |
| 284 | >>> FormatFile("foo.py", in_place=True) |
| 285 | (None, 'utf-8') |
| 286 | |
| 287 | >>> print(open("foo.py").read()) # contents of file (now fixed) |
| 288 | a == b |
| 289 | |
Andy Hayden | a00a6bf | 2015-06-15 18:47:41 -0700 | [diff] [blame] | 290 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 291 | Knobs |
| 292 | ===== |
| 293 | |
| 294 | ``ALIGN_CLOSING_BRACKET_WITH_VISUAL_INDENT`` |
| 295 | Align closing bracket with visual indentation. |
| 296 | |
Bill Wendling | 996c3ee | 2016-05-25 23:52:24 -0700 | [diff] [blame] | 297 | ``ALLOW_MULTILINE_LAMBDAS`` |
| 298 | Allow lambdas to be formatted on more than one line. |
| 299 | |
Bill Wendling | 8d32136 | 2017-02-05 18:29:26 -0800 | [diff] [blame] | 300 | ``ALLOW_MULTILINE_DICTIONARY_KEYS`` |
| 301 | Allow dictionary keys to exist on multiple lines. For example: |
| 302 | |
| 303 | .. code-block:: python |
| 304 | |
| 305 | x = { |
| 306 | ('this is the first element of a tuple', |
| 307 | 'this is the second element of a tuple'): |
| 308 | value, |
| 309 | } |
| 310 | |
Bill Wendling | 8a3b71f | 2017-08-26 02:34:03 -0700 | [diff] [blame] | 311 | ``ALLOW_SPLIT_BEFORE_DICT_VALUE`` |
| 312 | Allow splits before the dictionary value. |
| 313 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 314 | ``BLANK_LINE_BEFORE_NESTED_CLASS_OR_DEF`` |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 315 | Insert a blank line before a ``def`` or ``class`` immediately nested within |
Bill Wendling | 996c3ee | 2016-05-25 23:52:24 -0700 | [diff] [blame] | 316 | another ``def`` or ``class``. For example: |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 317 | |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 318 | .. code-block:: python |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 319 | |
| 320 | class Foo: |
| 321 | # <------ this blank line |
| 322 | def method(): |
| 323 | pass |
| 324 | |
Bill Wendling | 9f49752 | 2017-02-04 04:39:47 -0800 | [diff] [blame] | 325 | ``BLANK_LINE_BEFORE_CLASS_DOCSTRING`` |
| 326 | Insert a blank line before a class-level docstring. |
| 327 | |
Ben Plotnick | 7e08829 | 2016-06-09 18:29:56 -0700 | [diff] [blame] | 328 | ``COALESCE_BRACKETS`` |
| 329 | Do not split consecutive brackets. Only relevant when |
| 330 | ``DEDENT_CLOSING_BRACKETS`` is set. For example: |
| 331 | |
| 332 | .. code-block:: python |
| 333 | |
| 334 | call_func_that_takes_a_dict( |
| 335 | { |
| 336 | 'key1': 'value1', |
| 337 | 'key2': 'value2', |
| 338 | } |
| 339 | ) |
| 340 | |
| 341 | would reformat to: |
| 342 | |
| 343 | .. code-block:: python |
| 344 | |
| 345 | call_func_that_takes_a_dict({ |
| 346 | 'key1': 'value1', |
| 347 | 'key2': 'value2', |
| 348 | }) |
| 349 | |
| 350 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 351 | ``COLUMN_LIMIT`` |
James Broadhead | f4dd804 | 2016-01-07 14:40:19 +0000 | [diff] [blame] | 352 | The column limit (or max line-length) |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 353 | |
| 354 | ``CONTINUATION_INDENT_WIDTH`` |
| 355 | Indent width used for line continuations. |
| 356 | |
| 357 | ``DEDENT_CLOSING_BRACKETS`` |
| 358 | Put closing brackets on a separate line, dedented, if the bracketed |
| 359 | expression can't fit in a single line. Applies to all kinds of brackets, |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 360 | including function definitions and calls. For example: |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 361 | |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 362 | .. code-block:: python |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 363 | |
| 364 | config = { |
| 365 | 'key1': 'value1', |
| 366 | 'key2': 'value2', |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 367 | } # <--- this bracket is dedented and on a separate line |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 368 | |
| 369 | time_series = self.remote_client.query_entity_counters( |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 370 | entity='dev3246.region1', |
| 371 | key='dns.query_latency_tcp', |
| 372 | transform=Transformation.AVERAGE(window=timedelta(seconds=60)), |
| 373 | start_ts=now()-timedelta(days=3), |
| 374 | end_ts=now(), |
| 375 | ) # <--- this bracket is dedented and on a separate line |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 376 | |
Bill Wendling | 0e9b321 | 2017-01-31 14:41:00 -0800 | [diff] [blame] | 377 | ``EACH_DICT_ENTRY_ON_SEPARATE_LINE`` |
| 378 | Place each dictionary entry onto its own line. |
| 379 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 380 | ``I18N_COMMENT`` |
| 381 | The regex for an internationalization comment. The presence of this comment |
| 382 | stops reformatting of that line, because the comments are required to be |
| 383 | next to the string they translate. |
| 384 | |
| 385 | ``I18N_FUNCTION_CALL`` |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 386 | The internationalization function call names. The presence of this function |
Samuel Dion-Girardeau | 5ae6349 | 2016-09-08 21:01:20 -0400 | [diff] [blame] | 387 | stops reformatting on that line, because the string it has cannot be moved |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 388 | away from the i18n comment. |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 389 | |
| 390 | ``INDENT_DICTIONARY_VALUE`` |
| 391 | Indent the dictionary value if it cannot fit on the same line as the |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 392 | dictionary key. For example: |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 393 | |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 394 | .. code-block:: python |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 395 | |
| 396 | config = { |
| 397 | 'key1': |
| 398 | 'value1', |
| 399 | 'key2': value1 + |
| 400 | value2, |
| 401 | } |
| 402 | |
| 403 | ``INDENT_WIDTH`` |
| 404 | The number of columns to use for indentation. |
| 405 | |
| 406 | ``JOIN_MULTIPLE_LINES`` |
| 407 | Join short lines into one line. E.g., single line ``if`` statements. |
| 408 | |
Bill Wendling | 9dc7908 | 2016-05-10 00:23:53 -0700 | [diff] [blame] | 409 | ``SPACES_AROUND_POWER_OPERATOR`` |
| 410 | Set to ``True`` to prefer using spaces around ``**``. |
| 411 | |
Jiri Kuncar | f14bd17 | 2017-07-21 09:45:31 +0200 | [diff] [blame] | 412 | ``NO_SPACES_AROUND_SELECTED_BINARY_OPERATORS`` |
| 413 | Do not include spaces around selected binary operators. For example: |
| 414 | |
| 415 | .. code-block:: python |
| 416 | |
| 417 | 1 + 2 * 3 - 4 / 5 |
| 418 | |
| 419 | will be formatted as follows when configured with a value ``"*,/"``: |
| 420 | |
| 421 | .. code-block:: python |
| 422 | |
| 423 | 1 + 2*3 - 4/5 |
| 424 | |
Alexander Lenz | 5fda36a | 2016-08-26 17:27:57 +0200 | [diff] [blame] | 425 | ``SPACES_AROUND_DEFAULT_OR_NAMED_ASSIGN`` |
| 426 | Set to ``True`` to prefer spaces around the assignment operator for default |
| 427 | or keyword arguments. |
| 428 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 429 | ``SPACES_BEFORE_COMMENT`` |
| 430 | The number of spaces required before a trailing comment. |
| 431 | |
Bill Wendling | 996c3ee | 2016-05-25 23:52:24 -0700 | [diff] [blame] | 432 | ``SPACE_BETWEEN_ENDING_COMMA_AND_CLOSING_BRACKET`` |
| 433 | Insert a space between the ending comma and closing bracket of a list, etc. |
| 434 | |
Bill Wendling | 982c5b3 | 2016-05-24 00:47:44 -0700 | [diff] [blame] | 435 | ``SPLIT_ARGUMENTS_WHEN_COMMA_TERMINATED`` |
| 436 | Split before arguments if the argument list is terminated by a comma. |
| 437 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 438 | ``SPLIT_BEFORE_BITWISE_OPERATOR`` |
| 439 | Set to ``True`` to prefer splitting before ``&``, ``|`` or ``^`` rather |
| 440 | than after. |
| 441 | |
Bill Wendling | 0e9b321 | 2017-01-31 14:41:00 -0800 | [diff] [blame] | 442 | ``SPLIT_BEFORE_DICT_SET_GENERATOR`` |
| 443 | Split before a dictionary or set generator (comp_for). For example, note |
| 444 | the split before the ``for``: |
| 445 | |
| 446 | .. code-block:: python |
| 447 | |
| 448 | foo = { |
| 449 | variable: 'Hello world, have a nice day!' |
| 450 | for variable in bar if variable != 42 |
| 451 | } |
| 452 | |
Bill Wendling | 6113e7e | 2017-10-09 01:11:38 -0700 | [diff] [blame] | 453 | ``SPLIT_BEFORE_EXPRESSION_AFTER_OPENING_PAREN`` |
| 454 | Split after the opening paren which surrounds an expression if it doesn't |
| 455 | fit on a single line. |
| 456 | |
Bill Wendling | 996c3ee | 2016-05-25 23:52:24 -0700 | [diff] [blame] | 457 | ``SPLIT_BEFORE_FIRST_ARGUMENT`` |
| 458 | If an argument / parameter list is going to be split, then split before the |
| 459 | first argument. |
| 460 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 461 | ``SPLIT_BEFORE_LOGICAL_OPERATOR`` |
| 462 | Set to ``True`` to prefer splitting before ``and`` or ``or`` rather than |
| 463 | after. |
| 464 | |
| 465 | ``SPLIT_BEFORE_NAMED_ASSIGNS`` |
| 466 | Split named assignments onto individual lines. |
| 467 | |
Matthew Suozzo | 4a3b633 | 2017-11-01 17:38:37 -0400 | [diff] [blame] | 468 | ``SPLIT_COMPLEX_COMPREHENSION`` |
| 469 | For list comprehensions and generator expressions with multiple clauses |
delirious-lettuce | b795f6d | 2018-01-16 20:38:46 -0700 | [diff] [blame] | 470 | (e.g multiple "for" calls, "if" filter expressions) and which need to be |
Matthew Suozzo | 4a3b633 | 2017-11-01 17:38:37 -0400 | [diff] [blame] | 471 | reflowed, split each clause onto its own line. For example: |
| 472 | |
| 473 | .. code-block:: python |
| 474 | |
| 475 | result = [ |
| 476 | a_var + b_var for a_var in xrange(1000) for b_var in xrange(1000) |
| 477 | if a_var % b_var] |
| 478 | |
| 479 | would reformat to something like: |
| 480 | |
| 481 | .. code-block:: python |
| 482 | |
| 483 | result = [ |
| 484 | a_var + b_var |
| 485 | for a_var in xrange(1000) |
| 486 | for b_var in xrange(1000) |
| 487 | if a_var % b_var] |
| 488 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 489 | ``SPLIT_PENALTY_AFTER_OPENING_BRACKET`` |
| 490 | The penalty for splitting right after the opening bracket. |
| 491 | |
| 492 | ``SPLIT_PENALTY_AFTER_UNARY_OPERATOR`` |
| 493 | The penalty for splitting the line after a unary operator. |
| 494 | |
Bill Wendling | 996c3ee | 2016-05-25 23:52:24 -0700 | [diff] [blame] | 495 | ``SPLIT_PENALTY_BEFORE_IF_EXPR`` |
| 496 | The penalty for splitting right before an ``if`` expression. |
| 497 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 498 | ``SPLIT_PENALTY_BITWISE_OPERATOR`` |
| 499 | The penalty of splitting the line around the ``&``, ``|``, and ``^`` |
| 500 | operators. |
| 501 | |
Matthew Suozzo | 3a0f6e7 | 2017-11-01 17:40:57 -0400 | [diff] [blame] | 502 | ``SPLIT_PENALTY_COMPREHENSION`` |
| 503 | The penalty for splitting a list comprehension or generator expression. |
| 504 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 505 | ``SPLIT_PENALTY_EXCESS_CHARACTER`` |
| 506 | The penalty for characters over the column limit. |
| 507 | |
| 508 | ``SPLIT_PENALTY_FOR_ADDED_LINE_SPLIT`` |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 509 | The penalty incurred by adding a line split to the unwrapped line. The more |
| 510 | line splits added the higher the penalty. |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 511 | |
| 512 | ``SPLIT_PENALTY_IMPORT_NAMES`` |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 513 | The penalty of splitting a list of ``import as`` names. For example: |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 514 | |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 515 | .. code-block:: python |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 516 | |
| 517 | from a_very_long_or_indented_module_name_yada_yad import (long_argument_1, |
| 518 | long_argument_2, |
| 519 | long_argument_3) |
| 520 | |
| 521 | would reformat to something like: |
| 522 | |
Bill Wendling | c2a9e0d | 2016-05-24 20:51:04 -0700 | [diff] [blame] | 523 | .. code-block:: python |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 524 | |
| 525 | from a_very_long_or_indented_module_name_yada_yad import ( |
| 526 | long_argument_1, long_argument_2, long_argument_3) |
| 527 | |
| 528 | ``SPLIT_PENALTY_LOGICAL_OPERATOR`` |
| 529 | The penalty of splitting the line around the ``and`` and ``or`` operators. |
| 530 | |
Dracony | e582d63 | 2016-06-05 11:48:26 +0200 | [diff] [blame] | 531 | ``USE_TABS`` |
| 532 | Use the Tab character for indentation. |
| 533 | |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 534 | (Potentially) Frequently Asked Questions |
| 535 | ======================================== |
| 536 | |
| 537 | Why does YAPF destroy my awesome formatting? |
| 538 | -------------------------------------------- |
| 539 | |
| 540 | YAPF tries very hard to get the formatting correct. But for some code, it won't |
| 541 | be as good as hand-formatting. In particular, large data literals may become |
| 542 | horribly disfigured under YAPF. |
| 543 | |
mlimber | 8af5baf | 2017-11-09 13:53:22 -0500 | [diff] [blame] | 544 | The reasons for this are manyfold. In short, YAPF is simply a tool to help |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 545 | with development. It will format things to coincide with the style guide, but |
| 546 | that may not equate with readability. |
| 547 | |
| 548 | What can be done to alleviate this situation is to indicate regions YAPF should |
| 549 | ignore when reformatting something: |
| 550 | |
| 551 | .. code-block:: python |
| 552 | |
| 553 | # yapf: disable |
| 554 | FOO = { |
| 555 | # ... some very large, complex data literal. |
| 556 | } |
| 557 | |
| 558 | BAR = [ |
| 559 | # ... another large data literal. |
| 560 | ] |
| 561 | # yapf: enable |
| 562 | |
| 563 | You can also disable formatting for a single literal like this: |
| 564 | |
| 565 | .. code-block:: python |
| 566 | |
| 567 | BAZ = { |
Scott Sanderson | eda4e26 | 2015-07-05 21:10:06 -0400 | [diff] [blame] | 568 | (1, 2, 3, 4), |
| 569 | (5, 6, 7, 8), |
| 570 | (9, 10, 11, 12), |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 571 | } # yapf: disable |
| 572 | |
Łukasz Langa | 9408987 | 2015-09-22 16:02:26 -0700 | [diff] [blame] | 573 | To preserve the nice dedented closing brackets, use the |
| 574 | ``dedent_closing_brackets`` in your style. Note that in this case all |
| 575 | brackets, including function definitions and calls, are going to use |
| 576 | that style. This provides consistency across the formatted codebase. |
| 577 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 578 | Why Not Improve Existing Tools? |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 579 | ------------------------------- |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 580 | |
| 581 | We wanted to use clang-format's reformatting algorithm. It's very powerful and |
| 582 | designed to come up with the best formatting possible. Existing tools were |
| 583 | created with different goals in mind, and would require extensive modifications |
| 584 | to convert to using clang-format's algorithm. |
| 585 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 586 | Can I Use YAPF In My Program? |
Bill Wendling | 8fb9c48 | 2015-03-29 17:32:07 -0700 | [diff] [blame] | 587 | ----------------------------- |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 588 | |
| 589 | Please do! YAPF was designed to be used as a library as well as a command line |
| 590 | tool. This means that a tool or IDE plugin is free to use YAPF. |
| 591 | |
Bill Wendling | f09121c | 2015-10-20 22:59:33 -0700 | [diff] [blame] | 592 | |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 593 | Gory Details |
| 594 | ============ |
| 595 | |
| 596 | Algorithm Design |
| 597 | ---------------- |
| 598 | |
Eli Bendersky | d08130d | 2015-03-19 05:20:46 -0700 | [diff] [blame] | 599 | The main data structure in YAPF is the ``UnwrappedLine`` object. It holds a list |
| 600 | of ``FormatToken``\s, that we would want to place on a single line if there were |
| 601 | no column limit. An exception being a comment in the middle of an expression |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 602 | statement will force the line to be formatted on more than one line. The |
Eli Bendersky | d08130d | 2015-03-19 05:20:46 -0700 | [diff] [blame] | 603 | formatter works on one ``UnwrappedLine`` object at a time. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 604 | |
Eli Bendersky | d08130d | 2015-03-19 05:20:46 -0700 | [diff] [blame] | 605 | An ``UnwrappedLine`` typically won't affect the formatting of lines before or |
| 606 | after it. There is a part of the algorithm that may join two or more |
| 607 | ``UnwrappedLine``\s into one line. For instance, an if-then statement with a |
Bill Wendling | f5e50b6 | 2015-03-28 23:38:12 -0700 | [diff] [blame] | 608 | short body can be placed on a single line: |
| 609 | |
| 610 | .. code-block:: python |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 611 | |
| 612 | if a == 42: continue |
| 613 | |
| 614 | YAPF's formatting algorithm creates a weighted tree that acts as the solution |
| 615 | space for the algorithm. Each node in the tree represents the result of a |
| 616 | formatting decision --- i.e., whether to split or not to split before a token. |
| 617 | Each formatting decision has a cost associated with it. Therefore, the cost is |
| 618 | realized on the edge between two nodes. (In reality, the weighted tree doesn't |
| 619 | have separate edge objects, so the cost resides on the nodes themselves.) |
| 620 | |
| 621 | For example, take the following Python code snippet. For the sake of this |
| 622 | example, assume that line (1) violates the column limit restriction and needs to |
| 623 | be reformatted. |
| 624 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 625 | .. code-block:: python |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 626 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 627 | def xxxxxxxxxxx(aaaaaaaaaaaa, bbbbbbbbb, cccccccc, dddddddd, eeeeee): # 1 |
| 628 | pass # 2 |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 629 | |
| 630 | For line (1), the algorithm will build a tree where each node (a |
Eli Bendersky | d08130d | 2015-03-19 05:20:46 -0700 | [diff] [blame] | 631 | ``FormattingDecisionState`` object) is the state of the line at that token given |
| 632 | the decision to split before the token or not. Note: the ``FormatDecisionState`` |
| 633 | objects are copied by value so each node in the graph is unique and a change in |
| 634 | one doesn't affect other nodes. |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 635 | |
Bill Wendling | fa22c89 | 2015-03-18 13:42:25 -0700 | [diff] [blame] | 636 | Heuristics are used to determine the costs of splitting or not splitting. |
| 637 | Because a node holds the state of the tree up to a token's insertion, it can |
| 638 | easily determine if a splitting decision will violate one of the style |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 639 | requirements. For instance, the heuristic is able to apply an extra penalty to |
| 640 | the edge when not splitting between the previous token and the one being added. |
| 641 | |
| 642 | There are some instances where we will never want to split the line, because |
| 643 | doing so will always be detrimental (i.e., it will require a backslash-newline, |
| 644 | which is very rarely desirable). For line (1), we will never want to split the |
Eli Bendersky | d08130d | 2015-03-19 05:20:46 -0700 | [diff] [blame] | 645 | first three tokens: ``def``, ``xxxxxxxxxxx``, and ``(``. Nor will we want to |
| 646 | split between the ``)`` and the ``:`` at the end. These regions are said to be |
| 647 | "unbreakable." This is reflected in the tree by there not being a "split" |
Bill Wendling | 7d62345 | 2015-03-18 13:36:07 -0700 | [diff] [blame] | 648 | decision (left hand branch) within the unbreakable region. |
| 649 | |
| 650 | Now that we have the tree, we determine what the "best" formatting is by finding |
| 651 | the path through the tree with the lowest cost. |
| 652 | |
| 653 | And that's it! |