commit dba3abc95a9a3466f66970b0557a6430e82185bc
author Bimba Shrestha <bimbashrestha@fb.com> Thu Mar 05 12:20:59 2020 -0800
committer Bimba Shrestha <bimbashrestha@fb.com> Thu Mar 05 12:20:59 2020 -0800
tree 4eadda00c83e5ebb9c200fadc92e5d16a0cb61e4
parent a75e5f2ffc46ac771e41a273cc2a9d932a52fc67

Missed returns

lib/common/bitstream.h

diff --git a/lib/common/bitstream.h b/lib/common/bitstream.h
index c84c0ed..ff891ca 100644
--- a/lib/common/bitstream.h
+++ b/lib/common/bitstream.h
@@ -162,7 +162,7 @@
     {
 #   if defined(_MSC_VER)   /* Visual */
         unsigned long r=0;
-        _BitScanReverse ( &r, val ) ? (unsigned)r : 0;
+        return _BitScanReverse ( &r, val ) ? (unsigned)r : 0;
 #   elif defined(__GNUC__) && (__GNUC__ >= 3)   /* Use GCC Intrinsic */
         return __builtin_clz (val) ^ 31;
 #   elif defined(__ICCARM__)    /* IAR Intrinsic */

lib/common/zstd_internal.h

diff --git a/lib/common/zstd_internal.h b/lib/common/zstd_internal.h
index 1b02313..04d2ac8 100644
--- a/lib/common/zstd_internal.h
+++ b/lib/common/zstd_internal.h
@@ -298,7 +298,7 @@
     {
 #   if defined(_MSC_VER)   /* Visual */
         unsigned long r=0;
-        _BitScanReverse(&r, val) ? (unsigned)r : 0;
+        return _BitScanReverse(&r, val) ? (unsigned)r : 0;
 #   elif defined(__GNUC__) && (__GNUC__ >= 3)   /* GCC Intrinsic */
         return __builtin_clz (val) ^ 31;
 #   elif defined(__ICCARM__)    /* IAR Intrinsic */