commit 085346acffb81159eb21f79a95d98f3200b8af1f
author Jean-Michel Trivi <jmtrivi@google.com> Wed Feb 14 10:48:51 2018 -0800
committer Jean-Michel Trivi <jmtrivi@google.com> Wed Feb 14 15:04:46 2018 -0800
tree bf8c6919bc054b0d930b47db2fa9b67ced9ae94f
parent 11817c6bb21423cec873f5acd11cbb203bdc7729

AudioService: fix deadlock

Source of deadlock:
Thread A:
 readAudioSettings()
  -> checkAllAliasStreamVolumes()
    -> synchronized (VolumeStreamState.class)
         -> mStreamStates[streamType].setAllIndexes()
            -> synchronized (mSettingsLock)
Thread B:
 updateStreamVolumeAlias()
  -> mStreamStates[ACCESSIBILITY].setAllIndexes()
     -> synchronized (mSettingsLock)
        -> synchronized (VolumeStreamState.class)

Fix:
 Ensure all calls to VSS.setAllIndexes() are synchronized
 on mSettingsLock then on VolumeStreamState.class.

Bug: 72122435
Test: see bug for repro
Change-Id: I16ad1d1df88256291c36d8f5b8ebe830fe1b0b84