commit | 0d12f7a427e98e54b9dc72cadb994f5cb034eb13 | [log] [tgz] |
---|---|---|
author | Michael Wright <michaelwr@google.com> | Tue Jun 20 21:21:27 2017 +0100 |
committer | Michael Wright <michaelwr@google.com> | Wed Jun 21 15:21:18 2017 +0000 |
tree | bcdda875f7fea681a53bf13253c25d7c2afb4e53 | |
parent | 592e85b4fdbf423d7afa32eb69c7fbae2dd960b4 [diff] |
Make the log message in setInteractive a local variable. If the error message isn't a local variable, it will go out of scope immediately after LogIfSlow is constructed. Unfortunately, LogIfSlow maintains a pointer to String8s internal char* member... which causes a use after free when it goes to log. Oops. Bug: 62820330 Test: none Change-Id: Ie1da3be723f8aae165822002ff42954480a43aa5