Merge "[DO NOT MERGE] Fix potential NPE in Trampoline.requestBackup()." into oc-dev
diff --git a/core/java/android/provider/FontsContract.java b/core/java/android/provider/FontsContract.java
index 34c77b6..3fa92b8 100644
--- a/core/java/android/provider/FontsContract.java
+++ b/core/java/android/provider/FontsContract.java
@@ -128,8 +128,9 @@
* should have this column populated to indicate the result status of the
* query. This will be checked before any other data in the cursor. Possible values are
* {@link #RESULT_CODE_OK}, {@link #RESULT_CODE_FONT_NOT_FOUND},
- * {@link #RESULT_CODE_MALFORMED_QUERY} and {@link #RESULT_CODE_FONT_UNAVAILABLE}. If not
- * present, {@link #RESULT_CODE_OK} will be assumed.
+ * {@link #RESULT_CODE_MALFORMED_QUERY} and {@link #RESULT_CODE_FONT_UNAVAILABLE} for system
+ * defined values. You may also define your own values in the 0x000010000..0xFFFF0000 range.
+ * If not present, {@link #RESULT_CODE_OK} will be assumed.
*/
public static final String RESULT_CODE = "result_code";
@@ -462,7 +463,10 @@
* {@link #FAIL_REASON_FONT_NOT_FOUND},
* {@link #FAIL_REASON_FONT_LOAD_ERROR},
* {@link #FAIL_REASON_FONT_UNAVAILABLE} or
- * {@link #FAIL_REASON_MALFORMED_QUERY}.
+ * {@link #FAIL_REASON_MALFORMED_QUERY} if returned by the system. May also be
+ * a positive value greater than 0 defined by the font provider as an
+ * additional error code. Refer to the provider's documentation for more
+ * information on possible returned error codes.
*/
public void onTypefaceRequestFailed(@FontRequestFailReason int reason) {}
}
diff --git a/graphics/java/android/graphics/Typeface.java b/graphics/java/android/graphics/Typeface.java
index 18dc0dc..115c77f 100644
--- a/graphics/java/android/graphics/Typeface.java
+++ b/graphics/java/android/graphics/Typeface.java
@@ -475,11 +475,14 @@
/**
* Called when a Typeface request done via {@link Typeface#create(FontRequest,
* FontRequestCallback)} fails.
- * @param reason One of {@link #FAIL_REASON_PROVIDER_NOT_FOUND},
+ * @param reason May be one of {@link #FAIL_REASON_PROVIDER_NOT_FOUND},
* {@link #FAIL_REASON_FONT_NOT_FOUND},
* {@link #FAIL_REASON_FONT_LOAD_ERROR},
* {@link #FAIL_REASON_FONT_UNAVAILABLE} or
- * {@link #FAIL_REASON_MALFORMED_QUERY}.
+ * {@link #FAIL_REASON_MALFORMED_QUERY} if returned by the system. May also be
+ * a positive value greater than 0 defined by the font provider as an
+ * additional error code. Refer to the provider's documentation for more
+ * information on possible returned error codes.
*/
void onTypefaceRequestFailed(@FontRequestFailReason int reason);
}
diff --git a/services/core/java/com/android/server/updates/ConfigUpdateInstallReceiver.java b/services/core/java/com/android/server/updates/ConfigUpdateInstallReceiver.java
index cc25c8c..c3c841c 100644
--- a/services/core/java/com/android/server/updates/ConfigUpdateInstallReceiver.java
+++ b/services/core/java/com/android/server/updates/ConfigUpdateInstallReceiver.java
@@ -162,7 +162,7 @@
}
}
- private boolean verifyVersion(int current, int alternative) {
+ protected boolean verifyVersion(int current, int alternative) {
return (current < alternative);
}
diff --git a/services/core/java/com/android/server/updates/SmartSelectionInstallReceiver.java b/services/core/java/com/android/server/updates/SmartSelectionInstallReceiver.java
index 53911c0..1457366 100644
--- a/services/core/java/com/android/server/updates/SmartSelectionInstallReceiver.java
+++ b/services/core/java/com/android/server/updates/SmartSelectionInstallReceiver.java
@@ -25,5 +25,9 @@
"metadata/smartselection",
"version");
}
-}
+ @Override
+ protected boolean verifyVersion(int current, int alternative) {
+ return true;
+ }
+}