Allow apps to pass in launch bounds when moving/starting a task
Pass in bounds via ActivityOptions for moveTaskToFront and
startActivityFromRecents. Allow bounds to be overriden by rects
in starting intents.
Set bounds to null in RecentsView for full screen layout.
Change-Id: I0ff79fd75068f4ba82d5e2c0a21881fabebdadb8
diff --git a/core/java/android/app/ActivityOptions.java b/core/java/android/app/ActivityOptions.java
index 2406985..933f98d 100644
--- a/core/java/android/app/ActivityOptions.java
+++ b/core/java/android/app/ActivityOptions.java
@@ -19,6 +19,7 @@
import android.content.Context;
import android.content.Intent;
import android.graphics.Bitmap;
+import android.graphics.Rect;
import android.os.Bundle;
import android.os.Handler;
import android.os.IRemoteCallback;
@@ -59,6 +60,13 @@
public static final String KEY_PACKAGE_NAME = "android:activity.packageName";
/**
+ * The bounds that the activity should be started in. Set to null explicitly
+ * for full screen. If the key is not found, previous bounds will be preserved.
+ * @hide
+ */
+ public static final String KEY_BOUNDS = "android:activity.bounds";
+
+ /**
* Type of animation that arguments specify.
* @hide
*/
@@ -163,6 +171,8 @@
public static final int ANIM_CLIP_REVEAL = 11;
private String mPackageName;
+ private boolean mHasBounds;
+ private Rect mBounds;
private int mAnimationType = ANIM_NONE;
private int mCustomEnterResId;
private int mCustomExitResId;
@@ -631,6 +641,10 @@
} catch (RuntimeException e) {
Slog.w(TAG, e);
}
+ mHasBounds = opts.containsKey(KEY_BOUNDS);
+ if (mHasBounds) {
+ mBounds = opts.getParcelable(KEY_BOUNDS);
+ }
mAnimationType = opts.getInt(KEY_ANIM_TYPE);
switch (mAnimationType) {
case ANIM_CUSTOM:
@@ -677,11 +691,28 @@
}
/** @hide */
+ public ActivityOptions setBounds(Rect bounds) {
+ mHasBounds = true;
+ mBounds = bounds;
+ return this;
+ }
+
+ /** @hide */
public String getPackageName() {
return mPackageName;
}
/** @hide */
+ public boolean hasBounds() {
+ return mHasBounds;
+ }
+
+ /** @hide */
+ public Rect getBounds(){
+ return mBounds;
+ }
+
+ /** @hide */
public int getAnimationType() {
return mAnimationType;
}
@@ -867,6 +898,9 @@
if (mPackageName != null) {
b.putString(KEY_PACKAGE_NAME, mPackageName);
}
+ if (mHasBounds) {
+ b.putParcelable(KEY_BOUNDS, mBounds);
+ }
b.putInt(KEY_ANIM_TYPE, mAnimationType);
if (mUsageTimeReport != null) {
b.putParcelable(KEY_USAGE_TIME_REPORT, mUsageTimeReport);
diff --git a/packages/SystemUI/src/com/android/systemui/recents/RecentsResizeTaskDialog.java b/packages/SystemUI/src/com/android/systemui/recents/RecentsResizeTaskDialog.java
index b701e0b..300ea2a 100644
--- a/packages/SystemUI/src/com/android/systemui/recents/RecentsResizeTaskDialog.java
+++ b/packages/SystemUI/src/com/android/systemui/recents/RecentsResizeTaskDialog.java
@@ -197,6 +197,7 @@
break;
case PLACE_FULL:
// Nothing to change.
+ mBounds[0] = null;
break;
}
@@ -213,10 +214,13 @@
dismiss();
mRecentsActivity.dismissRecentsToHomeWithoutTransitionAnimation();
- // Resize all tasks beginning from the "oldest" one.
- for (int i = additionalTasks; i >= 0; --i) {
- if (mTasks[i] != null) {
- mSsp.resizeTask(mTasks[i].key.id, mBounds[i]);
+ // In debug mode, we force all task to be resizeable regardless of the
+ // current app configuration.
+ if (RecentsConfiguration.getInstance().multiStackEnabled) {
+ for (int i = additionalTasks; i >= 0; --i) {
+ if (mTasks[i] != null) {
+ mSsp.setTaskResizeable(mTasks[i].key.id);
+ }
}
}
@@ -224,7 +228,7 @@
// the focus ends on the selected one.
for (int i = additionalTasks; i >= 0; --i) {
if (mTasks[i] != null) {
- mRecentsView.launchTask(mTasks[i]);
+ mRecentsView.launchTask(mTasks[i], mBounds[i]);
}
}
}
diff --git a/packages/SystemUI/src/com/android/systemui/recents/misc/SystemServicesProxy.java b/packages/SystemUI/src/com/android/systemui/recents/misc/SystemServicesProxy.java
index 89aeabc..bead1b0 100644
--- a/packages/SystemUI/src/com/android/systemui/recents/misc/SystemServicesProxy.java
+++ b/packages/SystemUI/src/com/android/systemui/recents/misc/SystemServicesProxy.java
@@ -271,17 +271,12 @@
return null;
}
- /** Resize a given task. */
- public void resizeTask(int taskId, Rect bounds) {
+ /** Allow a task to resize. */
+ public void setTaskResizeable(int taskId) {
if (mIam == null) return;
try {
- if (RecentsConfiguration.getInstance().multiStackEnabled) {
- // In debug mode, we force all task to be resizeable regardless of the
- // current app configuration.
- mIam.setTaskResizeable(taskId, true);
- }
- mIam.resizeTask(taskId, bounds);
+ mIam.setTaskResizeable(taskId, true);
} catch (RemoteException e) {
e.printStackTrace();
}
diff --git a/packages/SystemUI/src/com/android/systemui/recents/views/RecentsView.java b/packages/SystemUI/src/com/android/systemui/recents/views/RecentsView.java
index 00ac5f9..651b29a 100644
--- a/packages/SystemUI/src/com/android/systemui/recents/views/RecentsView.java
+++ b/packages/SystemUI/src/com/android/systemui/recents/views/RecentsView.java
@@ -165,7 +165,7 @@
/** Gets the next task in the stack - or if the last - the top task */
public Task getNextTaskOrTopTask(Task taskToSearch) {
- Task returnTask = null;
+ Task returnTask = null;
boolean found = false;
List<TaskStackView> stackViews = getTaskStackViews();
int stackCount = stackViews.size();
@@ -203,7 +203,7 @@
TaskView tv = taskViews.get(j);
Task task = tv.getTask();
if (tv.isFocusedTask()) {
- onTaskViewClicked(stackView, tv, stack, task, false);
+ onTaskViewClicked(stackView, tv, stack, task, false, false, null);
return true;
}
}
@@ -212,7 +212,7 @@
}
/** Launches a given task. */
- public boolean launchTask(Task task) {
+ public boolean launchTask(Task task, Rect taskBounds) {
// Get the first stack view
List<TaskStackView> stackViews = getTaskStackViews();
int stackCount = stackViews.size();
@@ -225,7 +225,7 @@
for (int j = 0; j < taskViewCount; j++) {
TaskView tv = taskViews.get(j);
if (tv.getTask() == task) {
- onTaskViewClicked(stackView, tv, stack, task, false);
+ onTaskViewClicked(stackView, tv, stack, task, false, true, taskBounds);
return true;
}
}
@@ -250,7 +250,7 @@
if (tasks.get(j).isLaunchTarget) {
Task task = tasks.get(j);
TaskView tv = stackView.getChildViewForTask(task);
- onTaskViewClicked(stackView, tv, stack, task, false);
+ onTaskViewClicked(stackView, tv, stack, task, false, false, null);
return true;
}
}
@@ -373,7 +373,7 @@
searchBarSpaceBounds.right, searchBarSpaceBounds.bottom);
}
- // Layout each TaskStackView with the full width and height of the window since the
+ // Layout each TaskStackView with the full width and height of the window since the
// transition view is a child of that stack view
List<TaskStackView> stackViews = getTaskStackViews();
int stackCount = stackViews.size();
@@ -604,7 +604,8 @@
@Override
public void onTaskViewClicked(final TaskStackView stackView, final TaskView tv,
- final TaskStack stack, final Task task, final boolean lockToTask) {
+ final TaskStack stack, final Task task, final boolean lockToTask,
+ final boolean boundsValid, final Rect bounds) {
// Notify any callbacks of the launching of a new task
if (mCb != null) {
@@ -632,9 +633,9 @@
final SystemServicesProxy ssp =
RecentsTaskLoader.getInstance().getSystemServicesProxy();
ActivityOptions opts = null;
+ ActivityOptions.OnAnimationStartedListener animStartedListener = null;
if (task.thumbnail != null && task.thumbnail.getWidth() > 0 &&
task.thumbnail.getHeight() > 0) {
- ActivityOptions.OnAnimationStartedListener animStartedListener = null;
if (lockToTask) {
animStartedListener = new ActivityOptions.OnAnimationStartedListener() {
boolean mTriggered = false;
@@ -665,9 +666,14 @@
offsetX, offsetY, transform.rect.width(), transform.rect.height(),
sourceView.getHandler(), animStartedListener);
}
+ } else {
+ opts = ActivityOptions.makeBasic();
}
-
+ if (boundsValid) {
+ opts.setBounds(bounds);
+ }
final ActivityOptions launchOpts = opts;
+ final boolean screenPinningRequested = (animStartedListener == null) && lockToTask;
final Runnable launchRunnable = new Runnable() {
@Override
public void run() {
@@ -677,7 +683,7 @@
} else {
if (ssp.startActivityFromRecents(getContext(), task.key.id,
task.activityLabel, launchOpts)) {
- if (launchOpts == null && lockToTask) {
+ if (screenPinningRequested) {
mCb.onScreenPinningRequest();
}
} else {
diff --git a/packages/SystemUI/src/com/android/systemui/recents/views/TaskStackView.java b/packages/SystemUI/src/com/android/systemui/recents/views/TaskStackView.java
index 0068f84..4e82c8a 100644
--- a/packages/SystemUI/src/com/android/systemui/recents/views/TaskStackView.java
+++ b/packages/SystemUI/src/com/android/systemui/recents/views/TaskStackView.java
@@ -59,7 +59,7 @@
/** The TaskView callbacks */
interface TaskStackViewCallbacks {
public void onTaskViewClicked(TaskStackView stackView, TaskView tv, TaskStack stack, Task t,
- boolean lockToTask);
+ boolean lockToTask, boolean boundsValid, Rect bounds);
public void onTaskViewAppInfoClicked(Task t);
public void onTaskViewDismissed(Task t);
public void onAllTaskViewsDismissed(ArrayList<Task> removedTasks);
@@ -1377,7 +1377,7 @@
mUIDozeTrigger.stopDozing();
if (mCb != null) {
- mCb.onTaskViewClicked(this, tv, mStack, task, lockToTask);
+ mCb.onTaskViewClicked(this, tv, mStack, task, lockToTask, false, null);
}
}
diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java
index 830dced..81936ee 100644
--- a/services/core/java/com/android/server/am/ActivityManagerService.java
+++ b/services/core/java/com/android/server/am/ActivityManagerService.java
@@ -4225,7 +4225,7 @@
throw new IllegalArgumentException("Task " + taskId + " not found.");
}
if (task.getRootActivity() != null) {
- moveTaskToFrontLocked(task.taskId, 0, null);
+ moveTaskToFrontLocked(task.taskId, 0, options);
return ActivityManager.START_TASK_TO_FRONT;
}
callingUid = task.mCallingUid;
diff --git a/services/core/java/com/android/server/am/ActivityStack.java b/services/core/java/com/android/server/am/ActivityStack.java
index d2a6c02..a2467ef 100644
--- a/services/core/java/com/android/server/am/ActivityStack.java
+++ b/services/core/java/com/android/server/am/ActivityStack.java
@@ -4547,10 +4547,11 @@
boolean toTop) {
TaskRecord task = new TaskRecord(mService, taskId, info, intent, voiceSession,
voiceInteractor);
+ // add the task to stack first, mTaskPositioner might need the stack association
+ addTask(task, toTop, false);
if (mTaskPositioner != null) {
mTaskPositioner.updateDefaultBounds(task, mTaskHistory, info.initialLayout);
}
- addTask(task, toTop, false);
return task;
}
@@ -4587,19 +4588,20 @@
void addConfigOverride(ActivityRecord r, TaskRecord task) {
final Rect bounds = task.getLaunchBounds();
- final Configuration config = task.updateOverrideConfiguration(bounds);
+ task.updateOverrideConfiguration(bounds);
mWindowManager.addAppToken(task.mActivities.indexOf(r), r.appToken,
r.task.taskId, mStackId, r.info.screenOrientation, r.fullscreen,
(r.info.flags & ActivityInfo.FLAG_SHOW_FOR_ALL_USERS) != 0, r.userId,
r.info.configChanges, task.voiceSession != null, r.mLaunchTaskBehind,
- bounds, config);
+ bounds, task.mOverrideConfig);
r.taskConfigOverride = task.mOverrideConfig;
}
private void setAppTask(ActivityRecord r, TaskRecord task) {
final Rect bounds = task.getLaunchBounds();
- final Configuration config = task.updateOverrideConfiguration(bounds);
- mWindowManager.setAppTask(r.appToken, task.taskId, task.getLaunchBounds(), config);
+ task.updateOverrideConfiguration(bounds);
+ mWindowManager.setAppTask(
+ r.appToken, task.taskId, task.getLaunchBounds(), task.mOverrideConfig);
r.taskConfigOverride = task.mOverrideConfig;
}
diff --git a/services/core/java/com/android/server/am/ActivityStackSupervisor.java b/services/core/java/com/android/server/am/ActivityStackSupervisor.java
index fb3007d..56ea0f1 100644
--- a/services/core/java/com/android/server/am/ActivityStackSupervisor.java
+++ b/services/core/java/com/android/server/am/ActivityStackSupervisor.java
@@ -1764,7 +1764,7 @@
return ACTIVITY_RESTRICTION_NONE;
}
- ActivityStack computeStackFocus(ActivityRecord r, boolean newTask) {
+ ActivityStack computeStackFocus(ActivityRecord r, boolean newTask, Rect bounds) {
final TaskRecord task = r.task;
// On leanback only devices we should keep all activities in the same stack.
@@ -1815,10 +1815,10 @@
}
// If there is no suitable dynamic stack then we figure out which static stack to use.
- stack = getStack(
- task != null
- ? task.getLaunchStackId(mFocusedStack) : FULLSCREEN_WORKSPACE_STACK_ID,
- CREATE_IF_NEEDED, ON_TOP);
+ int stackId = task != null ? task.getLaunchStackId() :
+ bounds != null ? FREEFORM_WORKSPACE_STACK_ID :
+ FULLSCREEN_WORKSPACE_STACK_ID;
+ stack = getStack(stackId, CREATE_IF_NEEDED, ON_TOP);
if (DEBUG_FOCUS || DEBUG_STACK) Slog.d(TAG_FOCUS, "computeStackFocus: New stack r="
+ r + " stackId=" + stack.mStackId);
return stack;
@@ -1846,6 +1846,22 @@
final Intent intent = r.intent;
final int callingUid = r.launchedFromUid;
+ boolean overrideBounds = false;
+ Rect newBounds = null;
+ if (r.info.resizeable || (inTask != null && inTask.mResizeable)) {
+ if (intent.hasExtra(ActivityOptions.KEY_BOUNDS)) {
+ overrideBounds = true;
+ newBounds = Rect.unflattenFromString(
+ intent.getStringExtra(ActivityOptions.KEY_BOUNDS));
+ } else if (options != null) {
+ ActivityOptions opts = new ActivityOptions(options);
+ if (opts.hasBounds()) {
+ overrideBounds = true;
+ newBounds = opts.getBounds();
+ }
+ }
+ }
+
// In some flows in to this function, we retrieve the task record and hold on to it
// without a lock before calling back in to here... so the task at this point may
// not actually be in recents. Check for that, and if it isn't in recents just
@@ -2199,7 +2215,8 @@
if (task != null && task.stack == null) {
// Target stack got cleared when we all activities were removed
// above. Go ahead and reset it.
- targetStack = computeStackFocus(sourceRecord, false /* newTask */);
+ targetStack = computeStackFocus(
+ sourceRecord, false /* newTask */, null /* bounds */);
targetStack.addTask(
task, !launchTaskBehind /* toTop */, false /* moving */);
}
@@ -2325,7 +2342,7 @@
if (r.resultTo == null && inTask == null && !addingToTask
&& (launchFlags & Intent.FLAG_ACTIVITY_NEW_TASK) != 0) {
newTask = true;
- targetStack = computeStackFocus(r, newTask);
+ targetStack = computeStackFocus(r, newTask, newBounds);
if (doResume) {
targetStack.moveToFront("startingNewTask");
}
@@ -2336,6 +2353,9 @@
newTaskIntent != null ? newTaskIntent : intent,
voiceSession, voiceInteractor, !launchTaskBehind /* toTop */),
taskToAffiliate);
+ if (overrideBounds) {
+ r.task.updateOverrideConfiguration(newBounds);
+ }
if (DEBUG_TASKS) Slog.v(TAG_TASKS,
"Starting new activity " + r + " in new task " + r.task);
} else {
@@ -2420,6 +2440,14 @@
Slog.e(TAG, "Attempted Lock Task Mode violation r=" + r);
return ActivityManager.START_RETURN_LOCK_TASK_MODE_VIOLATION;
}
+ if (overrideBounds) {
+ inTask.updateOverrideConfiguration(newBounds);
+ int stackId = inTask.getLaunchStackId();
+ if (stackId != inTask.stack.mStackId) {
+ moveTaskToStackUncheckedLocked(
+ inTask, stackId, ON_TOP, !FORCE_FOCUS, "inTaskToFront");
+ }
+ }
targetStack = inTask.stack;
targetStack.moveTaskToFrontLocked(inTask, noAnimation, options, r.appTimeTracker,
"inTaskToFront");
@@ -2457,7 +2485,7 @@
// This not being started from an existing activity, and not part
// of a new task... just put it in the top task, though these days
// this case should never happen.
- targetStack = computeStackFocus(r, newTask);
+ targetStack = computeStackFocus(r, newTask, null /* bounds */);
if (doResume) {
targetStack.moveToFront("addingToTopTask");
}
@@ -2816,9 +2844,26 @@
+ task + " to front. Stack is null");
return;
}
- task.stack.moveTaskToFrontLocked(task, false /* noAnimation */, options,
+
+ int stackId = task.stack.mStackId;
+ if (task.mResizeable && options != null) {
+ ActivityOptions opts = new ActivityOptions(options);
+ if (opts.hasBounds()) {
+ Rect bounds = opts.getBounds();
+ task.updateOverrideConfiguration(bounds);
+ mWindowManager.resizeTask(task.taskId, bounds, task.mOverrideConfig, false);
+ stackId = task.getLaunchStackId();
+ }
+ }
+
+ if (stackId != task.stack.mStackId) {
+ moveTaskToStackUncheckedLocked(task, stackId, ON_TOP, FORCE_FOCUS, reason);
+ } else {
+ task.stack.moveTaskToFrontLocked(task, false /* noAnimation */, options,
task.getTopActivity() == null ? null : task.getTopActivity().appTimeTracker,
reason);
+ }
+
if (DEBUG_STACK) Slog.d(TAG_STACK,
"findTaskToMoveToFront: moved to front of stack=" + task.stack);
}
@@ -3007,7 +3052,7 @@
// Task doesn't exist in window manager yet (e.g. was restored from recents).
// All we can do for now is update the bounds so it can be used when the task is
// added to window manager.
- task.mBounds = task.mLastNonFullscreenBounds = new Rect(bounds);
+ task.updateOverrideConfiguration(bounds);
if (task.stack != null && task.stack.mStackId != FREEFORM_WORKSPACE_STACK_ID) {
// re-restore the task so it can have the proper stack association.
restoreRecentTaskLocked(task, FREEFORM_WORKSPACE_STACK_ID);
@@ -3081,8 +3126,7 @@
*/
private boolean restoreRecentTaskLocked(TaskRecord task, int stackId) {
if (stackId == INVALID_STACK_ID) {
- stackId = mLeanbackOnlyDevice ?
- mHomeStack.mStackId : task.getLaunchStackId(mFocusedStack);
+ stackId = mLeanbackOnlyDevice ? mHomeStack.mStackId : task.getLaunchStackId();
}
if (task.stack != null) {
// Task has already been restored once. See if we need to do anything more
diff --git a/services/core/java/com/android/server/am/TaskRecord.java b/services/core/java/com/android/server/am/TaskRecord.java
index 51f6a2a..5694e704 100644
--- a/services/core/java/com/android/server/am/TaskRecord.java
+++ b/services/core/java/com/android/server/am/TaskRecord.java
@@ -1228,20 +1228,16 @@
return !mOverrideConfig.equals(oldConfig) ? mOverrideConfig : null;
}
- /** Returns the stack that should be used to launch this task. */
- int getLaunchStackId(ActivityStack focusStack) {
- if (stack != null) {
- // We are already in a stack silly...
- return stack.mStackId;
- }
- if (isHomeTask()) {
+ /**
+ * Returns the correct stack to use based on task type and currently set bounds,
+ * regardless of the focused stack and current stack association of the task.
+ * The task will be moved (and stack focus changed) later if necessary.
+ */
+ int getLaunchStackId() {
+ if (!isApplicationTask()) {
return HOME_STACK_ID;
}
- if (focusStack != null && focusStack.mStackId != HOME_STACK_ID) {
- // Like it or not you are going in the focused stack!
- return focusStack.mStackId;
- }
- if (mBounds != null || mLastNonFullscreenBounds != null) {
+ if (mBounds != null) {
return FREEFORM_WORKSPACE_STACK_ID;
}
return FULLSCREEN_WORKSPACE_STACK_ID;