commit 154a0d0b38250bcf246c53b9229937c60a176fbc
author Treehugger Robot <treehugger-gerrit@google.com> Mon Apr 01 14:45:18 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Apr 01 14:45:18 2019 +0000
tree 08b55d48681ac1936b17ba68520120492c641108
parent 70e943ba80301e6adc03f747b28a0a72fb923395
parent e799f84de0d290a5ed5643824009a9b8f2393930

Merge "Add comment for NetworkStack permissions"

packages/NetworkStack/AndroidManifest.xml

diff --git a/packages/NetworkStack/AndroidManifest.xml b/packages/NetworkStack/AndroidManifest.xml
index df886ea..3fc1e98 100644
--- a/packages/NetworkStack/AndroidManifest.xml
+++ b/packages/NetworkStack/AndroidManifest.xml
@@ -21,6 +21,10 @@
           android:sharedUserId="android.uid.networkstack">
     <uses-sdk android:minSdkVersion="28" android:targetSdkVersion="28" />
 
+    <!-- Permissions must be defined here, and not in the base manifest, as the network stack
+         running in the system server process does not need any permission, and having privileged
+         permissions added would cause crashes on startup unless they are also added to the
+         privileged permissions whitelist for that package. -->
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />