commit 1c300861d2f0c12ac9aa8d36390e90b81fb8003b
author Josh Gao <jmgao@google.com> Tue Jun 26 11:41:34 2018 -0700
committer Josh Gao <jmgao@google.com> Tue Jun 26 12:37:42 2018 -0700
tree ad7f287c666b62f848b852d5c07f7b4949bfc8a2
parent 6bebb8418ceecf44d2af40033870f3aabacfe36e

Fix memory leak in RenderThread::dumpGraphicsMemory.

This would have been a double-close of fd, except we just leak the
FILE* instead.

Test: treehugger
Change-Id: I519366fbcf0eb6f03f79c22abfa2b1b1b493a70a

libs/hwui/renderthread/RenderThread.cpp

diff --git a/libs/hwui/renderthread/RenderThread.cpp b/libs/hwui/renderthread/RenderThread.cpp
index 72a428f..bd34eb8 100644
--- a/libs/hwui/renderthread/RenderThread.cpp
+++ b/libs/hwui/renderthread/RenderThread.cpp
@@ -236,10 +236,8 @@
             break;
     }
 
-    FILE *file = fdopen(fd, "a");
-    fprintf(file, "\n%s\n", cachesOutput.string());
-    fprintf(file, "\nPipeline=%s\n", pipeline.string());
-    fflush(file);
+    dprintf(fd, "\n%s\n", cachesOutput.string());
+    dprintf(fd, "\nPipeline=%s\n", pipeline.string());
 }
 
 Readback& RenderThread::readback() {