| commit | 1d4fdcb6def9602ea8ed523e7fa1930502e692db | [log] [tgz] |
|---|---|---|
| author | Ruchir Rastogi <ruchirr@google.com> | Mon Apr 06 14:10:04 2020 -0700 |
| committer | Ruchir Rastogi <ruchirr@google.com> | Mon Apr 06 14:10:04 2020 -0700 |
| tree | 1a50f620893a1d24db320faef99d3cb229879377 | |
| parent | 17849976da46cc90a50d5498109980e31e1900bb [diff] |
Remove obsolete/infeasible TODOs (a) Clean up LogEvent::parseBuffer - having those variables be member variables really helps with code readability. (b) Don't hold locks when writing to pipe within ShellSubscriber - ag/150969574 describes why holding a lock is necessary. Test: m Bug: 150312423 (allows this bug to be marked as obsolete) Change-Id: I4903de1dc87a552932b70e5975a7cde91df05b3b