commit 1fc78e1814d6e1ad8d49e905a569d2589bbb2b8f
author Chih-Hung Hsieh <chh@google.com> Thu Dec 20 13:37:44 2018 -0800
committer Chih-hung Hsieh <chh@google.com> Fri Jan 04 17:38:13 2019 +0000
tree aed2dad2df847dd375759f3ab6378466a9abe482
parent bd7379858523c4e06175ee6cd92b46750d05b1dd

Fix/suppress aapt/aapt2 google-explicit-constructor warnings

* Add explicit to conversion constructors/operators
* Use NOLINT or NOLINTNEXTLINE to suppress warnings on intended converters

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: Ie02101ea7c422e8add535c111a30a2f21ead0ace

tools/aapt2/Debug.cpp

diff --git a/tools/aapt2/Debug.cpp b/tools/aapt2/Debug.cpp
index f064cb1..e0d7abe 100644
--- a/tools/aapt2/Debug.cpp
+++ b/tools/aapt2/Debug.cpp
@@ -414,7 +414,7 @@
  public:
   using xml::ConstVisitor::Visit;
 
-  XmlPrinter(Printer* printer) : printer_(printer) {
+  explicit XmlPrinter(Printer* printer) : printer_(printer) {
   }
 
   void Visit(const xml::Element* el) override {