commit 231b06e7d302762a2680fd5f15b41ec7848a439f
author Wale Ogunwale <ogunwale@google.com> Wed Sep 16 12:03:09 2015 -0700
committer Wale Ogunwale <ogunwale@google.com> Wed Sep 16 12:32:51 2015 -0700
tree 8f359fbbc9da140d34a91a75d3fb28d2bcf0106a
parent 52b290f73f1cd1a6ab791f21e78245becfe0b29d

Increased window resize handle to 30dp.

It was very hard to hit the drag target with 10dp.

Also, centralized dip to pixel conversion with window manager.

Change-Id: Idc8a90dd55113aa731eaaa8b04af6b74a1176546

services/core/java/com/android/server/wm/TaskPositioner.java

diff --git a/services/core/java/com/android/server/wm/TaskPositioner.java b/services/core/java/com/android/server/wm/TaskPositioner.java
index 8d377fd..7e32b84 100644
--- a/services/core/java/com/android/server/wm/TaskPositioner.java
+++ b/services/core/java/com/android/server/wm/TaskPositioner.java
@@ -22,6 +22,8 @@
 import static android.content.res.Configuration.ORIENTATION_LANDSCAPE;
 import static com.android.server.wm.WindowManagerService.DEBUG_TASK_POSITIONING;
 import static com.android.server.wm.WindowManagerService.SHOW_TRANSACTIONS;
+import static com.android.server.wm.WindowState.MINIMUM_VISIBLE_HEIGHT_IN_DP;
+import static com.android.server.wm.WindowState.MINIMUM_VISIBLE_WIDTH_IN_DP;
 
 import android.annotation.IntDef;
 import android.graphics.Point;
@@ -31,7 +33,6 @@
 import android.os.RemoteException;
 import android.util.DisplayMetrics;
 import android.util.Slog;
-import android.util.TypedValue;
 import android.view.Display;
 import android.view.DisplayInfo;
 import android.view.InputChannel;
@@ -247,7 +248,7 @@
         mService.pauseRotationLocked();
 
         mDimLayer = new DimLayer(mService, this, mDisplay.getDisplayId());
-        mSideMargin = (int)dipToPx(SIDE_MARGIN_DIP);
+        mSideMargin = mService.dipToPixel(SIDE_MARGIN_DIP, mDisplayMetrics);
     }
 
     void unregister() {
@@ -331,10 +332,8 @@
             // This is a resizing operation.
             final int deltaX = Math.round(x - mStartDragX);
             final int deltaY = Math.round(y - mStartDragY);
-            // TODO: fix the min sizes when we have mininum width/height support,
-            //       use hard-coded min sizes for now.
-            final int minSizeX = (int)(dipToPx(96));
-            final int minSizeY = (int)(dipToPx(64));
+            final int minSizeX = mService.dipToPixel(MINIMUM_VISIBLE_WIDTH_IN_DP, mDisplayMetrics);
+            final int minSizeY = mService.dipToPixel(MINIMUM_VISIBLE_HEIGHT_IN_DP, mDisplayMetrics);
             int left = mWindowOriginalBounds.left;
             int top = mWindowOriginalBounds.top;
             int right = mWindowOriginalBounds.right;
@@ -431,8 +430,4 @@
                 * WindowManagerService.TYPE_LAYER_MULTIPLIER
                 + WindowManagerService.TYPE_LAYER_OFFSET;
     }
-
-    private float dipToPx(float dip) {
-        return TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, dip, mDisplayMetrics);
-    }
 }