commit 2893302afc4137e63c9174a5d471d1f18b8b5d87
author Sudheer Shanka <sudheersai@google.com> Mon Mar 14 14:59:52 2016 -0700
committer Sudheer Shanka <sudheersai@google.com> Mon Mar 14 14:59:52 2016 -0700
tree d83acf504b60dba50645df7f4e24b45b4a1bc8f3
parent 76001741814f16522c321108f7ef89965389cbe0

Call preference.setEnabled only after updating disabledByAdmin state.

We check the value of disabledByAdmin state in setEnabled, so update it
first before calling setEnabled.

Bug: 27642236
Change-Id: Ie6c805b85a3afb87ffdaad0b80dbadc172b62d49

packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java

diff --git a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java
index 47023c1..d0aba22 100644
--- a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java
+++ b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java
@@ -146,12 +146,13 @@
     public boolean setDisabledByAdmin(EnforcedAdmin admin) {
         final boolean disabled = (admin != null ? true : false);
         mEnforcedAdmin = admin;
-        mPreference.setEnabled(!disabled);
+        boolean changed = false;
         if (mDisabledByAdmin != disabled) {
             mDisabledByAdmin = disabled;
-            return true;
+            changed = true;
         }
-        return false;
+        mPreference.setEnabled(!disabled);
+        return changed;
     }
 
     public boolean isDisabledByAdmin() {