commit 28b5b1444965fcdb471a8c2ff09f6f2eb53b337b
author Keisuke Kuroyanagi <ksk@google.com> Wed Apr 22 21:27:08 2015 +0900
committer Keisuke Kuroyanagi <ksk@google.com> Mon Apr 27 09:48:26 2015 +0000
tree 529b13d310f7cbbaf1716e3e0dc7e4f6cd3eedbe
parent 78f895a7108a25d65df74392cb3a12af32b06bae

Fix: Selection handles are wrongly shown.

Selection handles were always shown when selection action
mode is started at first time. When the action mode is
started without a selection, only insertion handle must be
shown.

Bug: 20264980
Bug: 20407551

Change-Id: I630804e007f795d28f87e3fa6cba0de5bf588c78

core/java/android/widget/Editor.java

diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java
index 652fff2..f1be434 100644
--- a/core/java/android/widget/Editor.java
+++ b/core/java/android/widget/Editor.java
@@ -3023,8 +3023,10 @@
         public SelectionActionModeCallback() {
             SelectionModifierCursorController selectionController = getSelectionController();
             if (selectionController.mStartHandle == null) {
+                // As these are for initializing selectionController, hide() must be called.
                 selectionController.initDrawables();
                 selectionController.initHandles();
+                selectionController.hide();
             }
             mSelectionHandleHeight = Math.max(
                     mSelectHandleLeft.getMinimumHeight(), mSelectHandleRight.getMinimumHeight());