commit 343ad71d7cb4934751a91006677266bd73ed224c
author Craig Mautner <cmautner@google.com> Wed Feb 13 22:37:26 2013 -0800
committer Craig Mautner <cmautner@google.com> Thu Feb 14 12:48:53 2013 -0800
tree d5624a169986af3ddbe2d98ad99429bd3a948021
parent 3beb8757ac9ba0829bf96e067ae32315f1d4bb3f

Reset and reuse Iterators and don't new() one.

Save time and memory by resuing permanent mTmpXxxIterator for
AllWindowsIterator and AppTokenIterator.

Change-Id: I2e5143364651d9471e9e70eee514d3f45d595468

services/java/com/android/server/wm/WindowAnimator.java

diff --git a/services/java/com/android/server/wm/WindowAnimator.java b/services/java/com/android/server/wm/WindowAnimator.java
index 92ad485..7f7a9bd 100644
--- a/services/java/com/android/server/wm/WindowAnimator.java
+++ b/services/java/com/android/server/wm/WindowAnimator.java
@@ -10,6 +10,8 @@
 import static com.android.server.wm.WindowManagerService.LayoutFields.SET_FORCE_HIDING_CHANGED;
 import static com.android.server.wm.WindowManagerService.LayoutFields.SET_ORIENTATION_CHANGE_COMPLETE;
 import static com.android.server.wm.WindowManagerService.LayoutFields.SET_WALLPAPER_ACTION_PENDING;
+import static com.android.server.wm.WindowManagerService.FORWARD_ITERATOR;
+import static com.android.server.wm.WindowManagerService.REVERSE_ITERATOR;
 
 import android.content.Context;
 import android.os.Debug;
@@ -175,7 +177,7 @@
     private void updateAppWindowsLocked(int displayId) {
         int i;
         final DisplayContent displayContent = mService.getDisplayContentLocked(displayId);
-        AppTokenIterator iterator = displayContent.new AppTokenIterator();
+        AppTokenIterator iterator = displayContent.getTmpAppIterator(FORWARD_ITERATOR);
         while (iterator.hasNext()) {
             final AppWindowAnimator appAnimator = iterator.next().mAppAnimator;
             final boolean wasAnimating = appAnimator.animation != null
@@ -458,8 +460,8 @@
     private void testTokenMayBeDrawnLocked(int displayId) {
         // See if any windows have been drawn, so they (and others
         // associated with them) can now be shown.
-        AppTokenIterator iterator = mService.getDisplayContentLocked(displayId).new
-                AppTokenIterator();
+        AppTokenIterator iterator =
+                mService.getDisplayContentLocked(displayId).getTmpAppIterator(FORWARD_ITERATOR);
         while (iterator.hasNext()) {
             AppWindowToken wtoken = iterator.next();
             AppWindowAnimator appAnimator = wtoken.mAppAnimator;