tree ab9192bd41089cadeda7080459bd8657e879defe
parent db31313031f774c7fcecb7a307020c9c2a473e2c
author Andrii Kulian <akulian@google.com> 1564524357 -0700
committer Andrii Kulian <akulian@google.com> 1564528358 -0700

Fix return value for IActivityTaskManager#finishActivity()

IActivityTaskManager#finishActivity() used to return 'true' even if
activity was already finishing prior to the call. The refactor in
I30ebc306637dea5e8b28ca4b4dfaab8df31d2be3 that merged
ActivityStack#requestFinishActivityLocked() and
ActivityRecord#finishActivityLocked() accidentally changed the
return value for the case when activity was already finishing.

This made the client think that the activity was not finished, so
the client state was not updated correctly.

This CL checks the finishing state of the activity instead to report
back to client.

Bug: 138265285
Test: atest WmTests:ActivityTaskManagerServiceTests
Change-Id: I9503cf6b9ceaece4ab6a5933c143d238f7fa7c4d