commit 45146493c6cbb3f39d92b41e5bc8742fb1e04ff6
author Svetoslav <svetoslavganov@google.com> Thu Jun 25 11:53:02 2015 -0700
committer Svetoslav <svetoslavganov@google.com> Thu Jun 25 11:53:02 2015 -0700
tree 26bc5209ad5e58bf677dba5984181af755896300
parent 7008b51817361443fc6f136c5b187e1d471c94f5

Add missing conditional in settings provider

Change-Id: I717e8b87eccbedf1a1abead77e7856a2aa2405fa

packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java

diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
index 44b9d8b..41043eb 100644
--- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
+++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
@@ -905,7 +905,9 @@
     private boolean mutateSystemSetting(String name, String value, int runAsUserId,
             int operation) {
         // Check for permissions first.
-        hasPermissionsToMutateSystemSettings();
+        if (!hasPermissionsToMutateSystemSettings()) {
+            return false;
+        }
 
         // Verify whether this operation is allowed for the calling package.
         if (!isAppOpWriteSettingsAllowedForCallingPackage()) {