commit 48a2a5ad1b7c4979b1d7baf6add4bc32148a75ae
author Xavier Ducrohet <xav@android.com> Tue Mar 15 11:29:16 2011 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Tue Mar 15 11:29:16 2011 -0700
tree 73164f436b6f6e7966a7ccc9b617e4b14bb294ce
parent 14e1f523c673315cbc3167448ce9252b455d252c
parent 2652b618a86c28fe1914c52dd6a91139c3d9b1e7

Merge "Merge 6f2fb570 from honeycomb. do not merge." into gingerbread

tools/layoutlib/bridge/src/com/android/layoutlib/bridge/android/BridgeTypedArray.java

diff --git a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/android/BridgeTypedArray.java b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/android/BridgeTypedArray.java
index c1d7600..77c1789 100644
--- a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/android/BridgeTypedArray.java
+++ b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/android/BridgeTypedArray.java
@@ -412,9 +412,7 @@
             return LayoutParams.MATCH_PARENT;
         } else if (s.equals(BridgeConstants.WRAP_CONTENT)) {
             return LayoutParams.WRAP_CONTENT;
-        }
-
-        if (RenderResources.REFERENCE_NULL.equals(s)) {
+        } else if (RenderResources.REFERENCE_NULL.equals(s)) {
             return defValue;
         }
 
@@ -486,23 +484,21 @@
             return LayoutParams.MATCH_PARENT;
         } else if (s.equals(BridgeConstants.WRAP_CONTENT)) {
             return LayoutParams.WRAP_CONTENT;
-        }
-
-        if (RenderResources.REFERENCE_NULL.equals(s)) {
+        } else if (RenderResources.REFERENCE_NULL.equals(s)) {
             return defValue;
         }
 
-        // FIXME huh?
-
         float f = getDimension(index, defValue);
         final int res = (int)(f+0.5f);
         if (res != 0) return res;
         if (f == 0) return 0;
-        if (f > 0) return 1;
-
-        Bridge.getLog().error(LayoutLog.TAG_RESOURCES_FORMAT,
-                "Can't convert to dimension: " + Integer.toString(index),
-                null, null /*data*/);
+        if (f > 0) return 1; // this is to support ]0;1[ range (since >=1 is handled 2 lines above)
+        if (f < 0) {
+            // negative values are not allowed in pixel dimensions
+            Bridge.getLog().error(LayoutLog.TAG_BROKEN,
+                    "Negative pixel dimension: " + s,
+                    null, null /*data*/);
+        }
 
         return defValue;
     }

tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/ResourceHelper.java

diff --git a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/ResourceHelper.java b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/ResourceHelper.java
index 69f46e6..649160e 100644
--- a/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/ResourceHelper.java
+++ b/tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/ResourceHelper.java
@@ -377,7 +377,7 @@
         }
 
         // check the first character
-        if (buf[0] < '0' && buf[0] > '9' && buf[0] != '.') {
+        if (buf[0] < '0' && buf[0] > '9' && buf[0] != '.' && buf[0] != '-') {
             return false;
         }