commit | 5a25a84b9efee61787c90deacc3ceb2aedb4fafe | [log] [tgz] |
---|---|---|
author | Stanislav Zholnin <zholnin@google.com> | Wed Mar 13 14:43:26 2019 +0000 |
committer | Stanislav Zholnin <zholnin@google.com> | Wed Mar 13 14:43:26 2019 +0000 |
tree | f8bc3fb42294b604f6773db3086feabed6c5fb31 | |
parent | c7f498fe0bceca283c384ac303422fd8e9d0eccf [diff] [blame] |
Add WRITE_DEVICE_CONFIG permission check to DeviceConfig API. Test: atest FrameworksCoreTests:DeviceConfigTest atest FrameworksCoreTests:SettingsProviderTest atest SettingsProviderTest:DeviceConfigServiceTest Bug:117663715 Change-Id: Iab7dd7959891ebc29fbbf773ce6ab28ba4e05f1d
diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java index 2c2987c..ff25ad9 100644 --- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java +++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
@@ -1103,9 +1103,7 @@ private boolean mutateConfigSetting(String name, String value, String prefix, boolean makeDefault, int operation, int mode) { - - // TODO(b/117663715): Ensure the caller can access the setting. - // enforceReadPermission(WRITE_DEVICE_CONFIG); + enforceWritePermission(Manifest.permission.WRITE_DEVICE_CONFIG); // Perform the mutation. synchronized (mLock) {