commit 5f221e8f93fff70f8a2e192976aac587b8c9c026
author Christopher Tate <ctate@google.com> Tue Jul 30 17:13:15 2013 -0700
committer Christopher Tate <ctate@google.com> Tue Jul 30 18:55:01 2013 -0700
tree d2cceba1c7000755de96502b1346c98d63e87f90
parent f2c89b9ed65116888f1d4a863b7c10c007a49c5d

If you set an alarm before the epoch, you're gonna have a bad time

For apps build against the KLP+ SDK, this will now throw an illegal argument
exception.  Legacy apps will simply see the alarm delivered immediately.

Bug 9965704

Change-Id: Ia103d9529d32640098be324820fe228efa95431d

services/java/com/android/server/AlarmManagerService.java

diff --git a/services/java/com/android/server/AlarmManagerService.java b/services/java/com/android/server/AlarmManagerService.java
index 39c0bdd..1ba79ae 100644
--- a/services/java/com/android/server/AlarmManagerService.java
+++ b/services/java/com/android/server/AlarmManagerService.java
@@ -521,6 +521,14 @@
             throw new IllegalArgumentException("Invalid alarm type " + type);
         }
 
+        if (triggerAtTime < 0) {
+            final long who = Binder.getCallingUid();
+            final long what = Binder.getCallingPid();
+            Slog.w(TAG, "Invalid alarm trigger time! " + triggerAtTime + " from uid=" + who
+                    + " pid=" + what);
+            triggerAtTime = 0;
+        }
+
         final long nowElapsed = SystemClock.elapsedRealtime();
         final long triggerElapsed = convertToElapsed(triggerAtTime, type);
         final long maxElapsed;
@@ -567,7 +575,12 @@
         }
 
         if (DEBUG_VALIDATE) {
-            if (doValidate && validateConsistencyLocked()) {
+            if (doValidate && !validateConsistencyLocked()) {
+                Slog.v(TAG, "Tipping-point operation: type=" + type + " when=" + when
+                        + " when(hex)=" + Long.toHexString(when)
+                        + " whenElapsed=" + whenElapsed + " maxWhen=" + maxWhen
+                        + " interval=" + interval + " op=" + operation
+                        + " standalone=" + isStandalone);
                 rebatchAllAlarmsLocked(false);
                 reschedule = true;
             }
@@ -586,8 +599,9 @@
         final int NZ = mAlarmBatches.size();
         for (int iz = 0; iz < NZ; iz++) {
             Batch bz = mAlarmBatches.get(iz);
-            Slog.v(TAG, "Batch " + iz + ": " + bz);
+            pw.append("Batch "); pw.print(iz); pw.append(": "); pw.println(bz);
             dumpAlarmList(pw, bz.alarms, "  ", nowELAPSED, nowRTC);
+            pw.flush();
             Slog.v(TAG, bs.toString());
             bs.reset();
         }