commit 5fa1ee779e2170fd2e3e96b1e0887f15b04b1f76
author Nick Kralevich <nnk@google.com> Thu Mar 14 16:31:34 2013 -0700
committer Nick Kralevich <nnk@google.com> Thu Mar 14 16:31:34 2013 -0700
tree bb51821e615f0a1b70dc962cbac893106ce9f024
parent f732108e86fcc9825d5ecaa0b65ee91469c4a24c

Don't use ADDR_COMPAT_LAYOUT on the emulator

For the emulator, we want people to see memory as it
actually is, not how we're hacking around buggy apps. Don't
set ADDR_COMPAT_LAYOUT on the emulator.

For reasons that I don't understand, personality(ADDR_COMPAT_LAYOUT)
does not persist across an exec on the emulator. app_main gets
into a tight loop restarting itself because of this. This change
also works around that bug.

Change-Id: Ia73a7d2d623c25cf39d248145d97307945d554da

cmds/app_process/app_main.cpp

diff --git a/cmds/app_process/app_main.cpp b/cmds/app_process/app_main.cpp
index de7931d..b54774e 100644
--- a/cmds/app_process/app_main.cpp
+++ b/cmds/app_process/app_main.cpp
@@ -12,6 +12,7 @@
 #include <utils/Log.h>
 #include <cutils/process_name.h>
 #include <cutils/memory.h>
+#include <cutils/properties.h>
 #include <android_runtime/AndroidRuntime.h>
 #include <sys/personality.h>
 
@@ -143,11 +144,15 @@
      * This breaks some programs which improperly embed
      * an out of date copy of Android's linker.
      */
-    int current = personality(0xFFFFFFFF);
-    if ((current & ADDR_COMPAT_LAYOUT) == 0) {
-        personality(current | ADDR_COMPAT_LAYOUT);
-        execv("/system/bin/app_process", argv);
-        return -1;
+    char value[PROPERTY_VALUE_MAX];
+    property_get("ro.kernel.qemu", value, "");
+    if (strcmp(value, "1") != 0) {
+        int current = personality(0xFFFFFFFF);
+        if ((current & ADDR_COMPAT_LAYOUT) == 0) {
+            personality(current | ADDR_COMPAT_LAYOUT);
+            execv("/system/bin/app_process", argv);
+            return -1;
+        }
     }
 #endif