71200f2c0ec544d1b336a7dce1eccd2c4f40c7ae - platform/frameworks/base

commit	71200f2c0ec544d1b336a7dce1eccd2c4f40c7ae	[log] [tgz]
author	Robert Carr <racarr@google.com>	Tue Feb 05 09:44:53 2019 -0800
committer	Robert Carr <racarr@google.com>	Wed Feb 06 14:02:13 2019 -0800
tree	cc6f84eb3fe9f2c8f56ebfa08b3182f94a7b33e3
parent	5ea304db749591f9bc1357eb486ba5595ac6ff01 [diff]

SurfaceControl: Provide Transaction#remove() method.

When we switched from destroy() to reparent(..., null) we introduced
a regression where the CloseGuard was not released. reparent(..., null) can
not release the CloseGuard because the caller may want to retain the control.
It seems a frustrating burden to require users to write: "reparent(null), release()"
where previously we provided destroy so we provide a helper #remove method.

Test: Existing tests pass
Bug: 123923589
Bug: 122728663
Change-Id: I60b529573f8868624c70b78c7a71a4d7c7827ff7

core/java/android/view/SurfaceControl.java[diff]
services/core/java/com/android/server/wm/AppWindowToken.java[diff]
services/core/java/com/android/server/wm/Dimmer.java[diff]
services/core/java/com/android/server/wm/SurfaceAnimator.java[diff]
services/core/java/com/android/server/wm/WindowContainer.java[diff]
services/tests/wmtests/src/com/android/server/wm/AppWindowTokenAnimationTests.java[diff]
services/tests/wmtests/src/com/android/server/wm/DimmerTests.java[diff]
services/tests/wmtests/src/com/android/server/wm/SurfaceAnimatorTest.java[diff]

8 files changed