commit 7426ec8e7853943dc571db9b60d89c849589beb3
author Greg Kaiser <gkaiser@google.com> Wed Sep 11 14:34:27 2019 -0700
committer Greg Kaiser <gkaiser@google.com> Tue Dec 03 07:37:52 2019 -0800
tree 81e488472ad217863994605398c97d134321c092
parent 0b975928115ca80f4dfb33c9f0418b593d1472c0

BootAnimation: Avoid memory leak in error case

If we fail preloadZip(), we release the animation prior to
returning.

Test: TreeHugger
Change-Id: I632c052ef22b2a7192b516de5726bf4e74544f7a

cmds/bootanimation/BootAnimation.cpp

diff --git a/cmds/bootanimation/BootAnimation.cpp b/cmds/bootanimation/BootAnimation.cpp
index e1cb7ca..a5aa531 100644
--- a/cmds/bootanimation/BootAnimation.cpp
+++ b/cmds/bootanimation/BootAnimation.cpp
@@ -1157,6 +1157,7 @@
 
     parseAnimationDesc(*animation);
     if (!preloadZip(*animation)) {
+        releaseAnimation(animation);
         return nullptr;
     }