commit 7bbf9e720d12c06c46c468f18848b37d61bcaf28
author Jungshik Jang <jayjang@google.com> Thu Aug 07 05:23:48 2014 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Mon Aug 04 23:56:40 2014 +0000
tree dcb158b2e06c5388179fb041442cba9ef06031f1
parent 985e566ceca9c11d2f740499053f37dfaeb9033d
parent 5f75cbd8593e83eaf17cfac07186a3b6a7b7b1f1

Merge "Use message validator for sending message." into lmp-dev

services/core/java/com/android/server/hdmi/HdmiCecMessage.java

diff --git a/services/core/java/com/android/server/hdmi/HdmiCecMessage.java b/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
index 26071e6..433e93f 100644
--- a/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
+++ b/services/core/java/com/android/server/hdmi/HdmiCecMessage.java
@@ -28,8 +28,6 @@
 public final class HdmiCecMessage {
     public static final byte[] EMPTY_PARAM = EmptyArray.BYTE;
 
-    private static final int MAX_MESSAGE_PARAM_LENGTH = 14;
-
     private final int mSource;
     private final int mDestination;
 
@@ -43,12 +41,6 @@
         mSource = source;
         mDestination = destination;
         mOpcode = opcode & 0xFF;
-
-        if (params.length > MAX_MESSAGE_PARAM_LENGTH) {
-            throw new IllegalArgumentException(
-                    "Param length should be at most 13 but current param length is "
-                    + params.length);
-        }
         mParams = Arrays.copyOf(params, params.length);
     }
 

services/core/java/com/android/server/hdmi/HdmiControlService.java

diff --git a/services/core/java/com/android/server/hdmi/HdmiControlService.java b/services/core/java/com/android/server/hdmi/HdmiControlService.java
index 3017d2d..e8d8192 100644
--- a/services/core/java/com/android/server/hdmi/HdmiControlService.java
+++ b/services/core/java/com/android/server/hdmi/HdmiControlService.java
@@ -517,13 +517,20 @@
     @ServiceThreadOnly
     void sendCecCommand(HdmiCecMessage command, @Nullable SendMessageCallback callback) {
         assertRunOnServiceThread();
-        mCecController.sendCommand(command, callback);
+        if (mMessageValidator.isValid(command)) {
+            mCecController.sendCommand(command, callback);
+        } else {
+            Slog.e(TAG, "Invalid message type:" + command);
+            if (callback != null) {
+                callback.onSendCompleted(Constants.SEND_RESULT_FAILURE);
+            }
+        }
     }
 
     @ServiceThreadOnly
     void sendCecCommand(HdmiCecMessage command) {
         assertRunOnServiceThread();
-        mCecController.sendCommand(command, null);
+        sendCecCommand(command, null);
     }
 
     /**