commit 7f668d03ceec1ce1732f51cfe9828e6376bbecbc
author Adam Lesinski <adamlesinski@google.com> Thu Aug 28 18:32:32 2014 -0700
committer Adam Lesinski <adamlesinski@google.com> Thu Aug 28 18:32:32 2014 -0700
tree fc6c026c372a9d8b7e32dcf81e1bf36a2d5aa3b2
parent 01abcaa295fc4eec7442a575d160b0ce2c250127

Fix memory leak in ResTable

We were basically never cleaning any of the
cached bags... oops :S

Bug:16683269
Change-Id: Ic0a44218f660e16fbaac8df1d61ce6f1fdb0018b

libs/androidfw/ResourceTypes.cpp

diff --git a/libs/androidfw/ResourceTypes.cpp b/libs/androidfw/ResourceTypes.cpp
index 3f014ef..0ee6e03 100644
--- a/libs/androidfw/ResourceTypes.cpp
+++ b/libs/androidfw/ResourceTypes.cpp
@@ -2939,7 +2939,7 @@
             for (size_t i = 0; i < bags->size(); i++) {
                 TABLE_NOISY(printf("type=%d\n", i));
                 const TypeList& typeList = types[i];
-                if (typeList.isEmpty()) {
+                if (!typeList.isEmpty()) {
                     bag_set** typeBags = bags->get(i);
                     TABLE_NOISY(printf("typeBags=%p\n", typeBags));
                     if (typeBags) {