commit 83427ff2224c89cc1a590ea609206c95c8ee039e
author Yuqian Li <liyuqian@google.com> Wed Sep 14 11:14:06 2016 -0400
committer Yuqian Li <liyuqian@google.com> Wed Sep 14 11:44:10 2016 -0400
tree 28b89517ad0d6c7d298c650faae95e11a35579d5
parent 4efd735a7605a88bcf0228de94d99a563b0f64d8

Ignore HasAlphaLayer flag to fix b/30929229

BUG:30929229
Change-Id: Iebadc6b3d224efa0554cbbb99ea43f871c28722b

libs/hwui/SkiaCanvas.cpp

diff --git a/libs/hwui/SkiaCanvas.cpp b/libs/hwui/SkiaCanvas.cpp
index ce67554..c7289fc 100644
--- a/libs/hwui/SkiaCanvas.cpp
+++ b/libs/hwui/SkiaCanvas.cpp
@@ -329,9 +329,10 @@
 static inline SkCanvas::SaveLayerFlags layerFlags(SaveFlags::Flags flags) {
     SkCanvas::SaveLayerFlags layerFlags = 0;
 
-    if (!(flags & SaveFlags::HasAlphaLayer)) {
-        layerFlags |= SkCanvas::kIsOpaque_SaveLayerFlag;
-    }
+    // We intentionally ignore the SaveFlags::HasAlphaLayer and
+    // SkCanvas::kIsOpaque_SaveLayerFlag flags because HWUI ignores it
+    // and our Android client may use it incorrectly.
+    // In Skia, this flag is purely for performance optimization.
 
     if (!(flags & SaveFlags::ClipToLayer)) {
         layerFlags |= SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag;