Adding missing break statements causing crash on MSG_SET_EXTRAS.
The case block for MSG_SET_EXTRAS was missing its break statement, all
the way back to summer 2015 when that code was originally added.
When the new MSG_ON_CONNECTION_EVENT handler was added, it introduced a
new potential fall-through from MSG_SET_EXTRAS (in addition to the fact it
too was missing a break statement).
Bug: 27338441
Change-Id: I2df2bc78c4ceb32e6245888eed18c2d8834e629b
diff --git a/telecomm/java/android/telecom/ConnectionServiceAdapterServant.java b/telecomm/java/android/telecom/ConnectionServiceAdapterServant.java
index a790914..6a8c1cb 100644
--- a/telecomm/java/android/telecom/ConnectionServiceAdapterServant.java
+++ b/telecomm/java/android/telecom/ConnectionServiceAdapterServant.java
@@ -240,8 +240,8 @@
} finally {
args.recycle();
}
+ break;
}
-
case MSG_ON_CONNECTION_EVENT: {
SomeArgs args = (SomeArgs) msg.obj;
try {
@@ -249,6 +249,7 @@
} finally {
args.recycle();
}
+ break;
}
}
}