Unify ActivityStack extend Task (84/n)
Step towards merging stacks into tasks.
Test: Existing tests pass.
Bug: 80414790
Change-Id: Ifb167129c89a3aba11796daa21a9dee7200913ca
diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java b/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java
index ad63d07..c60ca48 100644
--- a/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java
@@ -123,13 +123,13 @@
@Test
public void testStackCleanupOnClearingTask() {
mActivity.onParentChanged(null /*newParent*/, mActivity.getTask());
- verify(mStack, times(1)).onActivityRemovedFromStack(any());
+ verify(mStack, times(1)).cleanUpActivityReferences(any());
}
@Test
public void testStackCleanupOnActivityRemoval() {
mTask.removeChild(mActivity);
- verify(mStack, times(1)).onActivityRemovedFromStack(any());
+ verify(mStack, times(1)).cleanUpActivityReferences(any());
}
@Test
@@ -141,10 +141,9 @@
@Test
public void testNoCleanupMovingActivityInSameStack() {
- final Task newTask = new TaskBuilder(mService.mStackSupervisor).setStack(mStack)
- .build();
+ final Task newTask = new TaskBuilder(mService.mStackSupervisor).setStack(mStack).build();
mActivity.reparent(newTask, 0, null /*reason*/);
- verify(mStack, times(0)).onActivityRemovedFromStack(any());
+ verify(mStack, times(0)).cleanUpActivityReferences(any());
}
@Test
@@ -490,7 +489,7 @@
final ActivityStack stack = new StackBuilder(mRootWindowContainer).build();
try {
- doReturn(false).when(stack).isStackTranslucent(any());
+ doReturn(false).when(stack).isTranslucent(any());
assertFalse(mStack.shouldBeVisible(null /* starting */));
mActivity.setLastReportedConfiguration(new MergedConfiguration(new Configuration(),
@@ -613,8 +612,7 @@
// Sending 'null' for saved state can only happen due to timeout, so previously stored saved
// states should not be overridden.
mActivity.setState(STOPPING, "test");
- mActivity.activityStopped(null /* savedState */, null /* persistentSavedState */,
- "desc");
+ mActivity.activityStopped(null /* savedState */, null /* persistentSavedState */, "desc");
assertTrue(mActivity.hasSavedState());
assertEquals(savedState, mActivity.getSavedState());
assertEquals(persistentSavedState, mActivity.getPersistentSavedState());
@@ -1013,7 +1011,9 @@
public void testDestroyIfPossible_lastActivityAboveEmptyHomeStack() {
// Empty the home stack.
final ActivityStack homeStack = mActivity.getDisplay().getHomeStack();
- homeStack.forAllTasks((t) -> { homeStack.removeChild(t, "test"); });
+ homeStack.forAllTasks((t) -> {
+ homeStack.removeChild(t, "test");
+ }, true /* traverseTopToBottom */, homeStack);
mActivity.finishing = true;
doReturn(false).when(mRootWindowContainer).resumeFocusedStacksTopActivities();
spyOn(mStack);
@@ -1037,7 +1037,9 @@
public void testCompleteFinishing_lastActivityAboveEmptyHomeStack() {
// Empty the home stack.
final ActivityStack homeStack = mActivity.getDisplay().getHomeStack();
- homeStack.forAllTasks((t) -> { homeStack.removeChild(t, "test"); });
+ homeStack.forAllTasks((t) -> {
+ homeStack.removeChild(t, "test");
+ }, true /* traverseTopToBottom */, homeStack);
mActivity.finishing = true;
spyOn(mStack);
@@ -1143,7 +1145,7 @@
assertNull(mActivity.app);
assertNull(mActivity.getTask());
assertEquals(0, task.getChildCount());
- assertNull(task.getStack());
+ assertEquals(task.getStack(), task);
assertEquals(0, stack.getChildCount());
}
diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityStackTests.java b/services/tests/wmtests/src/com/android/server/wm/ActivityStackTests.java
index a5157fe9..393d8b8 100644
--- a/services/tests/wmtests/src/com/android/server/wm/ActivityStackTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/ActivityStackTests.java
@@ -313,13 +313,13 @@
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_STANDARD, true /* onTop */);
// Home stack shouldn't be visible behind an opaque fullscreen stack, but pinned stack
// should be visible since it is always on-top.
- doReturn(false).when(fullscreenStack).isStackTranslucent(any());
+ doReturn(false).when(fullscreenStack).isTranslucent(any());
assertFalse(homeStack.shouldBeVisible(null /* starting */));
assertTrue(pinnedStack.shouldBeVisible(null /* starting */));
assertTrue(fullscreenStack.shouldBeVisible(null /* starting */));
// Home stack should be visible behind a translucent fullscreen stack.
- doReturn(true).when(fullscreenStack).isStackTranslucent(any());
+ doReturn(true).when(fullscreenStack).isTranslucent(any());
assertTrue(homeStack.shouldBeVisible(null /* starting */));
assertTrue(pinnedStack.shouldBeVisible(null /* starting */));
}
@@ -338,8 +338,8 @@
WINDOWING_MODE_SPLIT_SCREEN_SECONDARY, ACTIVITY_TYPE_STANDARD, true /* onTop */);
// Home stack shouldn't be visible if both halves of split-screen are opaque.
- doReturn(false).when(splitScreenPrimary).isStackTranslucent(any());
- doReturn(false).when(splitScreenSecondary).isStackTranslucent(any());
+ doReturn(false).when(splitScreenPrimary).isTranslucent(any());
+ doReturn(false).when(splitScreenSecondary).isTranslucent(any());
assertFalse(homeStack.shouldBeVisible(null /* starting */));
assertTrue(splitScreenPrimary.shouldBeVisible(null /* starting */));
assertTrue(splitScreenSecondary.shouldBeVisible(null /* starting */));
@@ -350,7 +350,7 @@
splitScreenSecondary.getVisibility(null /* starting */));
// Home stack should be visible if one of the halves of split-screen is translucent.
- doReturn(true).when(splitScreenPrimary).isStackTranslucent(any());
+ doReturn(true).when(splitScreenPrimary).isTranslucent(any());
assertTrue(homeStack.shouldBeVisible(null /* starting */));
assertTrue(splitScreenPrimary.shouldBeVisible(null /* starting */));
assertTrue(splitScreenSecondary.shouldBeVisible(null /* starting */));
@@ -366,7 +366,7 @@
WINDOWING_MODE_SPLIT_SCREEN_SECONDARY, ACTIVITY_TYPE_STANDARD, true /* onTop */);
// First split-screen secondary shouldn't be visible behind another opaque split-split
// secondary.
- doReturn(false).when(splitScreenSecondary2).isStackTranslucent(any());
+ doReturn(false).when(splitScreenSecondary2).isTranslucent(any());
assertFalse(splitScreenSecondary.shouldBeVisible(null /* starting */));
assertTrue(splitScreenSecondary2.shouldBeVisible(null /* starting */));
assertEquals(STACK_VISIBILITY_INVISIBLE,
@@ -376,7 +376,7 @@
// First split-screen secondary should be visible behind another translucent split-screen
// secondary.
- doReturn(true).when(splitScreenSecondary2).isStackTranslucent(any());
+ doReturn(true).when(splitScreenSecondary2).isTranslucent(any());
assertTrue(splitScreenSecondary.shouldBeVisible(null /* starting */));
assertTrue(splitScreenSecondary2.shouldBeVisible(null /* starting */));
assertEquals(STACK_VISIBILITY_VISIBLE_BEHIND_TRANSLUCENT,
@@ -388,7 +388,7 @@
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_ASSISTANT, true /* onTop */);
// Split-screen stacks shouldn't be visible behind an opaque fullscreen stack.
- doReturn(false).when(assistantStack).isStackTranslucent(any());
+ doReturn(false).when(assistantStack).isTranslucent(any());
assertTrue(assistantStack.shouldBeVisible(null /* starting */));
assertFalse(splitScreenPrimary.shouldBeVisible(null /* starting */));
assertFalse(splitScreenSecondary.shouldBeVisible(null /* starting */));
@@ -403,7 +403,7 @@
splitScreenSecondary2.getVisibility(null /* starting */));
// Split-screen stacks should be visible behind a translucent fullscreen stack.
- doReturn(true).when(assistantStack).isStackTranslucent(any());
+ doReturn(true).when(assistantStack).isTranslucent(any());
assertTrue(assistantStack.shouldBeVisible(null /* starting */));
assertTrue(splitScreenPrimary.shouldBeVisible(null /* starting */));
assertTrue(splitScreenSecondary.shouldBeVisible(null /* starting */));
@@ -418,9 +418,9 @@
splitScreenSecondary2.getVisibility(null /* starting */));
// Assistant stack shouldn't be visible behind translucent split-screen stack
- doReturn(false).when(assistantStack).isStackTranslucent(any());
- doReturn(true).when(splitScreenPrimary).isStackTranslucent(any());
- doReturn(true).when(splitScreenSecondary2).isStackTranslucent(any());
+ doReturn(false).when(assistantStack).isTranslucent(any());
+ doReturn(true).when(splitScreenPrimary).isTranslucent(any());
+ doReturn(true).when(splitScreenSecondary2).isTranslucent(any());
splitScreenSecondary2.moveToFront("testShouldBeVisible_SplitScreen");
splitScreenPrimary.moveToFront("testShouldBeVisible_SplitScreen");
assertFalse(assistantStack.shouldBeVisible(null /* starting */));
@@ -555,7 +555,7 @@
final ActivityStack translucentStack = createStackForShouldBeVisibleTest(
mDefaultDisplay, WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_STANDARD,
true /* onTop */);
- doReturn(true).when(translucentStack).isStackTranslucent(any());
+ doReturn(true).when(translucentStack).isTranslucent(any());
assertTrue(homeStack.shouldBeVisible(null /* starting */));
assertTrue(translucentStack.shouldBeVisible(null /* starting */));
@@ -603,8 +603,8 @@
final ActivityStack fullscreenStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_STANDARD, true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(false).when(fullscreenStack).isTranslucent(any());
// Ensure that we don't move the home stack if it is already behind the top fullscreen stack
int homeStackIndex = mDefaultDisplay.getIndexOf(homeStack);
@@ -622,8 +622,8 @@
final ActivityStack fullscreenStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_STANDARD, true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(true).when(fullscreenStack).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(true).when(fullscreenStack).isTranslucent(any());
// Ensure that we don't move the home stack if it is already behind the top fullscreen stack
int homeStackIndex = mDefaultDisplay.getIndexOf(homeStack);
@@ -641,8 +641,8 @@
final ActivityStack homeStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_HOME, true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(false).when(fullscreenStack).isTranslucent(any());
// Ensure we don't move the home stack if it is already on top
int homeStackIndex = mDefaultDisplay.getIndexOf(homeStack);
@@ -666,9 +666,9 @@
final ActivityStack pinnedStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_PINNED, ACTIVITY_TYPE_STANDARD, true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack1).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack2).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(false).when(fullscreenStack1).isTranslucent(any());
+ doReturn(false).when(fullscreenStack2).isTranslucent(any());
// Ensure that we move the home stack behind the bottom most fullscreen stack, ignoring the
// pinned stack
@@ -691,9 +691,9 @@
mDefaultDisplay, WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_STANDARD,
true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack1).isStackTranslucent(any());
- doReturn(true).when(fullscreenStack2).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(false).when(fullscreenStack1).isTranslucent(any());
+ doReturn(true).when(fullscreenStack2).isTranslucent(any());
// Ensure that we move the home stack behind the bottom most non-translucent fullscreen
// stack
@@ -715,9 +715,9 @@
final ActivityStack homeStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_HOME, true /* onTop */);
- doReturn(false).when(homeStack).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack1).isStackTranslucent(any());
- doReturn(false).when(fullscreenStack2).isStackTranslucent(any());
+ doReturn(false).when(homeStack).isTranslucent(any());
+ doReturn(false).when(fullscreenStack1).isTranslucent(any());
+ doReturn(false).when(fullscreenStack2).isTranslucent(any());
// Ensure we don't move the home stack behind itself
int homeStackIndex = mDefaultDisplay.getIndexOf(homeStack);
@@ -810,9 +810,9 @@
final ActivityStack assistantStack = createStackForShouldBeVisibleTest(mDefaultDisplay,
WINDOWING_MODE_FULLSCREEN, ACTIVITY_TYPE_ASSISTANT, true /* onTop */);
- doReturn(false).when(splitScreenPrimary).isStackTranslucent(any());
- doReturn(false).when(splitScreenSecondary).isStackTranslucent(any());
- doReturn(false).when(assistantStack).isStackTranslucent(any());
+ doReturn(false).when(splitScreenPrimary).isTranslucent(any());
+ doReturn(false).when(splitScreenSecondary).isTranslucent(any());
+ doReturn(false).when(assistantStack).isTranslucent(any());
assertFalse(splitScreenPrimary.shouldBeVisible(null /* starting */));
assertFalse(splitScreenSecondary.shouldBeVisible(null /* starting */));
@@ -829,7 +829,7 @@
boolean translucent) {
final ActivityStack stack = createStackForShouldBeVisibleTest(mDefaultDisplay,
windowingMode, ACTIVITY_TYPE_STANDARD, true /* onTop */);
- doReturn(translucent).when(stack).isStackTranslucent(any());
+ doReturn(translucent).when(stack).isTranslucent(any());
return stack;
}
diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityTestsBase.java b/services/tests/wmtests/src/com/android/server/wm/ActivityTestsBase.java
index 4beede9..eb84d0a 100644
--- a/services/tests/wmtests/src/com/android/server/wm/ActivityTestsBase.java
+++ b/services/tests/wmtests/src/com/android/server/wm/ActivityTestsBase.java
@@ -375,7 +375,7 @@
intent.setComponent(mComponent);
intent.setFlags(mFlags);
- final Task task = new Task(mSupervisor.mService, mTaskId, aInfo,
+ final Task task = new ActivityStack(mSupervisor.mService, mTaskId, aInfo,
intent /*intent*/, mVoiceSession, null /*_voiceInteractor*/,
null /*taskDescription*/, mStack);
spyOn(task);
@@ -398,6 +398,8 @@
private int mActivityType = ACTIVITY_TYPE_STANDARD;
private boolean mOnTop = true;
private boolean mCreateActivity = true;
+ private ActivityInfo mInfo;
+ private Intent mIntent;
StackBuilder(RootWindowContainer root) {
mRootWindowContainer = root;
@@ -434,13 +436,22 @@
return this;
}
+ StackBuilder setActivityInfo(ActivityInfo info) {
+ mInfo = info;
+ return this;
+ }
+
+ StackBuilder setIntent(Intent intent) {
+ mIntent = intent;
+ return this;
+ }
+
ActivityStack build() {
final int stackId = mStackId >= 0 ? mStackId : mDisplay.getNextStackId();
- final ActivityStack stack;
+ final ActivityStack stack = mDisplay.createStackUnchecked(mWindowingMode,
+ mActivityType, stackId, mOnTop, mInfo, mIntent);
final ActivityStackSupervisor supervisor = mRootWindowContainer.mStackSupervisor;
- stack = mDisplay.createStackUnchecked(mWindowingMode, mActivityType, stackId, mOnTop);
-
if (mCreateActivity) {
new ActivityBuilder(supervisor.mService)
.setCreateTask(true)
diff --git a/services/tests/wmtests/src/com/android/server/wm/TaskRecordTests.java b/services/tests/wmtests/src/com/android/server/wm/TaskRecordTests.java
index 9562fa4..fa0485c 100644
--- a/services/tests/wmtests/src/com/android/server/wm/TaskRecordTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/TaskRecordTests.java
@@ -152,6 +152,8 @@
@Test
public void testReturnsToHomeStack() throws Exception {
final Task task = createTask(1);
+ spyOn(task);
+ doReturn(true).when(task).hasChild();
assertFalse(task.returnsToHomeStack());
task.intent = null;
assertFalse(task.returnsToHomeStack());
@@ -906,7 +908,7 @@
}
private Task createTask(int taskId) {
- return new Task(mService, taskId, new Intent(), null, null, null,
+ return new ActivityStack(mService, taskId, new Intent(), null, null, null,
ActivityBuilder.getDefaultComponent(), null, false, false, false, 0, 10050, null,
0, false, null, 0, 0, 0, 0, 0, null, 0, false, false, false, 0,
0, null /*ActivityInfo*/, null /*_voiceSession*/, null /*_voiceInteractor*/,
diff --git a/services/tests/wmtests/src/com/android/server/wm/TaskStackTests.java b/services/tests/wmtests/src/com/android/server/wm/TaskStackTests.java
index b4f5751..6e4be88 100644
--- a/services/tests/wmtests/src/com/android/server/wm/TaskStackTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/TaskStackTests.java
@@ -115,7 +115,7 @@
// Remove stack and check if its child is also removed.
stack.removeImmediately();
assertNull(stack.getDisplayContent());
- assertNull(task.getStack());
+ assertNull(task.getParent());
}
@Test
@@ -131,7 +131,7 @@
assertEquals(0, stack.getChildCount());
assertNull(stack.getDisplayContent());
assertNull(task.getDisplayContent());
- assertNull(task.getStack());
+ assertNull(task.getParent());
}
@Test
@@ -140,6 +140,7 @@
final Task task = createTaskInStack(stack, 0 /* userId */);
// Stack removal is deferred if one of its child is animating.
+ doReturn(true).when(stack).hasWindowsAlive();
doReturn(true).when(task).isAnimating(TRANSITION | CHILDREN);
stack.removeIfPossible();