Two WebView API cleanups
- remove final from classes which we will need to provide subclasses
in future: CookieManager, GeolocationPermissions, WebIconDatabase
and WebStorage. None of these have published constructors,
so applications cannot subclass them anyway.
- Also convert some protected members of JsResult to private, as its of
no use to legal subclasses, and applications cannot subclass it.
Change-Id: Iaca9d2db31e25853b6c55feae41d9e7774087479
diff --git a/core/java/android/webkit/JsResult.java b/core/java/android/webkit/JsResult.java
index 07b686f..e4e6851 100644
--- a/core/java/android/webkit/JsResult.java
+++ b/core/java/android/webkit/JsResult.java
@@ -22,8 +22,6 @@
* and provides a means for the client to indicate whether this action should proceed.
*/
public class JsResult {
- // This is a basic result of a confirm or prompt dialog.
- protected boolean mResult;
/**
* Callback interface, implemented by the WebViewProvider implementation to receive
* notifications when the JavaScript result represented by a JsResult instance has
@@ -32,11 +30,10 @@
public interface ResultReceiver {
public void onJsResultComplete(JsResult result);
}
- /**
- * This is the caller of the prompt and is the object that is waiting.
- * @hide
- */
- protected final ResultReceiver mReceiver;
+ // This is the caller of the prompt and is the object that is waiting.
+ private final ResultReceiver mReceiver;
+ // This is a basic result of a confirm or prompt dialog.
+ private boolean mResult;
/**
* Handle the result if the user cancelled the dialog.
@@ -69,7 +66,7 @@
}
/* Notify the caller that the JsResult has completed */
- protected final void wakeUp() {
+ private final void wakeUp() {
mReceiver.onJsResultComplete(this);
}
}