commit a4d036e98b4c93dc1155912eaf66af3df5dcacb3
author Treehugger Robot <treehugger-gerrit@google.com> Mon Dec 17 07:43:34 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Dec 17 07:43:34 2018 +0000
tree 916e1f8f2a9e5f12457f9adab9edaef43b816560
parent 783ec049091357ae892d4c62e4e75008734815e7
parent d9765a4cc05464d4082dac79585dccf4b11aa7ea

Merge "fd_utils: carry over O_CLOEXEC on duplicated FDs"

core/jni/fd_utils.cpp

diff --git a/core/jni/fd_utils.cpp b/core/jni/fd_utils.cpp
index d457a1b..a03e929 100644
--- a/core/jni/fd_utils.cpp
+++ b/core/jni/fd_utils.cpp
@@ -327,11 +327,13 @@
     return false;
   }
 
-  if (TEMP_FAILURE_RETRY(dup2(new_fd, fd)) == -1) {
+  int dupFlags = (fd_flags & FD_CLOEXEC) ? O_CLOEXEC : 0;
+  if (TEMP_FAILURE_RETRY(dup3(new_fd, fd, dupFlags)) == -1) {
     close(new_fd);
-    *error_msg = android::base::StringPrintf("Failed dup2(%d, %d) (%s): %s",
+    *error_msg = android::base::StringPrintf("Failed dup3(%d, %d, %d) (%s): %s",
                                              fd,
                                              new_fd,
+                                             dupFlags,
                                              file_path.c_str(),
                                              strerror(errno));
     return false;