commit a6238ef3891bbbdb1c42d3e7954c4cd55527cef6
author Andy Hung <hunga@google.com> Fri May 15 18:39:09 2015 -0700
committer Andy Hung <hunga@google.com> Fri May 15 18:43:03 2015 -0700
tree acb92a0ce2d1f1b3144759c5b8cf86508ee69049
parent 0125d76fa37d26a29f06371ff349546e21cd3f4d

Fix SoundPool.unload() return value

Bug: 21209627
Change-Id: Ifd5c5f349894744c192cad10c5c875882566ec53

media/jni/soundpool/SoundPool.cpp

diff --git a/media/jni/soundpool/SoundPool.cpp b/media/jni/soundpool/SoundPool.cpp
index 6c1bd97..8038cdf 100644
--- a/media/jni/soundpool/SoundPool.cpp
+++ b/media/jni/soundpool/SoundPool.cpp
@@ -229,7 +229,7 @@
 {
     ALOGV("unload: sampleID=%d", sampleID);
     Mutex::Autolock lock(&mLock);
-    return mSamples.removeItem(sampleID);
+    return mSamples.removeItem(sampleID) >= 0; // removeItem() returns index or BAD_VALUE
 }
 
 int SoundPool::play(int sampleID, float leftVolume, float rightVolume,