commit bb131f52daf0792c3f1566df992024d5d7640f25
author Dianne Hackborn <hackbod@google.com> Sat Mar 16 01:59:29 2013 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Sat Mar 16 01:59:29 2013 +0000
tree de73eea594a7d08aa73916e31df3c1775165fa87
parent 2e6ce4f737dcdeb748f467836dd12490c0cdfd22
parent 282add7bc3e80825c73244f527857aefa74093a9

Merge "Fix issue #8401553: It's possible to startForeground()..." into jb-mr2-dev

services/java/com/android/server/am/ServiceRecord.java

diff --git a/services/java/com/android/server/am/ServiceRecord.java b/services/java/com/android/server/am/ServiceRecord.java
index b06c60a..1ac6bdf 100644
--- a/services/java/com/android/server/am/ServiceRecord.java
+++ b/services/java/com/android/server/am/ServiceRecord.java
@@ -368,6 +368,13 @@
                         return;
                     }
                     try {
+                        if (foregroundNoti.icon == 0) {
+                            // Notifications whose icon is 0 are defined to not show
+                            // a notification, silently ignoring it.  We don't want to
+                            // just ignore it, we want to prevent the service from
+                            // being foreground.
+                            throw new RuntimeException("icon must be non-zero");
+                        }
                         int[] outId = new int[1];
                         nm.enqueueNotificationInternal(localPackageName, localPackageName,
                                 appUid, appPid, null, localForegroundId, localForegroundNoti,