commit c72c9d17c54346157604beb8f049d581bd33d721
author Zim <zezeozue@google.com> Wed Nov 27 15:49:33 2019 +0000
committer Zim <zezeozue@google.com> Wed Nov 27 16:28:47 2019 +0000
tree 5d1b0a7c2ce37c98144fa7bc6d6337f3cb92e897
parent 0f2b7fd29a37f35864e7bd3138d3d0b98704faec

Disable resetting OP_LEGACY_STORAGE

When app preferences are reset AppOpsService toggles the appops for
all apps. This gives the Op watchers a chance to reset any state.

For OP_LEGACY_STORAGE case, the StorageManagerService listens for
changes so it can remount the appropriate storage view for the app.
This remount operation is expensive and unnecessary when resetting
app preferences because the view would not change at the end of the
reset.

Test: No remount uid logs from op changes when resetting app preferences
Bug: 141678467
Change-Id: I86c36786652b36504e624e3f021ad73396328c5d

core/java/android/app/AppOpsManager.java

diff --git a/core/java/android/app/AppOpsManager.java b/core/java/android/app/AppOpsManager.java
index 5032f77..f2fa4fd 100644
--- a/core/java/android/app/AppOpsManager.java
+++ b/core/java/android/app/AppOpsManager.java
@@ -2008,7 +2008,7 @@
             false, // WRITE_MEDIA_VIDEO
             false, // READ_MEDIA_IMAGES
             false, // WRITE_MEDIA_IMAGES
-            false, // LEGACY_STORAGE
+            true,  // LEGACY_STORAGE
             false, // ACCESS_ACCESSIBILITY
             false, // READ_DEVICE_IDENTIFIERS
             false, // ACCESS_MEDIA_LOCATION