commit c9ade202ed6a43a4edba6596492aa810530b88b6
author Romain Guy <romainguy@google.com> Mon May 14 15:38:52 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Mon May 14 15:38:52 2012 -0700
tree ff77118843e0e4b1f05509fb503d9fb7d94fca56
parent 2be45697f93291e1740c3b7e4ba0af5d4ae81ed6
parent 99a6ddd4cd8762654a575eb4ac3d0e5431d919b8

Merge "Forget the name of a texture after freeing Bug #6408362" into jb-dev

libs/hwui/FontRenderer.cpp

diff --git a/libs/hwui/FontRenderer.cpp b/libs/hwui/FontRenderer.cpp
index b7d09db..a0bf8e3 100644
--- a/libs/hwui/FontRenderer.cpp
+++ b/libs/hwui/FontRenderer.cpp
@@ -555,6 +555,7 @@
         glDeleteTextures(1, &cacheTexture->mTextureId);
         delete[] cacheTexture->mTexture;
         cacheTexture->mTexture = NULL;
+        cacheTexture->mTextureId = 0;
     }
 }
 
@@ -589,7 +590,13 @@
     int height = cacheTexture->mHeight;
 
     cacheTexture->mTexture = new uint8_t[width * height];
+#if DEBUG_FONT_RENDERER
     memset(cacheTexture->mTexture, 0, width * height * sizeof(uint8_t));
+#endif
+
+    if (!cacheTexture->mTextureId) {
+        glGenTextures(1, &cacheTexture->mTextureId);
+    }
 
     glBindTexture(GL_TEXTURE_2D, cacheTexture->mTextureId);
     glPixelStorei(GL_UNPACK_ALIGNMENT, 1);
@@ -680,11 +687,8 @@
 }
 
 CacheTexture* FontRenderer::createCacheTexture(int width, int height, bool allocate) {
-    GLuint textureId;
-    glGenTextures(1, &textureId);
-
     uint8_t* textureMemory = NULL;
-    CacheTexture* cacheTexture = new CacheTexture(textureMemory, textureId, width, height);
+    CacheTexture* cacheTexture = new CacheTexture(textureMemory, width, height);
 
     if (allocate) {
         allocateTextureMemory(cacheTexture);

libs/hwui/FontRenderer.h

diff --git a/libs/hwui/FontRenderer.h b/libs/hwui/FontRenderer.h
index 4de4af2..2ab680e 100644
--- a/libs/hwui/FontRenderer.h
+++ b/libs/hwui/FontRenderer.h
@@ -62,8 +62,8 @@
 class CacheTexture {
 public:
     CacheTexture() { }
-    CacheTexture(uint8_t* texture, GLuint textureId, uint16_t width, uint16_t height) :
-            mTexture(texture), mTextureId(textureId), mWidth(width), mHeight(height),
+    CacheTexture(uint8_t* texture, uint16_t width, uint16_t height) :
+            mTexture(texture), mTextureId(0), mWidth(width), mHeight(height),
             mLinearFiltering(false) { }
     ~CacheTexture() {
         if (mTexture) {