Move calc of EriIconIndex/Mode to whenever basis changes

We need this info in the ServiceState, but rather than calcing it every time
a ServiceState is requested, we can update the values whenever the constituents
change.

bug: 2182568
2 files changed