tree ae6950f3848b02eb981d851d448ce0b37b507d1d
parent c19e3196619eeddef6ed03d3760239a74667adcd
author Tony Mak <tonymak@google.com> 1566483268 +0100
committer Tony Mak <tonymak@google.com> 1566483429 +0100

Hold a strong reference to the callback in TextClassifierService

Issue:
TextClassifierService failed to invoke the callback to send the result back
to client occasionally because  the callback object may be GCed.
And thus smart selection failed occasionally, as the client doesn't get
a response back when it hits this issue. It won't fallback to local
textclassifier due to the timeout specified in TextView.

Cause:
We thought that ITextClassifierCallback is a "cross process" reference, and
so we only store a weak reference of it to avoid leak.
And it turns out that it is wrong. As soon as the weak ref gets GCed in
the service, that counts as dropping the callback. The service doesn't
know about any strong references the client has.

Bug: 138865849

Test: Try smart selection over 30 times, make sure smart action is shown
for every single time.

Change-Id: Ia9218cf67e8d67697a0fdff22c7918a55efc39ca