commit d7674c2be5e6024b5a4d66a30472744f9998c7cc
author Stanislav Zholnin <zholnin@google.com> Mon Feb 17 17:48:12 2020 +0000
committer Stanislav Zholnin <zholnin@google.com> Mon Feb 17 17:48:12 2020 +0000
tree c3d4d06653dc5e9ff29095ebc255f91ab0d583dd
parent 8cde2c812e0d81ad4dbdf5f7f906a92bdbcd8d7f

Fix bug in StatsService which prevents any shell command from execution.

Bug: 149691126
Test: adb shell cmd stats
Change-Id: I71befdd02e61de0f39cdff9694d4ab07abb1799c

cmds/statsd/src/StatsService.cpp

diff --git a/cmds/statsd/src/StatsService.cpp b/cmds/statsd/src/StatsService.cpp
index 7087c68..7ab6c71 100644
--- a/cmds/statsd/src/StatsService.cpp
+++ b/cmds/statsd/src/StatsService.cpp
@@ -280,7 +280,7 @@
 status_t StatsService::handleShellCommand(int in, int out, int err, const char** argv,
                                           uint32_t argc) {
     uid_t uid = AIBinder_getCallingUid();
-    if (uid != AID_ROOT || uid != AID_SHELL) {
+    if (uid != AID_ROOT && uid != AID_SHELL) {
         return PERMISSION_DENIED;
     }