commit db4ce8705911e36a36f0a2f36b8bf9e04d78a2d3
author Junyu Lai <junyulai@google.com> Mon Jan 21 03:48:15 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Jan 21 03:48:15 2019 +0000
tree 28dbe0c346e06dd049a2f60aae49bfb974e7f039
parent 1f4cce2f198308a0c8ee375503225ed1f6e1f2f4
parent 5e7128d77dde7ee1cfceaafb331893495f04730c

Merge "Remove dead KeepaliveInfo if it cannot be started"

services/core/java/com/android/server/connectivity/KeepaliveTracker.java

diff --git a/services/core/java/com/android/server/connectivity/KeepaliveTracker.java b/services/core/java/com/android/server/connectivity/KeepaliveTracker.java
index 0f8fc17..8a3cdca 100644
--- a/services/core/java/com/android/server/connectivity/KeepaliveTracker.java
+++ b/services/core/java/com/android/server/connectivity/KeepaliveTracker.java
@@ -185,13 +185,13 @@
         }
 
         void start(int slot) {
+            mSlot = slot;
             int error = isValid();
             if (error == SUCCESS) {
-                mSlot = slot;
                 Log.d(TAG, "Starting keepalive " + mSlot + " on " + mNai.name());
                 mNai.asyncChannel.sendMessage(CMD_START_PACKET_KEEPALIVE, slot, mInterval, mPacket);
             } else {
-                notifyMessenger(NO_KEEPALIVE, error);
+                handleStopKeepalive(mNai, mSlot, error);
                 return;
             }
         }
@@ -277,6 +277,7 @@
             return;
         }
         ki.stop(reason);
+        Log.d(TAG, "Stopped keepalive " + slot + " on " + networkName);
         networkKeepalives.remove(slot);
         if (networkKeepalives.isEmpty()) {
             mKeepalives.remove(nai);