commit deb0ff2bf4b7a3ffc7440fffc22772dbeca991ea
author Adrian Roos <roosa@google.com> Wed Feb 27 23:58:13 2019 +0100
committer Adrian Roos <roosa@google.com> Thu Feb 28 09:54:08 2019 +0000
tree d599c34b6b7a75cd0791d0bfde1d31726513f633
parent eee18bd546665b726d73769ee3ed5a2368c8c1f1

Apilint: Enforce final builders

Test: run apilint
Bug: 124883027
Change-Id: I7f2866e46bc40be60487846b2af9f8fd7edb7623

tools/apilint/apilint.py

diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py
index 4c02d94..ef405e4 100644
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -1109,6 +1109,9 @@
     if not has_build:
         warn(clazz, None, None, "Missing build() method")
 
+    if "final" not in clazz.split:
+        error(clazz, None, None, "Builder should be final")
+
 
 def verify_aidl(clazz):
     """Catch people exposing raw AIDL."""