commit e5cf7f2bc51913d87bf97c8a1885f736edc5f0bc
author Glenn Kasten <gkasten@google.com> Wed Jan 12 09:34:37 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Wed Jan 12 09:34:37 2011 -0800
tree 7c69bde29ffb94e483d2c9edfbbdc11396908359
parent 688b0af6a888a8a427d9a4c82fedf3e345e6ae34
parent 4e26bc686b619ec9b6db39b7fefb84890904e59c

Merge "Fix race in buffer ref counting." into honeycomb

media/libstagefright/MediaBuffer.cpp

diff --git a/media/libstagefright/MediaBuffer.cpp b/media/libstagefright/MediaBuffer.cpp
index cbccd31..a8fadf2 100644
--- a/media/libstagefright/MediaBuffer.cpp
+++ b/media/libstagefright/MediaBuffer.cpp
@@ -26,17 +26,10 @@
 #include <media/stagefright/MetaData.h>
 
 #include <ui/GraphicBuffer.h>
+#include <sys/atomics.h>
 
 namespace android {
 
-// XXX make this truly atomic.
-static int atomic_add(int *value, int delta) {
-    int prev_value = *value;
-    *value += delta;
-
-    return prev_value;
-}
-
 MediaBuffer::MediaBuffer(void *data, size_t size)
     : mObserver(NULL),
       mNextBuffer(NULL),
@@ -84,7 +77,7 @@
         return;
     }
 
-    int prevCount = atomic_add(&mRefCount, -1);
+    int prevCount = __atomic_dec(&mRefCount);
     if (prevCount == 1) {
         if (mObserver == NULL) {
             delete this;
@@ -104,7 +97,7 @@
 }
 
 void MediaBuffer::add_ref() {
-    atomic_add(&mRefCount, 1);
+    (void) __atomic_inc(&mRefCount);
 }
 
 void *MediaBuffer::data() const {