tree 7fd753bccd2c17953b088f33902f58f7791b0f1d
parent 581a166ae161afb836115989071c97b63c41303a
author Hugo Benichi <hugobenichi@google.com> 1491462104 +0900
committer Andriy Naborskyy <andriyn@google.com> 1501211845 -0700

DO NOT MERGE ANYWHERE ConnectivityService: safer locking

This path changes a dangerous lock path in reportNetworkConnectivity().
This methods is called outside of the main ConnectivityService handler
and takes a lock on a specific NetworkAgentInfo whose connectivity
status is being reported.

While this lock is held, reportNetworkConnectivity() goes on and query
the network policy state for that network, which may ends into
NetworkPolicyManagerService.

Instead, the lock on NetworkAgentInfo is only held long enough to make a
copy of LinkProperties, which is then passed to
NetworkPolicyManagerService without that lock.

Bug: 36902662
Test: could not repro b/36902662, reportNetworkConnectivity() works.
      $ runtest frameworks-net

Change-Id: Iac4b75bcecbdddb0ac695c8b1a87ae755f62f47f