commit ece603b7955938d6001c376f351ca0a2219330ac
author Yuncheol Heo <ycheo@google.com> Fri May 23 20:10:19 2014 +0900
committer Yuncheol Heo <ycheo@google.com> Mon May 26 11:35:09 2014 +0900
tree 62f8d741e2f0f8895dbd3e0c2bd115224417160f
parent 46038ae0207ba6f6a8e04bce7267da7af8767f29

Add the constants for the callback result of SendCecCommand().

- Move the send failure warning messages into HdmiCecController.sendCommand()
  from each Actions.
- Stringfy with more detail messages for some opcodes.

Change-Id: Ib7ce24dd2a1f290e6c3a0b26738772ef1d4a9630

services/core/java/com/android/server/hdmi/HdmiCecController.java

diff --git a/services/core/java/com/android/server/hdmi/HdmiCecController.java b/services/core/java/com/android/server/hdmi/HdmiCecController.java
index 662159d..4792c55 100644
--- a/services/core/java/com/android/server/hdmi/HdmiCecController.java
+++ b/services/core/java/com/android/server/hdmi/HdmiCecController.java
@@ -20,6 +20,7 @@
 import android.hardware.hdmi.HdmiCecDeviceInfo;
 import android.hardware.hdmi.HdmiCecMessage;
 import android.os.Handler;
+import android.util.Slog;
 import android.util.SparseArray;
 import android.util.SparseIntArray;
 
@@ -55,9 +56,6 @@
 
     private static final int NUM_LOGICAL_ADDRESS = 16;
 
-    // TODO: define other constants for errors.
-    private static final int ERROR_SUCCESS = 0;
-
     // Handler instance to process synchronous I/O (mainly send) message.
     private Handler mIoHandler;
 
@@ -210,7 +208,7 @@
                 // it as logical address of the device.
                 int error = nativeSendCecCommand(mNativePtr, curAddress, curAddress,
                         EMPTY_BODY);
-                if (error != ERROR_SUCCESS) {
+                if (error != HdmiControlService.SEND_RESULT_SUCCESS) {
                     logicalAddress = curAddress;
                     break;
                 }
@@ -405,6 +403,9 @@
                 byte[] body = buildBody(cecMessage.getOpcode(), cecMessage.getParams());
                 final int error = nativeSendCecCommand(mNativePtr, cecMessage.getSource(),
                         cecMessage.getDestination(), body);
+                if (error != HdmiControlService.SEND_RESULT_SUCCESS) {
+                    Slog.w(TAG, "Failed to send " + cecMessage);
+                }
                 if (callback != null) {
                     runOnServiceThread(new Runnable() {
                         @Override