commit f44ebf5fcba4dc5f7021a3b72a8f26b11ae23db2
author Treehugger Robot <treehugger-gerrit@google.com> Wed Jul 26 00:12:51 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Jul 26 00:12:51 2017 +0000
tree bbff29504e31acd8b213be7eba83f20307e981fc
parent d00de318f982372f82409df3ad245d65540c68d2
parent 13d7ddac23d21c3301c923e613b738436e3a8d49

Merge "Silence a memory leak warning from the static analyzer"

libs/hwui/TessellationCache.cpp

diff --git a/libs/hwui/TessellationCache.cpp b/libs/hwui/TessellationCache.cpp
index d9e8116..4ea440d 100644
--- a/libs/hwui/TessellationCache.cpp
+++ b/libs/hwui/TessellationCache.cpp
@@ -416,7 +416,9 @@
             mProcessor = new TessellationProcessor(Caches::getInstance());
         }
         mProcessor->add(task);
-        mCache.put(entry, buffer);
+        bool inserted = mCache.put(entry, buffer);
+        // Note to the static analyzer that this insert should always succeed.
+        LOG_ALWAYS_FATAL_IF(!inserted, "buffers shouldn't spontaneously appear in the cache");
     }
     return buffer;
 }