commit f6497e45fae88788b1c67d815458355a1f2f65b5
author Dianne Hackborn <hackbod@google.com> Sun Oct 09 17:14:49 2011 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Sun Oct 09 17:14:49 2011 -0700
tree 91cdbaad8bd5131f9bbbb921e83a3ca5430a756b
parent d78a38cae2f041629326d475333f43fd81ae4137
parent 229edbc38dedbd58fb058da47fc3108276e61de4

Merge "Calling close() outside of the main thread breaks stuff."

core/java/android/content/CursorLoader.java

diff --git a/core/java/android/content/CursorLoader.java b/core/java/android/content/CursorLoader.java
index 50919d5..7af535b 100644
--- a/core/java/android/content/CursorLoader.java
+++ b/core/java/android/content/CursorLoader.java
@@ -50,19 +50,6 @@
 
     Cursor mCursor;
 
-    final static class CloseTask extends AsyncTask<Cursor, Void, Void> {
-        @Override
-        protected Void doInBackground(Cursor... params) {
-            params[0].close();
-            return null;
-        }
-    }
-
-    static void closeAsync(Cursor cursor) {
-        CloseTask closeTask = new CloseTask();
-        closeTask.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, cursor);
-    }
-
     /* Runs on a worker thread */
     @Override
     public Cursor loadInBackground() {
@@ -90,7 +77,7 @@
         if (isReset()) {
             // An async query came in while the loader is stopped
             if (cursor != null) {
-                closeAsync(cursor);
+                cursor.close();
             }
             return;
         }
@@ -102,7 +89,7 @@
         }
 
         if (oldCursor != null && oldCursor != cursor && !oldCursor.isClosed()) {
-            closeAsync(oldCursor);
+            oldCursor.close();
         }
     }
 
@@ -162,7 +149,7 @@
     @Override
     public void onCanceled(Cursor cursor) {
         if (cursor != null && !cursor.isClosed()) {
-            closeAsync(cursor);
+            cursor.close();
         }
     }
 
@@ -174,7 +161,7 @@
         onStopLoading();
 
         if (mCursor != null && !mCursor.isClosed()) {
-            closeAsync(mCursor);
+            mCursor.close();
         }
         mCursor = null;
     }