commit f76afc80d229cf0c918e849acf5d8c4f5d4ffd07
author Jamie Gennis <jgennis@google.com> Fri Oct 14 19:06:55 2011 -0700
committer Jamie Gennis <jgennis@google.com> Fri Oct 14 19:55:12 2011 -0700
tree 34ea727eb9597a948fa5cca1dfb128a7ccae3940
parent 57337eb78e65c160fb9c46a01e04c476d1bfdca1

MediaPlayer: properly handle released surfaces

Bug: 5396571
Change-Id: I6af87cb04f09f9ae6ea77cd7ba31108a3e93d24a

media/jni/android_media_MediaPlayer.cpp

diff --git a/media/jni/android_media_MediaPlayer.cpp b/media/jni/android_media_MediaPlayer.cpp
index f3174fe..63cbf5e 100644
--- a/media/jni/android_media_MediaPlayer.cpp
+++ b/media/jni/android_media_MediaPlayer.cpp
@@ -274,8 +274,14 @@
     sp<ISurfaceTexture> new_st;
     if (jsurface) {
         sp<Surface> surface(Surface_getSurface(env, jsurface));
-        new_st = surface->getSurfaceTexture();
-        new_st->incStrong(thiz);
+        if (surface != NULL) {
+            new_st = surface->getSurfaceTexture();
+            new_st->incStrong(thiz);
+        } else {
+            jniThrowException(env, "java/lang/IllegalArgumentException",
+                    "The surface has been released");
+            return;
+        }
     }
 
     env->SetIntField(thiz, fields.surface_texture, (int)new_st.get());